GitLab

Aleix Pol Gonzalez authored Jul 27, 2020 and Aleix Pol Gonzalez committed Jul 28, 2020

Found when running under ASAN

It's been replaced by PipeWire stuff.

SeatInterface cleans up when a data source goes away. However the
cleanup also makes use of metaobjects so needs to run before the leaf
class destructor is run.

All other AbstractDataSource objects emit the unbound signal, which
SeatInterface also connects to do a earlier cleanup. Otherwise we get a
crash if a data control source replaces itself.

Vlad Zahorodnii authored Jul 16, 2020 and Vlad Zahorodnii committed Jul 16, 2020

Rename the aboutToBeUnbound() signal to aboutToBeDestroyed() in order to
make the usage of the word "destroyed" consistent.

Order of a client teardown is:
 - ClientConnection is removed from the static map
 - All our client owned resources are torn down
 - ClientConnection is deleted (via a previous deleteLater)

The recent refactor led to a behavioural change where ::client could
return a null pointer.

We want the client getter to be valid throughout the lifespan of
SurfaceInterface, by doing the lookup once we achieve that.

BUG: 424255

Vlad Zahorodnii authored Jul 07, 2020 and Vlad Zahorodnii committed Jul 08, 2020

Since we don't do wl_display_run(), wl_display_terminate() is pointless.

Vlad Zahorodnii authored Jul 07, 2020 and Vlad Zahorodnii committed Jul 08, 2020

Display::startLoop() isn't used anywhere and it only adds maintenance
burden, so drop it.

Vlad Zahorodnii authored Jul 06, 2020 and Vlad Zahorodnii committed Jul 08, 2020

It can be especially useful if the compositor wants to ensure that all
globals have been created before starting to accept client connections.

Unfortunately, start() and terminate() stuff doesn't align well with it,
so the terminate() method was dropped to ensure that Display always
returns the same wl_display object.

sendStackingOrderChanged() iterates though all clients. Only the new
client needs to be send information at this point.

The main purpose behind the kwaylandserver library is to provide a set
of re-usable wayland compositor extension implementations. However, it's
worth noting that the design of kwaylandserver is far from perfect at
the moment.

KWaylandServer tries to hide all low level wayland details from the
compositor. But it's not the case with buffers, which diminishes the
whole point behind the library.

Creating OpenGL textures from Wayland buffers is the responsibility of
the compositor. So, when it comes to client buffers, we are one foot in
KWaylandServer, and the other foot in the compositor.

Since the surface size is a logical size, the compositor can't use it
for allocating memory for OpenGL textures. This change adds the buffer
size property in SurfaceInterface that can be used for allocating memory
for textures as well as monitoring buffer size changes.

I must say that the introduction of the buffer size property is a crude
hack because BufferInterface just needs to provide an OpenGL texture for
each plane. The main blocker for that is that it would involve moving
the backend, the compositor, and the wayland bits in the same place, for
example kwayland-server or ultimately kwin.

Vlad Zahorodnii authored Jun 19, 2020 and Vlad Zahorodnii committed Jun 24, 2020

The buffer transform is a pretty confusing thing, so document it in
order to avoid misleading people.

Vlad Zahorodnii authored Jun 19, 2020 and Vlad Zahorodnii committed Jun 24, 2020

The buffer scale and the buffer transform property specify transforms
that had been applied to the buffer's contents. Neither one of those
properties apply to the surface, in other words the buffer transform
property doesn't indicate that the surface was rotated or flipped or both.

This change doesn't gain anything in terms of new features, etc. It just
attempts to make things more clear.

The source can have a different lifespan to the offer being made.
If a source is removed and we get a drag actions changed before the
offer is cancelled we don't want to crash.

Couldn't reproduce locally, but the trace was good.

BUG: 423127

Vlad Zahorodnii authored Jun 10, 2020 and David Edmundson committed Jun 19, 2020

Since we don't guarantee SC and BC in KWaylandServer, we can drop
SurfaceInterface::inputIsInfitine().

David Edmundson authored Jun 18, 2020 and David Edmundson committed Jun 19, 2020

This fixes several unit tests in kwin where the virtual output is not
considered enabled causing behavioural changes.

Vlad Zahorodnii authored Jun 10, 2020 and Vlad Zahorodnii committed Jun 19, 2020

The compositor needs to monitor changes in the mapping between the
surface local coordinates and the buffer coordinates because texture
coordinates correspond to the latter. One way to do it is to monitor
things such as the surface size, the buffer size, the buffer scale,
etc. The main problem with doing so is that there are so many factors
that contribute to how mapping between the surface local coordinate
space and the buffer coordinate space is performed.

In order to provide a generic way for monitoring changes in the mapping
between the surface local coordinate space and the buffer coordinate
space, this patch introduces two new matrices. The first one specifies
how the surface-local coordinates are mapped to buffer coordinates, and
the other one specifies how to map the buffer coordinates to surface
local coordinates.

With the new two matrices, the compositor has a generic way to get
notified when it has to re-compute texture coordinates.

The generated classes don't really have documentation for the generated
methods. This hopes to provide some context.

Vlad Zahorodnii authored Jun 10, 2020 and Vlad Zahorodnii committed Jun 17, 2020

If a buffer is attached to the surface, its width or height cannot be 0.

GIT_SILENT

David Edmundson authored May 30, 2020 and Vlad Zahorodnii committed Jun 15, 2020

Public API is identical except the now uneeded explit create on the
global.