1. 15 Jul, 2020 1 commit
  2. 14 Jul, 2020 3 commits
  3. 29 Apr, 2020 1 commit
  4. 16 Mar, 2020 1 commit
  5. 23 Jan, 2020 1 commit
  6. 20 Nov, 2018 1 commit
  7. 01 Jun, 2016 1 commit
    • Martin Flöser's avatar
      [server] Don't destroy ServerSideDecorationInterface when parent SurfaceInterface is destroyed · 73e89530
      Martin Flöser authored
      Summary:
      Destroying the ServerSideDecorationInterface on the server side before
      the client has a chance to cleanup results in a protocol error:
      wl_display@1: error 0: invalid object 7
      
      Which would terminate the client. If we would not destroy the resource,
      but only delete the ServerSideDecorationInterface it could result in
      heap-use-after-free.
      
      So just don't do anything, the client needs to cleanup which will result
      in the ServerSideDecorationInterface being deleted.
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D1710
      73e89530
  8. 30 May, 2016 2 commits
    • Martin Flöser's avatar
      [server] Standardize the destructor request handling for Resources · 03594de1
      Martin Flöser authored
      Summary:
      This change standardizes the behavior regarding the destructor request.
      
      The destructor should destroy the resource and nothing else. The
      Wayland library invokes the static unbind method once the resource is
      destroyed. The implementation provided by Resource::Private::unbind
      triggers a delete later on the Resource. So there is no need to trigger
      a deleteLater from the destructor request callback.
      
      This change adds a generic implementation to Resource::Private which is
      now used by all inheriting classes replacing the custom implementations.
      
      Test Plan:
      For a few Resources the test is extended to ensure that the Resource
      gets deleted on server side.
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D1679
      03594de1
    • Martin Flöser's avatar
      [server] Don't destroy resource from dtor of a Resource sub class · 59bdc945
      Martin Flöser authored
      Summary:
      Not needed as the dtor of the Resource ensures that the wl_resource
      gets destroyed.
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D1680
      59bdc945
  9. 12 Mar, 2016 1 commit
    • Martin Flöser's avatar
      Add a default mode event to ServerSideDecorationManager · ba479e3e
      Martin Flöser authored
      Summary:
      The ServerSideDecorationManager gains a new event which gets sent
      to the client when it binds the manager. The event indicates the
      default server decoration mode used by the server. This allows the
      client to know the decoration mode when it creates a decoration and
      thus does not need to roundtrip to the server to get the mode.
      
      Reviewers: #plasma, sebas
      
      Subscribers: plasma-devel
      
      Projects: #plasma
      
      Differential Revision: https://phabricator.kde.org/D1129
      ba479e3e
  10. 17 Dec, 2015 1 commit