1. 26 Mar, 2021 5 commits
  2. 25 Mar, 2021 5 commits
  3. 24 Mar, 2021 1 commit
  4. 23 Mar, 2021 3 commits
  5. 22 Mar, 2021 12 commits
  6. 19 Mar, 2021 2 commits
  7. 17 Mar, 2021 3 commits
  8. 16 Mar, 2021 3 commits
    • Vlad Zahorodnii's avatar
      Send an icon only if there is one · 90393d7d
      Vlad Zahorodnii authored
      Currently, plasma window model test fails because the null icon is
      received after executing the main body of the test.
      
          FAIL!  : PlasmaWindowModelTest::testVirtualDesktops() '!dataChangedSpy.wait(100)' returned FALSE. ()
             Loc: [/data/projects/src/kwayland-server/autotests/client/test_plasma_window_model.cpp(583)]
      
      We can fix the test by waiting for the iconChanged signal to be emitted,
      but we will need to wait in all tests too. Furthermore, it doesn't make a
      lot of sense to wait for an icon that was never set.
      
      This change makes the compositor send an icon only if there is one.
      
      It's a behavioral change, but it shouldn't regress anything because kwin
      always sets icons via the plasma window management protocol even for apps
      that have no valid app id.
      
      It also makes the api of the PlasmaWindowInterface class more intuitive.
      90393d7d
    • Vlad Zahorodnii's avatar
      autotests: Fix testWindowmanagement · eda53c7f
      Vlad Zahorodnii authored
      Currently, testIcon fails because the actual and the expected pixmaps
      have mismatching formats.
      
      The root cause is that images with an alpha channel will loose the alpha
      channel if they are converted to QPixmap using QPixmap::fromImage().
      
      The >> stream operator for the QPixmap class will deserialize pixel data
      in a temporary QImage and then use QPixmap::fromImage() to get a pixmap
      object.
      
      The >> stream operator for the QIcon class will delegate the task of
      reading the icon from a QDataStream to QPixmapIconEngine, which uses the
      >> stream operator under the hood to deserialize icon data.
      
      In order to fix testIcon, this change constructs a dummy icon from a
      pixmap object returned by QPixmap::fromImage().
      eda53c7f
    • Vlad Zahorodnii's avatar
      Remove @since version tags · 33301a94
      Vlad Zahorodnii authored
      Currently, we have a mix of Frameworks versions and Plasma versions in
      @since tags, which leads to some confusion. Since this is an unstable
      library, one cannot rely on since version tags, we are free to add,
      change, and remove apis to serve best to kwin requirements. Thus, we can
      simply remove all since version tags to fix mixing up different product
      versions.
      33301a94
  9. 15 Mar, 2021 6 commits