Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KWayland Server
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • KWayland Server
  • Merge requests
  • !310

Emit DataOfferInterface::dragAndDropActionsChanged() only if dnd actions change

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Vlad Zahorodnii requested to merge work/zzag/firefox-positive-feedback-loop into master Oct 27, 2021
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 1

With some apps, firefox specifically, it's possible to enter a dnd positive feedback loop, e.g.

  • kwin sends wl_data_offer::action event
  • the app reacts to it and calls wl_data_offer::set_actions() with the same actions
  • kwin re-sends the wl_data_offer::action event because DataOfferInterface::dragAndDropActionsChanged() has been emitted
  • the app calls wl_data_offer::set_actions() again, and so on...

This should make D&D in Firefox more responsive.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/zzag/firefox-positive-feedback-loop