Skip to content
  • David Edmundson's avatar
    [scripting] Fix effect.animate() curve argument being actually used · 3332b321
    David Edmundson authored
    Summary:
    One cannot use a non metatype frrom an external class inside an
    invokable. https://bugreports.qt.io/browse/QTBUG-58454
    
    End result is the script engine arguments wouldn't match up and MOC
    would just use the default value.
    
    As far as I can tell this has been broken for 6 years.
    The global animate method that unboxes a QJSValue as an object is
    unaffected.
    No shipped kwin effect actually used it.
    
    To some extent we didn't even actually want to enforce the enum as we
    also accept custom value of ScriptedEffect::GuassianCurve, so it has
    been switched for an int.
    
    Test Plan: Unit test
    
    Reviewers: #kwin, broulik
    
    Reviewed By: broulik
    
    Subscribers: kwin
    
    Tags: #kwin
    
    Differential Revision: https://phabricator.kde.org/D14669
    3332b321