Skip to content
  • Erik Kurzinger's avatar
    [effects/desktopgrid] Specify screen projection matrix when drawing moving window · 408ed806
    Erik Kurzinger authored and Vlad Zahorodnii's avatar Vlad Zahorodnii committed
    Summary:
    Currently, when the user is moving a window in the desktop grid it is drawn from
    the paintScreen function to ensure it appears above all other windows. However,
    when drawing the window, the screenProjectionMatrix for the WindowPaintData structure
    is never specified. Because of this, the window will not be visible if OpenGL
    compositing along with Lanczos scaling are in use since its coordinates will never
    be projected into screen-space (unless the window is maximized, in which case the
    scaling code is bypassed).
    
    BUG: 361371
    BUG: 364509
    
    FIXED-IN: 5.14.3
    
    Test Plan:
    Ensure OpenGL compositing is enabled and the scaling method is set to "Accurate" on
    hardware supporting this option. Additionally, ensure the desktop grid effect is
    active and is configured to use Present Windows. Open a window and ensure is it not
    maximized. Click on the window and drag it around - its contents should remain visible
    the entire time and follow the mouse.
    
    Reviewers: #kwin, zzag, graesslin, davidedmundson
    
    Reviewed By: #kwin, zzag, davidedmundson
    
    Subscribers: broulik, davidedmundson, kwin, #kwin
    
    Tags: #kwin
    
    Differential Revision: https://phabricator.kde.org/D16430
    408ed806