Skip to content
  • Vlad Zahorodnii's avatar
    Run clang-tidy with modernize-use-override check · 8af2fa73
    Vlad Zahorodnii authored
    Summary:
    Currently code base of kwin can be viewed as two pieces. One is very
    ancient, and the other one is more modern, which uses new C++ features.
    
    The main problem with the ancient code is that it was written before
    C++11 era. So, no override or final keywords, lambdas, etc.
    
    Quite recently, KDE compiler settings were changed to show a warning if
    a virtual method has missing override keyword. As you might have already
    guessed, this fired back at us because of that ancient code. We had
    about 500 new compiler warnings.
    
    A "solution" was proposed to that problem - disable -Wno-suggest-override
    and the other similar warning for clang. It's hard to call a solution
    because those warnings are disabled not only for the old code, but also
    for new. This is not what we want!
    
    The main argument for not actually fixing the problem was that git
    history will be screwed as well because of human factor. While good git
    history is a very important thing, we should not go ...
    8af2fa73