Skip to content
  • Martin Flöser's avatar
    [qpa] Prevent crash due to Surface getting null · 962a2e39
    Martin Flöser authored
    Summary:
    This is a regression due to changes in Breeze to support Qt 5.8+ behavior
    change. KWin's own QPA operates like < Qt 5.7 and breeze was programmed
    against that. Due to that it can happen now that Breeze hits code paths
    in which KWin does not have a surface.
    
    To trigger one only needed to open the user actions menu twice.
    
    This change adds a test case which simulates the problem and fixes all
    crashes happening in the code path.
    
    Most likely shadows are now broken for KWin's own windows, this change is
    only to prevent the crash and thus is for 5.10 branch, while shadow
    fixing will go to master branch.
    
    BUG: 382063
    FIXED-IN: 5.10.4
    
    Test Plan: New test case
    
    Reviewers: #kwin, #plasma
    
    Subscribers: plasma-devel, kwin
    
    Tags: #kwin
    
    Differential Revision: https://phabricator.kde.org/D6533
    962a2e39