• Vlad Zahorodnii's avatar
    [effects/desktopgrid] Don't display the close button from Present Windows · 558b86e9
    Vlad Zahorodnii authored
    Summary:
    If you activate the Present Windows effect and then the Desktop Grid,
    you'll be able to see the close button from PW. The reason for that is
    PW doesn't destroy the close button and DG doesn't filter it out.
    
    This patch addesses this problem by syncing DesktopGridEffect::isRelevantWithPresentWindows
    with PresentWindowsEffect::isSelectableWindow.
    
    On X11, the close button is filtered by the isSpecialWindow check. On
    Wayland, the close button is filtered by the acceptsFocus check.
    
    The proposed solution is kinda hack-ish, but on the other hand, we have
    to keep those two methods in sync anyway.
    
    In addition to the close button, notifications won't be displayed too.
    
    BUG: 364710
    FIXED-IN: 5.14.3
    
    Test Plan:
    * Activate the Present Windows effect;
    * Activate the Desktop Grid effect;
    * (the close button is no longer visible)
    
    Reviewers: #kwin, graesslin
    
    Reviewed By: #kwin, graesslin
    
    Subscribers: kwin
    
    Tags: #kwin
    
    Differential Revision: https://phabricator.kde.org/D16513
    558b86e9
desktopgrid.cpp 57.4 KB