Skip to content
  • Vlad Zahorodnii's avatar
    [libkwineffects] Save value of the managed property during construction of EffectWindow · f977e608
    Vlad Zahorodnii authored
    Summary:
    When windowClosed signal is emitted, effects can't distinguish managed
    windows from unmanaged windows(e.g. combo box popups, popup menus, etc).
    This leads to dirty hacks like IsXXXWindow. Also, there's a big chance
    that such hack can introduce more bugs and overall this makes harder to
    write/maintain effects.
    
    This change proposes to save value of managed property during
    construction of EffectWindow. So, its value is preserved with Deleted.
    
    Test Plan: Manually.
    
    Reviewers: #kwin, graesslin
    
    Reviewed By: #kwin, graesslin
    
    Subscribers: graesslin, kwin
    
    Tags: #kwin
    
    Differential Revision: https://phabricator.kde.org/D13690
    f977e608