Commit 1115ca84 authored by Igor Poboiko's avatar Igor Poboiko

[effects/cubeslide] Fix "sticky" windows detection on Wayland

Summary: This is second part of {D15175}, and aimed at fixing Bug 390366.
The problem was that effect relied on isManaged() to detect OSDs and notifications, that should be painted on top of the cube. On Wayland, the desktop window itself is not managed, which made it "sticky".

Instead we use isSpecialWindow() check to explicitly make notifications and OSDs sticky.
It still requires fixing Plasma::Dialog, since it does not set isSpecialWindow() flag correctly.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision:

BUG: 390366
FIXED-IN: 5.15.0
parent b02d7ff9
......@@ -541,7 +541,7 @@ bool CubeSlideEffect::shouldAnimate(const EffectWindow* w) const
if (w->isDesktop()) {
return true;
if (!w->isManaged()) {
if (w->isSpecialWindow()) {
return false;
return !dontSlideStickyWindows;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment