Commit 1f8a65c4 authored by Eric Edlund's avatar Eric Edlund Committed by Vlad Zahorodnii
Browse files

Rename DEFAULT_MINIMUM_SCALE_DELTA in GestureRecognizer

This constant is now DEFAULT_UNIT_SCALE_DELTA.
This makes more sense now that we're using realtime gestures.
parent 4854296b
Pipeline #154065 passed with stage
in 12 minutes and 14 seconds
......@@ -316,7 +316,7 @@ void GestureTest::testSetMinimumDelta()
PinchGesture pinchGesture;
QCOMPARE(pinchGesture.isMinimumScaleDeltaRelevant(), false);
QCOMPARE(pinchGesture.minimumScaleDelta(), DEFAULT_MINIMUM_SCALE_DELTA);
QCOMPARE(pinchGesture.minimumScaleDelta(), DEFAULT_UNIT_SCALE_DELTA);
QCOMPARE(pinchGesture.minimumScaleDeltaReached(1.25), true);
pinchGesture.setMinimumScaleDelta(.5);
QCOMPARE(pinchGesture.isMinimumScaleDeltaRelevant(), true);
......
......@@ -19,7 +19,12 @@
namespace KWin
{
static const qreal DEFAULT_MINIMUM_SCALE_DELTA = .2; // 20%
/*
* Everytime the scale of the gesture changes by this much, the callback changes by 1.
* This is the amount of change for 1 unit of change, like switch by 1 desktop.
* */
static const qreal DEFAULT_UNIT_SCALE_DELTA = .2; // 20%
class Gesture : public QObject
{
Q_OBJECT
......@@ -171,7 +176,7 @@ private:
uint m_maximumFingerCount = 0;
Direction m_direction = Direction::Expanding;
bool m_minimumScaleDeltaRelevant = false;
qreal m_minimumScaleDelta = DEFAULT_MINIMUM_SCALE_DELTA;
qreal m_minimumScaleDelta = DEFAULT_UNIT_SCALE_DELTA;
};
class KWIN_EXPORT GestureRecognizer : public QObject
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment