Commit 2715cbc8 authored by Vlad Zahorodnii's avatar Vlad Zahorodnii
Browse files

Transform a pending repaint into a workspace repaint before destroying Deleted

The sliding popups effect schedules a repaint and then unreferences the
deleted window. The problem with doing so is that the scheduled repaint
will be effectively discarded because the Deleted will be destroyed once
we are back in the event loop.

This issue is most noticeable on Wayland. Not sure why. If you close
Kickoff, you may see its flickering ghost in background.

If it happens that a Deleted has a pending repaint, transform it into a
workspace repaint to avoid discarding any scheduled repaints.
parent 54427623
......@@ -47,6 +47,11 @@ Deleted::Deleted()
const QRegion dirty = repaints();
if (!dirty.isEmpty()) {
if (delete_refcount != 0)
qCCritical(KWIN_CORE) << "Deleted client has non-zero reference count (" << delete_refcount << ")";
Q_ASSERT(delete_refcount == 0);
......@@ -504,6 +504,13 @@ void Toplevel::addWorkspaceRepaint(const QRect& r2)
void Toplevel::addWorkspaceRepaint(const QRegion &region)
if (compositing()) {
void Toplevel::setReadyForPainting()
if (!ready_for_painting) {
......@@ -466,6 +466,7 @@ public:
// these call workspace->addRepaint(), but first transform the damage if needed
void addWorkspaceRepaint(const QRect& r);
void addWorkspaceRepaint(int x, int y, int w, int h);
void addWorkspaceRepaint(const QRegion &region);
QRegion repaints() const;
void resetRepaints();
QRegion damage() const;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment