Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Plasma
KWin
Commits
8f104815
Commit
8f104815
authored
Nov 22, 2020
by
Xaver Hugl
Committed by
David Edmundson
Nov 22, 2020
Browse files
Add a QRect to showWindowMenu
This is so we don't have to rely on the cursor position for the popup
BUG: 393163
parent
5e60e64a
Changes
4
Hide whitespace changes
Inline
Side-by-side
decorations/decoratedclient.cpp
View file @
8f104815
...
...
@@ -226,10 +226,9 @@ void DecoratedClientImpl::requestHideToolTip()
m_toolTipShowing
=
false
;
}
void
DecoratedClientImpl
::
requestShowWindowMenu
()
void
DecoratedClientImpl
::
requestShowWindowMenu
(
const
QRect
&
rect
)
{
// TODO: add rect to requestShowWindowMenu
Workspace
::
self
()
->
showWindowMenu
(
QRect
(
Cursors
::
self
()
->
mouse
()
->
pos
(),
Cursors
::
self
()
->
mouse
()
->
pos
()),
m_client
);
Workspace
::
self
()
->
showWindowMenu
(
QRect
(
m_client
->
pos
()
+
rect
.
topLeft
(),
m_client
->
pos
()
+
rect
.
bottomRight
()),
m_client
);
}
void
DecoratedClientImpl
::
requestShowApplicationMenu
(
const
QRect
&
rect
,
int
actionId
)
...
...
decorations/decoratedclient.h
View file @
8f104815
...
...
@@ -70,7 +70,7 @@ public:
void
requestContextHelp
()
override
;
void
requestToggleMaximization
(
Qt
::
MouseButtons
buttons
)
override
;
void
requestMinimize
()
override
;
void
requestShowWindowMenu
()
override
;
void
requestShowWindowMenu
(
const
QRect
&
rect
)
override
;
void
requestShowApplicationMenu
(
const
QRect
&
rect
,
int
actionId
)
override
;
void
requestToggleKeepAbove
()
override
;
void
requestToggleKeepBelow
()
override
;
...
...
kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp
View file @
8f104815
...
...
@@ -391,8 +391,9 @@ void PreviewClient::requestToggleKeepBelow()
setKeepBelow
(
!
isKeepBelow
());
}
void
PreviewClient
::
requestShowWindowMenu
()
void
PreviewClient
::
requestShowWindowMenu
(
const
QRect
&
rect
)
{
Q_UNUSED
(
rect
)
emit
showWindowMenuRequested
();
}
...
...
kcmkwin/kwindecoration/declarative-plugin/previewclient.h
View file @
8f104815
...
...
@@ -93,7 +93,7 @@ public:
void
requestToggleKeepAbove
()
override
;
void
requestToggleKeepBelow
()
override
;
void
requestToggleShade
()
override
;
void
requestShowWindowMenu
()
override
;
void
requestShowWindowMenu
(
const
QRect
&
rect
)
override
;
void
requestShowApplicationMenu
(
const
QRect
&
rect
,
int
actionId
)
override
;
void
requestToggleOnAllDesktops
()
override
;
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment