libkwineffects: Drop windowPaddingChanged signal

It makes no sense on Wayland.

src/effects.cpp

@@ -322,7 +322,6 @@ void EffectsHandlerImpl::setupClientConnections(AbstractClient* c)
     connect(c, &AbstractClient::geometryShapeChanged, this, &EffectsHandlerImpl::slotGeometryShapeChanged);
     connect(c, &AbstractClient::frameGeometryChanged, this, &EffectsHandlerImpl::slotFrameGeometryChanged);
     connect(c, &AbstractClient::damaged,              this, &EffectsHandlerImpl::slotWindowDamaged);
-    connect(c, &AbstractClient::paddingChanged,       this, &EffectsHandlerImpl::slotPaddingChanged);
     connect(c, &AbstractClient::unresponsiveChanged, this,
         [this, c](bool unresponsive) {
             emit windowUnresponsiveChanged(c->effectWindow(), unresponsive);
@@ -366,7 +365,6 @@ void EffectsHandlerImpl::setupUnmanagedConnections(Unmanaged* u)
     connect(u, &Unmanaged::opacityChanged,       this, &EffectsHandlerImpl::slotOpacityChanged);
     connect(u, &Unmanaged::geometryShapeChanged, this, &EffectsHandlerImpl::slotGeometryShapeChanged);
     connect(u, &Unmanaged::frameGeometryChanged, this, &EffectsHandlerImpl::slotFrameGeometryChanged);
-    connect(u, &Unmanaged::paddingChanged,       this, &EffectsHandlerImpl::slotPaddingChanged);
     connect(u, &Unmanaged::damaged,              this, &EffectsHandlerImpl::slotWindowDamaged);
     connect(u, &Unmanaged::visibleGeometryChanged, this, [this, u]() {
         emit windowExpandedGeometryChanged(u->effectWindow());
@@ -627,15 +625,6 @@ void EffectsHandlerImpl::slotFrameGeometryChanged(Toplevel *toplevel, const QRec
     }
 }
 
-void EffectsHandlerImpl::slotPaddingChanged(Toplevel* t, const QRect& old)
-{
-    // during late cleanup effectWindow() may be already NULL
-    // in some functions that may still call this
-    if (t == nullptr || t->effectWindow() == nullptr)
-        return;
-    emit windowPaddingChanged(t->effectWindow(), old);
-}
-
 void EffectsHandlerImpl::setActiveFullScreenEffect(Effect* e)
 {
     if (fullscreen_effect == e) {

src/effects.h

@@ -297,7 +297,6 @@ protected Q_SLOTS:
     void slotClientModalityChanged();
     void slotGeometryShapeChanged(KWin::Toplevel *t, const QRect &old);
     void slotFrameGeometryChanged(Toplevel *toplevel, const QRect &oldGeometry);
-    void slotPaddingChanged(KWin::Toplevel *t, const QRect &old);
     void slotWindowDamaged(KWin::Toplevel *t, const QRegion& r);
     void slotOutputEnabled(AbstractOutput *output);
     void slotOutputDisabled(AbstractOutput *output);

src/libkwineffects/kwineffects.h

@@ -1547,13 +1547,6 @@ Q_SIGNALS:
      * @since 5.19
      */
     void windowFrameGeometryChanged(KWin::EffectWindow *window, const QRect &oldGeometry);
-    /**
-     * Signal emitted when the padding of a window changed. (eg. shadow size)
-     * @param w The window whose geometry changed
-     * @param old The previous expandedGeometry()
-     * @since 4.9
-     */
-    void windowPaddingChanged(KWin::EffectWindow *w, const QRect &old);
     /**
      * Signal emitted when the windows opacity is changed.
      * @param w The window whose opacity level is changed.

src/toplevel.cpp

@@ -436,7 +436,6 @@ bool Toplevel::isOnOutput(AbstractOutput *output) const
 
 void Toplevel::updateShadow()
 {
-    const QRect oldVisibleRect = visibleGeometry();
     if (shadow()) {
         if (!effectWindow()->sceneWindow()->shadow()->updateShadow()) {
             effectWindow()->sceneWindow()->updateShadow(nullptr);
@@ -445,8 +444,6 @@ void Toplevel::updateShadow()
     } else {
         Shadow::createShadow(this);
     }
-    if (oldVisibleRect != visibleGeometry())
-        emit paddingChanged(this, oldVisibleRect);
 }
 
 Shadow *Toplevel::shadow()

src/toplevel.h

@@ -585,7 +585,6 @@ Q_SIGNALS:
      */
     void geometryChanged();
     void geometryShapeChanged(KWin::Toplevel* toplevel, const QRect& old);
-    void paddingChanged(KWin::Toplevel* toplevel, const QRect& old);
     void windowClosed(KWin::Toplevel* toplevel, KWin::Deleted* deleted);
     void windowShown(KWin::Toplevel* toplevel);
     void windowHidden(KWin::Toplevel* toplevel);