Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Plasma
KWin
Commits
dbf52ebd
Commit
dbf52ebd
authored
Oct 13, 2020
by
Vlad Zahorodnii
Committed by
Aleix Pol Gonzalez
Oct 13, 2020
Browse files
launcher: Fix a file descriptor leak
The file descriptor must be closed after sending a ReleaseDevice request.
parent
f369a355
Changes
1
Hide whitespace changes
Inline
Side-by-side
logind.cpp
View file @
dbf52ebd
...
...
@@ -378,14 +378,15 @@ void LogindIntegration::releaseDevice(int fd)
struct
stat
st
;
if
(
fstat
(
fd
,
&
st
)
<
0
)
{
qCDebug
(
KWIN_CORE
)
<<
"Could not stat the file descriptor"
;
return
;
}
else
{
QDBusMessage
message
=
QDBusMessage
::
createMethodCall
(
m_sessionControllerService
,
m_sessionPath
,
m_sessionControllerSessionInterface
,
QStringLiteral
(
"ReleaseDevice"
));
message
.
setArguments
(
QVariantList
({
QVariant
(
major
(
st
.
st_rdev
)),
QVariant
(
minor
(
st
.
st_rdev
))}));
m_bus
.
asyncCall
(
message
);
}
QDBusMessage
message
=
QDBusMessage
::
createMethodCall
(
m_sessionControllerService
,
m_sessionPath
,
m_sessionControllerSessionInterface
,
QStringLiteral
(
"ReleaseDevice"
));
message
.
setArguments
(
QVariantList
({
QVariant
(
major
(
st
.
st_rdev
)),
QVariant
(
minor
(
st
.
st_rdev
))}));
m_bus
.
asyncCall
(
message
);
close
(
fd
);
}
void
LogindIntegration
::
pauseDevice
(
uint
devMajor
,
uint
devMinor
,
const
QString
&
type
)
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment