Commit e38ecfcb authored by Vlad Zahorodnii's avatar Vlad Zahorodnii
Browse files

[effects/slide] Completely delete forced roles

The slide effect doesn't completely remove forced blur and background
contrast roles. According to `EffectWindow::setData` implementation,

void EffectWindowImpl::setData(int role, const QVariant &data)
    if (!data.isNull())
        dataMap[ role ] = data;
    emit effects->windowDataChanged(this, role);

in order to delete previously set data, we should pass a null variant.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: davidedmundson, kwin

Tags: #kwin

Differential Revision:
parent 1a1845b7
......@@ -456,12 +456,12 @@ void SlideEffect::start(int old, int current, EffectWindow* movingWindow)
void SlideEffect::stop()
for (EffectWindow* w : m_forcedRoles.blur) {
w->setData(WindowForceBlurRole, QVariant(false));
w->setData(WindowForceBlurRole, QVariant());
for (EffectWindow* w : m_forcedRoles.backgroundContrast) {
w->setData(WindowForceBackgroundContrastRole, QVariant(false));
w->setData(WindowForceBackgroundContrastRole, QVariant());
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment