1. 22 Jan, 2017 1 commit
  2. 21 Jan, 2017 1 commit
  3. 20 Jan, 2017 1 commit
    • Rafał Szalecki's avatar
      Fixed initial graying out options in Cube Effect settings · a43049f6
      Rafał Szalecki authored
      Typically after deselecting "Show caps" option, the associated options "Cap color" and "Display image on caps" are grayed out (triggered by signal). The bug was when Desktop Cube settings were closed and opened again then the options were not grayed out.
      
      Succesfully compiled and tested by deselecting "Show caps" option in Desktop Cube settings, closing the settings window and opening it once again. The options "Cap color" and "Display image on caps" were then grayed out.
      
      REVIEW: 129194
      a43049f6
  4. 16 Jan, 2017 1 commit
  5. 27 Dec, 2016 1 commit
  6. 13 Dec, 2016 1 commit
  7. 05 Dec, 2016 1 commit
  8. 02 Dec, 2016 1 commit
  9. 28 Nov, 2016 1 commit
    • David Edmundson's avatar
      Align configure button consistently across delegates · d0e0f6c8
      David Edmundson authored
      Summary:
      Currently the configure button is aligned to the win decoration in the
      background. This is bound to 40 - the inactive decorations shadow.
      
      This means the configure button ends up in different places across each
      item,
      looking a bit weird and potentially not even on top of the right
      delegate.
      
      This patch aligns the configure button relative to the overall delegate
      so that it's in the same place on every item
      
      Test Plan: Looked at KCM
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D3526
      
      BUG: 372685
      d0e0f6c8
  10. 25 Nov, 2016 1 commit
  11. 22 Nov, 2016 1 commit
  12. 18 Nov, 2016 1 commit
    • Martin Flöser's avatar
      Fix AbstractClient::sizeForClientSize · 16c7650d
      Martin Flöser authored
      Summary:
      The method is supposed to return the AbstractClient's size for a given
      client size. That is the size including the window decoration.
      
      The default implementation returned the passed in client size without
      adjusting for the decoration. This resulted in ShellClient getting a
      wrong size especially when AbstractClient::adjustedClientSize (which
      calls sizeForClientSize) was called.
      
      The result of the incorrect size was for example a shrinking of the
      window when starting to resize a window.
      
      BUG: 370345
      FIXED-IN: 5.8.4
      
      Reviewers: #kwin, #plasma_on_wayland, broulik, subdiff
      
      Subscribers: plasma-devel, kwin
      
      Tags: #plasma_on_wayland, #kwin
      
      Differential Revision: https://phabricator.kde.org/D3414
      16c7650d
  13. 07 Nov, 2016 4 commits
    • Martin Flöser's avatar
      Ensure that all Effects honour the grab roles correctly · fb69b791
      Martin Flöser authored
      Summary:
      When windows get added some effects grab the window and want to be the
      only one animating this window. For this the grab roles exists. An
      effect being notified later on evaluates the grab state and does not
      start the animation.
      
      This process failed due to being dependent on the order the effects are
      loaded. Window Added/Closed are signals emitted by EffectsHandler, thus
      first come, first serve. The requested effect order does not play into
      it.
      
      Due to that it could happen that an Effect which should not animate,
      started to animate as the grab was still there.
      
      This change adds the possibility to be notified whenever the window data
      changes. A new signal is added to EffectsHandler which is emitted
      whenever the windowData changes. The interested effects connect to it
      and cancel their (just started) animation for the window.
      
      Adjusted effects are:
      * ScaleIn
      * Fade
      * WobblyWindows
      
      In case of WobblyWindows an additional logical error was fixed that the
      animations were only run when an effect grabbed instead of the other way
      around.
      
      BUG: 336866
      FIXED-IN: 5.8.4
      
      Reviewers: #kwin, #plasma, broulik
      
      Subscribers: plasma-devel, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D3211
      fb69b791
    • Martin Flöser's avatar
      Unpolish QStyle on QApp prior to destroying internal Wayland connection · ee7da425
      Martin Flöser authored
      Summary:
      The QStyle might interact with our internal Wayland connection. If the
      cleanup happens after destroying our internal Wayland connection KWin
      will crash at tear-down.
      
      With this change the QStyle can perform cleanup already prior to the
      deconstruction of the Wayland connection.
      
      CCBUG: 372001
      
      Reviewers: #kwin, #plasma_on_wayland
      
      Subscribers: plasma-devel, kwin
      
      Tags: #plasma_on_wayland, #kwin
      
      Differential Revision: https://phabricator.kde.org/D3241
      ee7da425
    • Martin Flöser's avatar
      [helpers/killer] Force to platform XCB · f3325a1c
      Martin Flöser authored
      Summary:
      The killer can only kill X11 windows. It is also only invoked for Client
      and not for ShellClient. The tool interacts with QX11Info which means it
      would crash if tried to use on Wayland.
      
      Thus force platform xcb on the tool.
      
      Test Plan: Killer shows for Xwayland windows.
      
      Reviewers: #kwin, #plasma_on_wayland
      
      Subscribers: plasma-devel, kwin
      
      Tags: #plasma_on_wayland, #kwin
      
      Differential Revision: https://phabricator.kde.org/D3228
      f3325a1c
    • Martin Flöser's avatar
      Simplify the window title passed in from the window system · 2a155925
      Martin Flöser authored
      Summary:
      So far KWin used the window title provided from the window directly
      without any sanitizing. This could result in broken window decorations
      if the title included line breaks. Those were passed to the decoration
      and depending on the way how the decoration renders the title, it could
      result in visual breakage.
      
      Having line breaks in a window title doesn't make sense. Given that KWin
      now simplifies the title when copying it to it's own structure. This
      also ensures that the title passed to e.g. task manager does not have
      any line breaks on Wayland.
      
      BUG: 323798
      FIXED-IN: 5.8.4
      
      Test Plan: Opened the web page in a nested KWin, properly rendered now.
      
      Reviewers: #kwin, #plasma
      
      Subscribers: plasma-devel, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D3215
      2a155925
  14. 04 Nov, 2016 4 commits
    • Martin Flöser's avatar
      [desktopgrid] Don't manipulate virtual desktop of desktop window · 3c637139
      Martin Flöser authored
      Summary:
      Desktop Grid has a feature that right or middle clicking a window toggles
      the on all desktop state. If that is done for a desktop window, things
      obviously start to fail.
      
      KWin internally allows to change virtual desktop for all windows, even
      for windows like the desktop or docks. Changing in KWin core is not a
      solution.
      
      Thus a special casing in desktop grid is added to disallow the selection
      for desktop windows.
      
      BUG: 372037
      FIXED-IN: 5.8.4
      
      Test Plan: Tried right clicking desktop window and other windows.
      
      Reviewers: #kwin, #plasma
      
      Subscribers: plasma-devel, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D3253
      3c637139
    • Martin Flöser's avatar
      Invert the scroll direction for wheel events on internal windows · da0ba763
      Martin Flöser authored
      Summary:
      For whatever reason Qt scrolled the wrong way on internal windows. As a
      new QWheelEvent is constructed anyway, just multiply by -1 to get the
      direction fixed.
      
      BUG: 371999
      FIXED-IN: 5.8.4
      
      Test Plan: Tried debug console in nested setup, scrolled correctly now.
      
      Reviewers: #kwin, #plasma_on_wayland, broulik
      
      Subscribers: plasma-devel, kwin
      
      Tags: #plasma_on_wayland, #kwin
      
      Differential Revision: https://phabricator.kde.org/D3247
      da0ba763
    • Martin Flöser's avatar
      Internal windows cannot be minimized · db58c421
      Martin Flöser authored
      Summary:
      This change ensures that the DebugConsole does not have a minimize
      button.
      
      BUG: 372000
      FIXED-IN: 5.8.4
      
      Reviewers: #kwin, #plasma_on_wayland, broulik
      
      Subscribers: plasma-devel, kwin
      
      Tags: #plasma_on_wayland, #kwin
      
      Differential Revision: https://phabricator.kde.org/D3244
      db58c421
    • Martin Flöser's avatar
      [autotests/libinput] Extend the Device test · fb4b0c40
      Martin Flöser authored
      Added tests for new functionality:
      * scroll enabled by default properties
      * scroll supported properties
      * scroll on button down
      fb4b0c40
  15. 03 Nov, 2016 8 commits
  16. 02 Nov, 2016 3 commits
    • James Pike's avatar
      Support for workspace.clientList() in declarative script · 4730be08
      James Pike authored
      Summary:
      The version provided is only compatible with QtScript so it became
      necessary to split WorkspaceWrapper into a base class and two child
      classes, one for QtScript and one for QmlScript.
      
      BUG: 340125
      FIXED-IN: 5.8.4
      REVIEW: D3185
      4730be08
    • David Edmundson's avatar
      Correctly set i18n suffix in mousemark spinbox. · 254690e8
      David Edmundson authored
      Summary:
      QSpinBox can't handle plural suffixes. Something previously done by
      KIntSpinBox.
      
      Using setSuffix(ki18np("pixel", "pixels")).toString() does nothing, as
      at the time of conversion we don't know which one to use.
      
      This patch uses KPluralHandlingSpinBox and correct ki18np.
      
      Note, "new" dependency was already linked implicitly in other kwin, but
      we need to add it for this KCM.
      
      Test Plan:
      Opened KCM (in English) set counter to 1 pixel and 2 pixels.
      No longer had a big warning. Also appropriate number of s's appeared.
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D3222
      254690e8
    • Martin Flöser's avatar
      [autotests] Add test case for snap to auto-hiding panel · 3a179f32
      Martin Flöser authored
      Workspace::adjustClientPosition incorrectly snaps against an auto hidden
      panel as the test shows.
      
      CCBUG: 365892
      3a179f32
  17. 01 Nov, 2016 1 commit
  18. 31 Oct, 2016 6 commits
    • Martin Flöser's avatar
      [autotest] Add test case for window caption need to be simplified · 55a0afca
      Martin Flöser authored
      The test illustrates that special characters like a line break are not
      removed from the window caption, which results in a line break added in
      the window decoration.
      
      Test case uses a title from a web page triggering it in Firefox.
      
      CCBUG: 323798
      55a0afca
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 9e23d20f
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      9e23d20f
    • Martin Flöser's avatar
      Send a pointer leave when triggering a move resize · 82054a40
      Martin Flöser authored
      Summary:
      When triggering a move resize all following pointer events are grabbed
      by KWin itself. Thus the correct behavior is to informe the client about
      it and send a pointer leave.
      
      This ensures that after the move resize ended the pointer gets a new
      enter. By sending anew pointer enter the position gets updated to the
      new position which so far did not happen and the client generated events
      on the wrong position.
      
      BUG: 371573
      FIXED-IN: 5.8.3
      
      Reviewers: #kwin, #plasma_on_wayland, broulik
      
      Subscribers: plasma-devel, kwin
      
      Tags: #plasma_on_wayland, #kwin
      
      Differential Revision: https://phabricator.kde.org/D3154
      82054a40
    • Martin Flöser's avatar
      [autotest] Make SlidingPopupsTest a little bit more robust · e4930c0c
      Martin Flöser authored
      The first test case was sometimes failing due to the time value in the
      first render pass being too high. So that the effect ended directly for
      the window.
      
      This change adds a small waiting time for the compositor to render prior
      to the creation of the window. Ideally we would connect to frameRendered
      signal, but the OpenGL compositor doesn't emit it yet.
      e4930c0c
    • Martin Flöser's avatar
      [autotests] Extend SlidingPopupTests for Wayland windows · 3aeb7367
      Martin Flöser authored
      Same test case as for X11 windows added for Wayland windows.
      3aeb7367
    • Martin Flöser's avatar
      [autotests] Extend SlidingPopupsTest::testWithOtherEffect · b84fd503
      Martin Flöser authored
      Test more combinations of other effects together with sliding popups.
      The problem does not only exist for scale in but for pretty much any
      effect that the ordering in which the effects get loaded makes the test
      pass or fail.
      
      Some effects require OpenGL, as build.kde.org does not support OpenGL
      compositing (yet), the tests only do the OpenGL cases if an OpenGL
      compositor could be created.
      
      CCBUG: 336866
      b84fd503
  19. 30 Oct, 2016 2 commits