Skip to content

GitLab

Switch branch/tag
  1. 16 Feb, 2020 1 commit
  3. 14 Feb, 2020 1 commit
  5. 13 Feb, 2020 1 commit
  7. 12 Feb, 2020 1 commit
    • David Edmundson's avatar
      Return early if close button accepts input event · 3dbfa6a3
      David Edmundson authored 
      Summary:
Otherwise we close the effect whenever the close is pressed which is a
behavioural change.

That in turn leads to bigger bugs

BUG: 415155

Test Plan:
Ran effect
Clicked on the "Whitespace" of the dash
Clicked on the close

Now matches desktopgrid code

Reviewers: #kwin, zzag, ngraham

Reviewed By: #kwin, zzag, ngraham

Subscribers: ngraham, zzag, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D27333
      3dbfa6a3
  9. 11 Feb, 2020 1 commit
  11. 09 Feb, 2020 1 commit
  13. 08 Feb, 2020 1 commit
    • Heiko Becker's avatar
      Require kdecoration >= 5.18.0 · 6d8f3732
      Heiko Becker authored 
      Summary:
To successfully build kwin needs 13e6459a3baeebe6a7b594efd995b88f6dd7524e
in kdecoration. Otherwise it fails with: "previewclient.h:93:11: error:
'QSize KDecoration2::Preview::PreviewClient::size() const' marked
'override', but does not override QSize size() const override;"
So this is not a new requirement but just an update to the build system
to reflect the actual requirements.

Test Plan: Builds fine with the newly required version

Reviewers: #kwin

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D27242
      6d8f3732
  15. 06 Feb, 2020 1 commit
  17. 05 Feb, 2020 1 commit
  19. 03 Feb, 2020 2 commits
    • Vlad Zahorodnii's avatar
      [x11] Fix visual artifacts during interactive resize · 56d5f3a4
      Vlad Zahorodnii authored 
      Summary:
When a window is being interactively resized, its contents may jump. The
reason why that happens is because KWin renders partially resized client
window. Composite extension spec says that a window will get a new pixmap
each time it is resized or mapped. This applies to the frame window, but
not to the client window itself. If the client window is resized,
off-screen storage for the frame window won't be reallocated. Therefore,
KWin may render partially resized client window if the client doesn't
attempt to be in sync with our rendering loop. Currently, the only way
to do that is to use extended frame counters, which are not supported by
KWin.

So, in order to fix visual artifacts during interactive resize, we need
somehow forcefully re-allocate off-screen storage for the frame window.
Unfortunately, Composite extension doesn't provide any request to do
that, so the only option we have is to resize the frame window.

BUG: 415839
FIXED-IN: 5.18.0

Reviewers: #kwin

Subscribers: davidedmundson, ngraham, alexde, fredrik, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D26914
      56d5f3a4
    • Arjen Hiemstra's avatar
      ScreenEdge: Do not use localtime for measuring duration · 9b3d9e58
      Arjen Hiemstra authored 
      Summary:
QDateTime::fromMSecSinceEpoch uses Qt::LocalTime by default. This involves an
expensive localtime conversion. So instead force things to use UTC, as there
is no need for timezone information when tracking durations.

This is especially noticeable on Bedrock Linux, which uses a Fuse mounted
/etc, which is slower than a plain /etc and causes quite some slowdown there.
See https://github.com/bedrocklinux/bedrocklinux-userland/issues/140 for
details.

Test Plan: The screenedge unit test still passes.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: zzag, anthonyfieroni, davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D27114
      9b3d9e58
  21. 31 Jan, 2020 1 commit
  23. 29 Jan, 2020 6 commits
  25. 28 Jan, 2020 6 commits
  27. 27 Jan, 2020 1 commit
  29. 25 Jan, 2020 2 commits
  31. 23 Jan, 2020 3 commits
  33. 21 Jan, 2020 1 commit
    • David Edmundson's avatar
      [kcms/kwindecoration] Fix saving of window decoration plugin · e0df390d
      David Edmundson authored 
      Summary:
In the KCFG autogenerated code we check for HAVE_BREEZE_DECO without
including the relevant file. This always fails, and so we save the
default plugin name/library as org.kde.kwin.aurorae

This doesn't match kwin's concept of the default and so we just fail to
load it.

BUG: 416525

Test Plan:
Reproduced
Saved a config

Reviewers: #kwin, ngraham

Reviewed By: ngraham

Subscribers: ngraham, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D26814
      e0df390d
  35. 19 Jan, 2020 3 commits
  37. 18 Jan, 2020 1 commit
  39. 17 Jan, 2020 1 commit
  41. 16 Jan, 2020 4 commits