1. 15 Apr, 2020 2 commits
    • David Edmundson's avatar
      [wayland] Fix teardown order · 1a359d5e
      David Edmundson authored
      Summary:
      Valgrind flags an error on teardown.
      
      EventQueue has a pointer to ConnectionThread internally
      Registry has a pointer to the EventQueue internally
      
      teardown order needs to be
      
      Registry
      EventQueue
      Connection
      
      registry was explicitly deleted before connectionthread already, we just
      need to put event queue in the right place.
      
      Test Plan: Ran kwin_wayland nested in valgrind
      
      Reviewers: #kwin, cblack, apol
      
      Reviewed By: cblack, apol
      
      Subscribers: zzag, apol, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D28668
      1a359d5e
    • David Edmundson's avatar
      [wayland] avoid potential crash when checking for window inhibitions on desktop change · d0875aa1
      David Edmundson authored
      Summary:
      Xwayland clients are sometimes offset from being visible to having a
      surface applied.
      
      We might also have internal windows which will be AbstractClients
      without a surface.
      
      No idle interface will be set up for non wayland clients, but on a
      desktop change we itterate through all AbstractClients and need to guard
      somewhere.
      
      BUG: 420039
      
      Test Plan: None
      
      Reviewers: #kwin, apol
      
      Reviewed By: apol
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D28858
      d0875aa1
  2. 07 Apr, 2020 1 commit
    • David Edmundson's avatar
      [kcmkwin] Make dialog non blocking · bee3afdd
      David Edmundson authored
      Summary:
      It's invoked from QML.
      
      Nested event loops invoked directly from QML is asking for crashes.
      
      BUG: 419118
      
      Test Plan:
      Opened KCM
      Opened dialog for some settings
      Window was still modal as before
      Settings were saved
      (though they didn't seem to be applied..maybe another bug?)
      
      Reviewers: #kwin, apol
      
      Reviewed By: apol
      
      Subscribers: zzag, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D28293
      bee3afdd
  3. 01 Apr, 2020 1 commit
  4. 31 Mar, 2020 1 commit
  5. 30 Mar, 2020 1 commit
    • Eugene Popov's avatar
      [kcmkwin/kwindesktop] Fix inability to create more than one row on the... · ae022e92
      Eugene Popov authored and Nate Graham's avatar Nate Graham committed
      [kcmkwin/kwindesktop] Fix inability to create more than one row on the "Virtual Desktops" settings page
      
      Summary:
      When a spinbox with the number of rows loses focus, the value of this spinbox (i.e., the count of rows) is always reset to 1. Thus, it's impossible to create more then one row.
      
      To fix this bug, we need to implement `valueFromText` function.
      
      BUG: 419141
      FIXED-IN: 5.18.4
      
      Reviewers: ngraham, zzag, davidedmundson
      
      Reviewed By: ngraham, davidedmundson
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D28378
      ae022e92
  6. 26 Mar, 2020 1 commit
  7. 21 Mar, 2020 1 commit
  8. 19 Mar, 2020 2 commits
  9. 10 Mar, 2020 1 commit
  10. 07 Mar, 2020 1 commit
    • Mikhail Zolotukhin's avatar
      Notify about decorations button order change · 76c3174b
      Mikhail Zolotukhin authored
      Summary:
      This allows GtkConfig daemon to properly sync decorations buttons order for GTK CSD applications.
      
      For 5.18.3
      
      Test Plan:
      1. Launch `kcmshell5 kwindecoration` and any GTK CSD app alongside
      2. Change order of the buttons.
      3. Window button order should be changed in GTK CSD app immediately (if `xsettingsd` is installed).
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27904
      76c3174b
  11. 02 Mar, 2020 1 commit
  12. 25 Feb, 2020 1 commit
  13. 22 Feb, 2020 5 commits
    • Nicolas Fella's avatar
      [kcm/effects] Clip ListView · 8fb839f6
      Nicolas Fella authored
      Summary:
      Otherwise the content overflows the frame when scrolling.
      
      QQC2 scrollview docs say "ScrollView does not automatically clip its contents. If it is not used as a full-screen item, you should consider setting the clip property to true"
      
      Test Plan:
      Before:
      {F8121150}
      
      After:
      {F8121152}
      
      Reviewers: #kwin, #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27558
      8fb839f6
    • Nicolas Fella's avatar
      Revert "[kcm/effects] Clip ListView" · 7159684c
      Nicolas Fella authored
      Bad merge
      
      This reverts commit b7130442.
      7159684c
    • Nicolas Fella's avatar
      [kcm/effects] Clip ListView · b7130442
      Nicolas Fella authored
      Summary:
      Otherwise the content overflows the frame when scrolling.
      
      QQC2 scrollview docs say "ScrollView does not automatically clip its contents. If it is not used as a full-screen item, you should consider setting the clip property to true"
      
      Test Plan:
      Before:
      {F8121150}
      
      After:
      {F8121152}
      
      Reviewers: #kwin, #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27558
      b7130442
    • Nicolas Fella's avatar
      Revert "[kcm/effects] Clip ListView" · cdc5ea19
      Nicolas Fella authored
      Bad merge
      
      This reverts commit 5babf52d.
      cdc5ea19
    • Nicolas Fella's avatar
      [kcm/effects] Clip ListView · 5babf52d
      Nicolas Fella authored
      Summary:
      Otherwise the content overflows the frame when scrolling.
      
      QQC2 scrollview docs say "ScrollView does not automatically clip its contents. If it is not used as a full-screen item, you should consider setting the clip property to true"
      
      Test Plan:
      Before:
      {F8121150}
      
      After:
      {F8121152}
      
      Reviewers: #kwin, #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27558
      5babf52d
  14. 21 Feb, 2020 2 commits
  15. 19 Feb, 2020 1 commit
  16. 18 Feb, 2020 2 commits
  17. 17 Feb, 2020 1 commit
  18. 16 Feb, 2020 1 commit
  19. 14 Feb, 2020 1 commit
  20. 13 Feb, 2020 1 commit
  21. 12 Feb, 2020 1 commit
  22. 11 Feb, 2020 1 commit
  23. 09 Feb, 2020 1 commit
  24. 08 Feb, 2020 1 commit
    • Heiko Becker's avatar
      Require kdecoration >= 5.18.0 · 6d8f3732
      Heiko Becker authored
      Summary:
      To successfully build kwin needs 13e6459a3baeebe6a7b594efd995b88f6dd7524e
      in kdecoration. Otherwise it fails with: "previewclient.h:93:11: error:
      'QSize KDecoration2::Preview::PreviewClient::size() const' marked
      'override', but does not override QSize size() const override;"
      So this is not a new requirement but just an update to the build system
      to reflect the actual requirements.
      
      Test Plan: Builds fine with the newly required version
      
      Reviewers: #kwin
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27242
      6d8f3732
  25. 06 Feb, 2020 1 commit
  26. 05 Feb, 2020 1 commit
  27. 03 Feb, 2020 2 commits
    • Vlad Zahorodnii's avatar
      [x11] Fix visual artifacts during interactive resize · 56d5f3a4
      Vlad Zahorodnii authored
      Summary:
      When a window is being interactively resized, its contents may jump. The
      reason why that happens is because KWin renders partially resized client
      window. Composite extension spec says that a window will get a new pixmap
      each time it is resized or mapped. This applies to the frame window, but
      not to the client window itself. If the client window is resized,
      off-screen storage for the frame window won't be reallocated. Therefore,
      KWin may render partially resized client window if the client doesn't
      attempt to be in sync with our rendering loop. Currently, the only way
      to do that is to use extended frame counters, which are not supported by
      KWin.
      
      So, in order to fix visual artifacts during interactive resize, we need
      somehow forcefully re-allocate off-screen storage for the frame window.
      Unfortunately, Composite extension doesn't provide any request to do
      that, so the only option we have is to resize the frame window.
      
      BUG: 415839
      FIXED-IN: 5.18.0
      
      Reviewers: #kwin
      
      Subscribers: davidedmundson, ngraham, alexde, fredrik, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D26914
      56d5f3a4
    • Arjen Hiemstra's avatar
      ScreenEdge: Do not use localtime for measuring duration · 9b3d9e58
      Arjen Hiemstra authored
      Summary:
      QDateTime::fromMSecSinceEpoch uses Qt::LocalTime by default. This involves an
      expensive localtime conversion. So instead force things to use UTC, as there
      is no need for timezone information when tracking durations.
      
      This is especially noticeable on Bedrock Linux, which uses a Fuse mounted
      /etc, which is slower than a plain /etc and causes quite some slowdown there.
      See https://github.com/bedrocklinux/bedrocklinux-userland/issues/140 for
      details.
      
      Test Plan: The screenedge unit test still passes.
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: zzag, anthonyfieroni, davidedmundson, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27114
      9b3d9e58
  28. 31 Jan, 2020 1 commit
  29. 29 Jan, 2020 3 commits