Skip to content

GitLab

KWin
KWin
Switch branch/tag
  1. 28 Sep, 2018 2 commits
    • Vlad Zahorodnii's avatar
      [effects/showpaint] Use a shortcut to toggle the effect · 1de9648a
      Vlad Zahorodnii authored 
      Summary:
The Show Paint effect is useful when debugging repaint regions issued by
effects. The only headache with it is necessity to enable/disable it.
Consider the following workflow:

* Do some change to an effect;
* Compile KWin (or the effect);
* Go to System Settings and enable the Show Paint effect;
* Test effect, check repaint regions, etc;
* Disable the Show Paint effect;
* Go to the step 1.

This workflow is really exhausting. Also, when testing repaints in a
nested compositor, things become quite messy.

Because purpose of this effect is to debug repaints (and because this
effect is not meant for daily usage), I think that's fine to change
how it's activated.

This patch improves the workflow by changing the way how this effect
gets activated. Instead of enabling/disabling it, one can just use a shortcut
to activate or deactivate the effect.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: broulik, davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D15703
      1de9648a
    • Vlad Zahorodnii's avatar
      [effects] Move the Desktop Cube Animation effect to its own directory · fa6fa279
      Vlad Zahorodnii authored 
      Summary: Just little tidying.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D15725
      fa6fa279
  3. 24 Sep, 2018 3 commits
  5. 23 Sep, 2018 1 commit
  7. 17 Sep, 2018 9 commits
  9. 15 Sep, 2018 2 commits
  11. 14 Sep, 2018 6 commits
  13. 13 Sep, 2018 6 commits
    • Jonathan Riddell's avatar
      Update version number for 5.14.80 · 9ebb7978
      Jonathan Riddell authored 
      GIT_SILENT
      9ebb7978
    • Jonathan Riddell's avatar
      Update version number for 5.13.90 · 84cd9cfc
      Jonathan Riddell authored 
      GIT_SILENT
      84cd9cfc
    • Vlad Zahorodnii's avatar
      [shadow] Rebuild quads after creation of shadow · 213239a0
      Vlad Zahorodnii authored 
      Summary:
If a shadow is installed for already rendered window, the shadow won't
be initially rendered because we don't rebuild window quad cache.

BUG: 398572
FIXED-IN: 5.14.0

Test Plan: Can't reproduce 398572 anymore.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D15475
      213239a0
    • David Edmundson's avatar
      Remove duplicated auto backend resolution · 0a2e51db
      David Edmundson authored 
      Summary:
kwin_wayland now automatically chooses an appropriate backend, such as
DRM, nested wayland or nested X. If nested it will automatically go into
windowed mode regardless of whether --windowed is set and works fine.

Backend choosing logic existed duplicated in older code for kwin_wayland
--windowed, with the subtle unexpected difference that it preferred
running as an X client over running as a wayland cient if both are
present. This simplifies codes and syncs automatic resolution behaviour.

kwin_wayland --windowed with --x11-display  or --wayland-display will
remain the same.

Test Plan:
Ran kwin_wayland with and without --windowed inside another wayland.
Got the same backend chosen
Tested that kwin_wayland (without --windowed) on an X machine worked just fine.

Reviewers: #kwin, mart

Reviewed By: #kwin, mart

Subscribers: mart, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D13658
      0a2e51db
    • David Edmundson's avatar
      Avoid crash with on scripted window teardown with threaded quick render loop · d485dfe7
      David Edmundson authored 
      Summary:
Qt render loops behave quite differently to each other.

KWin scripting as a workaround for another situation cleans
(17553e5a) handles tracking of script
windows by deleting the underlying window handle on hide.

This currently happens before the window gets the hideEvent.

Arguably this is a quirk with Qt, but in the current state:

- QSGThreadedRenderLoop deletes the platform window and cleans up
- We then get the hide() event. This no-ops because there's no window.
   (else branch of     case WM_TryRelease in qsgthreadedrenderloop.cpp)
- We carry on rendering animations despite having no platform
- undefined behaviour

Normally this isn't a problem as typically destruction of the platform window
happens only when a window is being deleted, we're messing with Qt
internals here.

If we make sure the QHideEvent is processed by the render loop first,
things seem fine.

BUG: 397767

Test Plan:
Ran QSG_RENDER_LOOP=threaded
Read output with scenegraph logging rules on

Reviewers: #kwin, broulik

Reviewed By: broulik

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D15025
      d485dfe7
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · e4ff5062
      Script Kiddy authored 
      In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      e4ff5062
  15. 12 Sep, 2018 2 commits
    • Roman Gilg's avatar
      Remove breaking pointer constraints functionality · 6072b0cd
      Roman Gilg authored 
      Summary:
With 26948390, 0bd5eff8 and f0ba436c it is now possible to
unconstrain a pointer by killing the client or deactivating the window, for
example by switching the window via the TabBox.

A user should always be able to do it therefore without needing to explicitly
break the pointer constrain as in the past with the Esc key.

Therefore remove the functionality and also remove the OSD announcing it,
which was often shown at the wrong time.

Test Plan: Manually and auto test adapted.

Reviewers: #kwin, #vdg, hein

Reviewed By: hein

Subscribers: ngraham, hein, kwin

Tags: #kwin

Maniphest Tasks: T8923

Differential Revision: https://phabricator.kde.org/D15234
      6072b0cd
    • Vlad Zahorodnii's avatar
      [effects/trackmouse] Allow to use both modifiers and shortcut · 74994a7f
      Vlad Zahorodnii authored 
      Summary:
The Track Mouse effect can be toggled either by pressing modifier keys
and moving mouse or by pressing a shortcut. It's not possible to use
the latter and then the former without changing config.

But there is one caveat, in order to use shortcut, you have to uncheck
all modifier keys. This seems to be not very intuitive.

In addition to that, the KCM allows to change shortcut even if there is
some checked modifier.

As the title says, this change makes possible to use both modifier keys
and shortcut to activate this effect without changing config.

KCM:
{F6237308, layout=center, size=full}

BUG: 398124
FIXED-IN: 5.14.0

Reviewers: #kwin, #plasma, #vdg, davidedmundson

Reviewed By: #kwin, #plasma, #vdg, davidedmundson

Subscribers: broulik, abetts, ngraham, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D15272
      74994a7f
  17. 11 Sep, 2018 3 commits
    • Vlad Zahorodnii's avatar
      [effects/showpaint] Modernize code · cc1f30b4
      Vlad Zahorodnii authored 
      Summary:
Summary of changes:
* Use QVector to store colors
* Add Q_OBJECT macro
* Port away from QRegion::rects
* Fix coding style
* Use default member initialization
* Use nullptr
* Reserve rects in paintXrender

The behavior of this effect haven't been changed, it still acts as before.

Test Plan: Compiles, and the Show Paint effect is still a psychedelic thing.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D15424
      cc1f30b4
    • Vlad Zahorodnii's avatar
      [effects] Fix type of X-KWin-Video-Url · 113ebe9b
      Vlad Zahorodnii authored 
      Summary:
The desktop file parser supports only QString, QStringList, Int, Double,
and Bool. QUrl is not a supported type for some reason.

Thus, let's use QString for X-KWin-Video-Url.

Reviewers: #kwin, broulik

Reviewed By: broulik

Subscribers: Zren, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D15373
      113ebe9b
    • Roman Gilg's avatar
      Activate clients on drag enter · 1fada994
      Roman Gilg authored 
      Summary:
We currently only raise a client when a drag enters it and not activate it.
This is confusing since afterwards the raised window has not keyboard focus
although visually being in front of the window the drag originated from.

Therefore activate entered windows instead of only raising them.

Test Plan: Manually and autotests still pass.

Reviewers: #kwin, hein

Reviewed By: hein

Subscribers: anthonyfieroni, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D15225
      1fada994
  19. 10 Sep, 2018 2 commits
    • Vlad Zahorodnii's avatar
      [effects/dialogparent] Fix strict mode issues · 03a2a05f
      Vlad Zahorodnii authored 
      Summary:
Modification of undeclared variables is illegal in the strict mode, e.g.

```lang=js
mainWindows = window.mainWindows();
```

is illegal.

Test Plan: The Dialog Parent effect works with both QScriptEngine and QJSEngine.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D15413
      03a2a05f
    • Vlad Zahorodnii's avatar
      [effects/magnifier] Fix 1 px gap between magnified area and frame · 617b4d92
      Vlad Zahorodnii authored 
      Summary:
The x-coordinate of the area's left edge and y-coordinate of the area's
top edge are adjusted by 1px leading to a gap between the frame and
magnified area. Because area has type of QRect, we have to adjust only
coordinates of the right and bottom edge by 1 px.

Because QRectF::right() == QRectF::x() + QRectF::width(), we can use
QRectF, which leads to more cleaner code because we don't need to do 1px
adjustments.

Test Plan:
Before:
{F6235388, layout=center, size=full}

After:
{F6235439, layout=center, size=full}

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D15275
      617b4d92
  21. 08 Sep, 2018 1 commit
  23. 07 Sep, 2018 1 commit
  25. 06 Sep, 2018 2 commits