1. 16 Nov, 2020 1 commit
  2. 13 Nov, 2020 1 commit
  3. 07 Oct, 2020 2 commits
  4. 07 Aug, 2020 2 commits
    • Vlad Zahorodnii's avatar
      Prettify license headers · 4ce853e8
      Vlad Zahorodnii authored
      4ce853e8
    • Vlad Zahorodnii's avatar
      Switch to SPDX license markers · 1fb9f6f1
      Vlad Zahorodnii authored
      The main advantage of SPDX license identifiers over the traditional
      license headers is that it's more difficult to overlook inappropriate
      licenses for kwin, for example GPL 3. We also don't have to copy a
      lot of boilerplate text.
      
      In order to create this change, I ran licensedigger -r -c from the
      toplevel source directory.
      1fb9f6f1
  5. 28 May, 2020 1 commit
  6. 14 Jan, 2020 1 commit
  7. 23 Dec, 2019 1 commit
  8. 03 Dec, 2019 1 commit
  9. 06 Jun, 2019 1 commit
    • Roman Gilg's avatar
      [decorations] Let KDecoration plugins recommend a border size per default · d51b8dc0
      Roman Gilg authored
      Summary:
      This is an alternative solution to T8707 and in comparision to D13276 a less
      drastic change to KWin's default behavior.
      
      Instead of changing the border size default for all KDecoration plugins by
      switching the default from border size Normal to None introduce new
      functionality, which allows a KDecoration plugin to recommend a border size in
      its metadata. By default KWin listens for these recommendations and sets the
      border size accordingly.
      
      If there is no metadata recommending a border size, KWin falls back to the
      current setting of Normal sized borders.
      
      A user is able to override the recommendations from the KCM, which has been
      extended accordingly.
      
      Test Plan: Manually with adjusted metadata of Breeze.
      
      Reviewers: #kwin, #plasma, #vdg, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: hpereiradacosta, filipf, anemeth, davidedmundson, abetts, graesslin, ngraham, zzag, kwin
      
      Tags: #kwin
      
      Maniphest Tasks: T8707
      
      Differential Revision: https://phabricator.kde.org/D13284
      d51b8dc0
  10. 04 Mar, 2019 1 commit
    • Vlad Zahorodnii's avatar
      Resurrect show tooltips option · 82b3e2a6
      Vlad Zahorodnii authored
      Summary:
      In KDE 4, there was a very handy option to disable decoration tooltips.
      Decoration tooltips were lost in transition to KDE Plasma 5, and so
      the option.
      
      Given that decoration tooltips were brought back to KDE Plasma 5, "Show
      decoration button tooltips" option can be still useful for people(like me)
      who may wish to disable them because of personal preference.
      
      Reviewers: #kwin, broulik, mart
      
      Reviewed By: #kwin, mart
      
      Subscribers: ngraham, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D19152
      82b3e2a6
  11. 14 Feb, 2019 1 commit
  12. 12 Feb, 2019 1 commit
    • Valerio Pilo's avatar
      [kcmkwin/kwindecoration] Fix Get Hot New Stuff · 31dcf51c
      Valerio Pilo authored
      Summary:
      Found better categories for GHNS v3: looks like only Aurorae is supported?
      
      Also refresh the themes when you close the GHNS window, in case something was downloaded.
      
      Test Plan: Open GHNS, download new theme, close GHNS -> new theme visible
      
      Reviewers: leinir, graesslin, #kwin, davidedmundson
      
      Reviewed By: leinir, #kwin, davidedmundson
      
      Subscribers: ngraham, cfeck, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D18935
      31dcf51c
  13. 10 Feb, 2019 1 commit
    • Valerio Pilo's avatar
      [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule · 8350c0f2
      Valerio Pilo authored
      Summary:
      * Wrote new KCM based on KQuickAddons::ConfigModule.
      * Remade QMLs for Buttons and Themes tabs.
      * Updated bridge model code for new plugin lookup API (fixes warnings).
      * Fixed decoration shadow changing messing with the previews sizes.
      * Fixed button drag and drop issues (see D18104).
      * Fixed default settings button behavior and detection of settings changes.
      * Updated Get Hot New Stuff.
      * Removed apply button in previewbridge.cpp: After applying changes, a theme's KCModule is invalidated.
      
      BUG: 389431
      BUG: 350122
      BUG: 346222
      BUG: 342816
      BUG: 397595
      
      {F6574963} | {F6574962} | {F6574961} | {F6574960}
      
      Test Plan:
      * Verified saving and loading for every setting
      * Checked shadows of Breeze and Oxygen
      * Tested all possible drag&drop operations on both sides of the fake titlebar
      * Changed color schemes (with `kcmshell5 colors`) while showing the Themes tab to see if all previews update correctly their palettes
      * Tested on a fresh Neon-developer account, via kcmshell and systemsettings
      
      Reviewers: #vdg, abetts, ngraham, #kwin, davidedmundson
      
      Reviewed By: #vdg, #kwin, davidedmundson
      
      Subscribers: zzag, GB_2, ngraham, broulik, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D18458
      8350c0f2
  14. 10 Jan, 2019 1 commit
    • David Edmundson's avatar
      [kcmkwin/kwindecoration] Fix save of theme name · 14b827da
      David Edmundson authored
      Summary:
      If a user saves a decoration that has a plugin but no theme we currently
      delete the entry saving just the plugin/library.
      
      This is an issue as on load we call:
      
          const QString plugin = config.readEntry("library", s_defaultPlugin);
          const QString theme = config.readEntry("theme", s_defaultTheme);
      
      That would give us a non-default library with the default theme name,
      which would be invalid.
      
      If compiled with Breeze s_defaultTheme is blank so this ends up being
      effectively the same thing. In the normal case it will neither break
      nor fix anything.
      
      Test Plan:
      None.
      Just happened to see it when doing a code review.
      
      Reviewers: #kwin, vpilo
      
      Reviewed By: vpilo
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D18146
      14b827da
  15. 08 Jan, 2019 1 commit
    • Valerio Pilo's avatar
      [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab · e6c06801
      Valerio Pilo authored
      Summary:
      BUG: 346222
      BUG: 399992
      BUG: 356076
      FIXED-IN: 5.15
      
      The QML changes make the tab look and feel less awful:
      * make the fake window borders stand out less
      * add margins to drop area to make it easier to drop buttons on the title bar (fixing 346222)
      * change cursor to a non-pointing one [1]
      
      [1] Drag&drop: When dropping, we receive the position of the button being dropped,
      not of the cursor. The two can be far (when starting drag by moving the cursor fast):
      which makes the whole experience very confusing, as the user means to drop at cursor location.
      
      Test Plan: Tested drag/drop: same (messy) behavior as before, but can now drop more loosely around titlebar items
      
      Reviewers: #vdg, #kwin, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: davidedmundson, ngraham, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D17982
      e6c06801
  16. 03 Jan, 2019 1 commit
  17. 02 Jul, 2018 1 commit
  18. 13 Apr, 2017 2 commits
    • David Edmundson's avatar
      Sort the themes in decoration KCM · f5a43877
      David Edmundson authored
      Summary:
      Even though we're using a QSortFilterProxy model, by default it doesn't
      actually sort anything until instructed to.
      
      This patch turns sorting on.
      
      Test Plan:
      Opened the KCM
      Looked at it
      
      Reviewers: #plasma, mart
      
      Reviewed By: mart
      
      Subscribers: plasma-devel, kwin, #kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D5407
      f5a43877
    • David Edmundson's avatar
      Fix KWin decoration KCM showing correct index at startup · 3709996f
      David Edmundson authored
      Summary:
      The KCM has a context property of the currently set theme index. This is
      set before the decorations model is populated, so it is currently always
      -1.
      
      This model is populated after the constructor but before
      KCModule::load().
      
      KCModule::load is called from KCModule::showEvent so before
      QQuickGridView will start doing anything with delegates.
      
      This fixes the problem simply and also avoid parsing the config file
      multiple times.
      
      This bug was introduced in 5.9.4:
      
      Someone made a (tested) change to make sure the view scrolled to the
      right place on startup.
      I then made a (tested) commit fixing the crash on exit
      The author then updated his patch to my changes, but now in a way that
      didn't work.
      
      Test Plan:
      Opened system settings module with a million decorations.
      The correct entry was visible and highlighted.
      
      Reviewers: #plasma, graesslin
      
      Reviewed By: #plasma, graesslin
      
      Subscribers: plasma-devel, kwin, #kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D5401
      3709996f
  19. 24 Feb, 2017 3 commits
    • Marco Martin's avatar
      move the view at the correct index at startup · 6673f713
      Marco Martin authored
      Summary:
      using the same trick as elsewhere, set the currentIndex
      and move the view to currentIndex right at startup
      the only way to be sure is onContentHeightChanged
      as there are no signals for when "the view has been
      populated and settled up"
      
      Test Plan:
      the view is at the right state since the first frame shown,
      no more jumping around effect
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel, kwin, #kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D4703
      6673f713
    • Marco Martin's avatar
      move the view at the correct index at startup · 892f398b
      Marco Martin authored
      Summary:
      using the same trick as elsewhere, set the currentIndex
      and move the view to currentIndex right at startup
      the only way to be sure is onContentHeightChanged
      as there are no signals for when "the view has been
      populated and settled up"
      
      Test Plan:
      the view is at the right state since the first frame shown,
      no more jumping around effect
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel, kwin, #kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D4703
      892f398b
    • Marco Martin's avatar
      move the view at the correct index at startup · 299d2323
      Marco Martin authored
      Summary:
      using the same trick as elsewhere, set the currentIndex
      and move the view to currentIndex right at startup
      the only way to be sure is onContentHeightChanged
      as there are no signals for when "the view has been
      populated and settled up"
      
      Test Plan:
      the view is at the right state since the first frame shown,
      no more jumping around effect
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel, kwin, #kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D4703
      299d2323
  20. 10 Feb, 2017 2 commits
    • David Edmundson's avatar
      Avoid a crash on Kwin decoration KCM teardown · 70d2fb23
      David Edmundson authored
      Summary:
      As described in https://bugreports.qt.io/browse/QTBUG-57714  exposing a
      QWidget as a context item to QtQuick can crash. Especially as the
      engine's context property gets deleted whilst deleting the parent item.
      
      This patch reworks the code so that the models are exposed to QML
      directly rather than going through a QWidget.
      
      CCBUG: 373628
      
      Test Plan:
      Pressing back whilst in the decoration KCM used to crash every time, now it doesn't.
      I still have the buttons.
      
      Reviewers: #plasma, graesslin
      
      Reviewed By: #plasma, graesslin
      
      Subscribers: graesslin, cfeck, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4533
      70d2fb23
    • David Edmundson's avatar
      Avoid a crash on Kwin decoration KCM teardown · 29179f11
      David Edmundson authored
      Summary:
      As described in https://bugreports.qt.io/browse/QTBUG-57714  exposing a
      QWidget as a context item to QtQuick can crash. Especially as the
      engine's context property gets deleted whilst deleting the parent item.
      
      This patch reworks the code so that the models are exposed to QML
      directly rather than going through a QWidget.
      
      CCBUG: 373628
      
      Test Plan:
      Pressing back whilst in the decoration KCM used to crash every time, now it doesn't.
      I still have the buttons.
      
      Reviewers: #plasma, graesslin
      
      Reviewed By: #plasma, graesslin
      
      Subscribers: graesslin, cfeck, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4533
      29179f11
  21. 12 Apr, 2016 1 commit
  22. 05 Oct, 2015 1 commit
    • Thomas Lübking's avatar
      overhaul of deco kcm · ed2314df
      Thomas Lübking authored
      - tab theme and button items
      - move menubutton close hint below checkbox (moved on top)
      - use proper background palette on palette updates
      
      REVIEW: 125393
      ed2314df
  23. 28 Jan, 2015 1 commit
    • Marco Martin's avatar
      use xembed for the qml view of window decorations modul · 63885cc5
      Marco Martin authored
      the only way to ensure the view won't randomly become black
      (probably QQuickwidget won't be fixed in qt anytime soon or
      ever in 5.x lifetime due to how architecturally is)
      
      basically systemsettings has no control of what gets loaded in,
      if one other kcm will call winId(), this one will break.
      
      BUG:341971
      63885cc5
  24. 26 Jan, 2015 1 commit
  25. 24 Jan, 2015 2 commits
  26. 22 Jan, 2015 1 commit
    • Thomas Lübking's avatar
      Overhaul of deco kcm · ce2fa727
      Thomas Lübking authored
      - align with system palette
      - base color for buttons and preview individually
        to create a visual gap (make them more standalone)
      - downsized button config buttons to match up w/ preview
        appearance (and because it was simply to huge for a desktop thing)
      - upsized preview to preferably show two elements at once
        (current + 2*1/2context)
      - made the titlebar a visible visual element
      - label the titlebar "Titlebar"
      - move the (altered) hint to the drag-from area
      - hint draggability with a pointing hand cursor
      - less hardcoded values
      - brief animations on button adding/removing
      
      BUG: 337544
      REVIEW: 122064
      ce2fa727
  27. 09 Dec, 2014 1 commit
  28. 05 Dec, 2014 1 commit
    • Martin Flöser's avatar
      [kcmkwin/deco] Bring back KNewStuff support · 2034e7e8
      Martin Flöser authored
      KNewStuff is no longer hard-coded to Aurorae themes. Instead the
      availability of KNewStuff is derived from the available plugin
      metadata. If the section org.kde.kdecoration2 contains a key
      "KNewStuff" it's value is interpreted as the knsrc config file name.
      If there is at least one plugin with such a key KNS gets enabled.
      
      If there are multiple plugins providing KNS support the download
      button is turned into a button with a connected menu and each menu
      entry points to one of the available resources. Of course this is
      not optimal, but KNS doesn't allow the combining of multiple config
      files.
      2034e7e8
  29. 04 Dec, 2014 4 commits
  30. 31 Oct, 2014 1 commit
    • Martin Flöser's avatar
      [kcmkwin/kwindecoration] Import a new decoration configuration module · 8dd0a816
      Martin Flöser authored
      Following features are supported:
      * finds all plugins
      ** finds all themes for a theme-engine plugin
      * renders previews for the plugin/themes
      * loads currently used plugin/theme
      * saves selected plugin/theme
      * triggers config reload in KWin
      
      Following features are currently not supported:
      * Search
      * Plugin configuration
      * GHNS
      * Button configuration
      8dd0a816