1. 14 Mar, 2018 1 commit
    • Vlad Zahorodnii's avatar
      don't override m_canUseMipmaps · 4a3104bf
      Vlad Zahorodnii authored
      Summary:
      Seems like this override/assignment was introduced in edb0751c.
      
      Following that commit, 450be6a3 introduced `levels` param
      so we could tell whether mipmaps are going to be used. And it seems like this assignment
      hadn't been deleted in that commit.
      
      Reviewers: #kwin, fredrik
      
      Reviewed By: fredrik
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D11301
      4a3104bf
  2. 11 Mar, 2018 1 commit
    • Martin Flöser's avatar
      Better map ShellClient to resource name and class · ab18007d
      Martin Flöser authored
      Summary:
      The window rules dialog did not properly detect the wayland windows. So
      I investigated what ICCCM writes about the WM_CLASS property (which is
      the base for window rule matching) and checked how ShellClient maps to
      it. Basically name and class was swapped and the reason for the
      detection not working properly. As we don't have a proper name, the code
      is adjusted to generate a name by using the executable name. This is
      also what WM_CLASS should be filled with, according to ICCCM.
      
      Test Plan: Rules dialog detects the name and class correctly
      
      Reviewers: #kwin, #plasma
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D11023
      ab18007d
  3. 10 Mar, 2018 1 commit
  4. 06 Mar, 2018 2 commits
  5. 05 Mar, 2018 5 commits
    • Fabian Vogt's avatar
      Merge branch 'Plasma/5.12' · 9e32829f
      Fabian Vogt authored
      9e32829f
    • Fabian Vogt's avatar
      Convert EffectView to a QQuickWidget · 68a2ec5d
      Fabian Vogt authored
      Summary:
      The Qt Wayland support for subsurfaces is broken in many ways, producing
      graphical glitches and crashes:
      https://bugreports.qt.io/browse/QTBUG-54888 for instance.
      
      Using a QQuickWidget instead of a QQuickView avoids those issues, with
      the additional benefit of a nicer API.
      
      Test Plan:
      Opened the KCM with kcmshell and systemsettings, no subsurfaces used
      anymore.
      
      Reviewers: #plasma, graesslin, davidedmundson
      
      Reviewed By: #plasma, graesslin, davidedmundson
      
      Subscribers: kwin, plasma-devel, #kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D11066
      68a2ec5d
    • Martin Flöser's avatar
      Merge branch 'Plasma/5.12' · e71460b6
      Martin Flöser authored
      e71460b6
    • Martin Flöser's avatar
      Sanity check WindowQuad before trying to create a grid out of it · e1afef3d
      Martin Flöser authored
      Summary:
      When one uses:
       * breeze as of 5.12
       * wobbly windows
       * shaded window
       * a distribution building with assert enabled
      
      and starts to move a shaded window, KWin asserts. The root cause for
      this is that WindowQuad::makeSubQuad has an assert for y1 being smaller
      than y2. With the combination listed above this is not guaranteed. For
      the left shadow quad the y1 and y2 are identical and thus trying to
      split it, results in the assert condition.
      
      The problem of the shadow quad having an invalid size might be addressed
      as well with D10811. Due to that the generation of the quads is not
      touched. Instead a sanity check is introduced to not try to split
      already invalid sized quads.
      
      BUG: 390953
      FIXED-IN: 5.12.3
      
      Test Plan: Added unit test hit the assert, now doesn't hit it any more
      
      Reviewers: #kwin, #plasma
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D11015
      e1afef3d
    • Fabian Vogt's avatar
      Fix typo in config group name · b1bffa44
      Fabian Vogt authored
      Summary: Quickly fix it before anyone relies on this typo.
      
      Test Plan: None. Yes, really untested.
      
      Reviewers: #plasma, graesslin, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: kwin, plasma-devel, #kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D11047
      b1bffa44
  6. 04 Mar, 2018 6 commits
  7. 03 Mar, 2018 1 commit
  8. 01 Mar, 2018 1 commit
  9. 28 Feb, 2018 1 commit
  10. 27 Feb, 2018 2 commits
  11. 25 Feb, 2018 6 commits
    • Martin Flöser's avatar
      Add a method to dbus interface to query information about a window · 1d71292e
      Martin Flöser authored
      Summary:
      This call is added for the window rules kcm which has a detect
      functionality. As that detect functionality cannot query any Wayland
      windows we need to have some functionality in KWin core. Furthermore
      this allows to simplify the code in the kcm as all the custom X11
      interaction can be removed. KWin internally has the functionality to
      find a window at a given position.
      
      From a security perspective adding this dbus method is fine as the user
      stays in control of the functionality. It requires active click to
      select a window.
      
      The new dbus call is already used in the rules kcm replacing the
      X11 based detect functionality. That a detect is now able to get
      information for both X11 and Wayland windows. So far only X11 windows
      on X11 were supported. So this fills an important gap in the Wayland
      offerings. It should now be possible to create rules for Wayland
      windows (though may not be fully functional).
      
      Test Plan: Run the kwin_rules_dialog and it detected the window correctly
      
      Reviewers: #kwin, #plasma
      
      Subscribers: plasma-devel, kwin
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10490
      1d71292e
    • Martin Flöser's avatar
      Merge branch 'Plasma/5.12' · 119c6483
      Martin Flöser authored
      119c6483
    • Martin Flöser's avatar
      Send hoverLeave or hoverMotion after touch up on decoration · 911176a8
      Martin Flöser authored
      Summary:
      On touch down a first hover motion is sent to the decoration. Thus e.g. a
      button enters the hovered state. On touch release so far the decoration
      did not get a leave event resulting in the button still being hovered.
      
      This change ensures the leave event is sent or if the pointer is also on
      the decoration a motion to the pointer position is sent.
      
      BUG: 386231
      FIXED-IN: 5.12.3
      
      Test Plan:
      New test case and manual testing to verify that the maximize
      button is no longer hovered after touch down/up on it
      
      Reviewers: #kwin, #plasma
      
      Subscribers: plasma-devel, kwin
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10308
      911176a8
    • Martin Flöser's avatar
      Init the icon in ShellClient::init · 5795fc8c
      Martin Flöser authored
      Summary:
      If the window never provides the appId, we would not get an icon for
      the window. This happens for example for KWin's internal windows which
      don't set the app id as KWin also doesn't have a desktop file. With this
      change the DebugConsole has a window icon in the decoration.
      
      Test Plan: Extended tests and manual verification of DebugConsole
      
      Reviewers: #kwin, #plasma
      
      Subscribers: plasma-devel, kwin
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10294
      5795fc8c
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 4c6e7b92
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      4c6e7b92
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 770332db
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      770332db
  12. 22 Feb, 2018 2 commits
  13. 21 Feb, 2018 3 commits
    • Martin Flöser's avatar
      Merge branch 'Plasma/5.12' · a0c91c6e
      Martin Flöser authored
      a0c91c6e
    • Martin Flöser's avatar
      Disable window rule configuration for Wayland · 7bf4a942
      Martin Flöser authored
      Summary:
      The window rule detection is too bound to X11 for it to work for
      Wayland windows. In fact it results in the config module just crashing.
      Thus it's better to just disable the items in the menu. As it's only for
      X11 windows we can also enforce platform xcb for the rules dialog.
      
      Test Plan: Menu disabled on Wayland window, menu enabled on Xwayland window
      
      Reviewers: #kwin, #plasma
      
      Subscribers: plasma-devel, kwin
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10594
      7bf4a942
    • Martin Flöser's avatar
      Properly handle move during touch events · 338c7362
      Martin Flöser authored
      Summary:
      When a window was being moved the touch handling performed the wrong
      interaction. Due to that it was possible to move the window, but KWin
      did not enter the correct code paths, thus quick tiling was for example
      not functional.
      
      BUG: 390113
      FIXED-IN: 5.12.3
      
      Test Plan: New test case added and manual test in nested KWin
      
      Reviewers: #kwin, #plasma
      
      Subscribers: plasma-devel, kwin
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10431
      338c7362
  14. 20 Feb, 2018 1 commit
  15. 19 Feb, 2018 1 commit
  16. 16 Feb, 2018 1 commit
    • Vlad Zahorodnii's avatar
      [effects] replace old slide effect with a new one · ddd406df
      Vlad Zahorodnii authored
      Summary:
      The new slide effect tries to separate each virtual desktop
      as much as possible. This separation makes the new slide
      effect more intuitive than the old one.
      
      Test Plan:
      * switch between virtual desktops
      * or, move a window to another virtual desktop
      
      Reviewers: #vdg, #kwin, #plasma, graesslin, ngraham
      
      Reviewed By: #kwin, #plasma, graesslin
      
      Subscribers: mart, graesslin, abetts, ngraham, plasma-devel, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D9638
      ddd406df
  17. 15 Feb, 2018 1 commit
  18. 14 Feb, 2018 1 commit
  19. 13 Feb, 2018 2 commits
    • Alex Nemeth's avatar
      Added noise blur effect · cc0325af
      Alex Nemeth authored and Fredrik Höglund's avatar Fredrik Höglund committed
      Summary:
      Added the option to turn on noise behind the blurred area.
      The lowest strength value disables it completely, so it is optional and is disabled by default.
      
      Test Plan:
      Edit: this new screenshot shows the updated noise generation.
      Edit2: separated the screenshots so you can flick through them to clearly see the differences
      
      {F5694024}
      
      {F5694031}
      
      {F5694025}
      
      {F5694028}
      
      Reviewers: #kwin, #vdg, fredrik
      
      Reviewed By: #vdg, fredrik
      
      Subscribers: davidedmundson, matheusm, romangg, ivan, zzag, ngraham, kwin, #kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D10281
      cc0325af
    • Jonathan Esk-Riddell's avatar
      Update version number for 5.12.1 · 28c79bd4
      Jonathan Esk-Riddell authored
      GIT_SILENT
      28c79bd4
  20. 12 Feb, 2018 1 commit