- 03 Feb, 2020 2 commits
-
-
Vlad Zahorodnii authored
Summary: When a window is being interactively resized, its contents may jump. The reason why that happens is because KWin renders partially resized client window. Composite extension spec says that a window will get a new pixmap each time it is resized or mapped. This applies to the frame window, but not to the client window itself. If the client window is resized, off-screen storage for the frame window won't be reallocated. Therefore, KWin may render partially resized client window if the client doesn't attempt to be in sync with our rendering loop. Currently, the only way to do that is to use extended frame counters, which are not supported by KWin. So, in order to fix visual artifacts during interactive resize, we need somehow forcefully re-allocate off-screen storage for the frame window. Unfortunately, Composite extension doesn't provide any request to do that, so the only option we have is to resize the frame window. BUG: 415839 FIXED-IN: 5.18.0 Reviewers: #kwin Subscribers: davidedmundson, ngraham, alexde, fredrik, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26914
-
Arjen Hiemstra authored
Summary: QDateTime::fromMSecSinceEpoch uses Qt::LocalTime by default. This involves an expensive localtime conversion. So instead force things to use UTC, as there is no need for timezone information when tracking durations. This is especially noticeable on Bedrock Linux, which uses a Fuse mounted /etc, which is slower than a plain /etc and causes quite some slowdown there. See https://github.com/bedrocklinux/bedrocklinux-userland/issues/140 for details. Test Plan: The screenedge unit test still passes. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: zzag, anthonyfieroni, davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27114
-
- 31 Jan, 2020 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 29 Jan, 2020 6 commits
-
-
Vlad Zahorodnii authored
Summary: BUG: 416093 FIXED-IN: 5.18.0 Test Plan: Only compile-time check. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26988
-
Vlad Zahorodnii authored
Fix minor coding style issues and drop redundant qAsConst (const containers don't detach).
-
Vlad Zahorodnii authored
Summary: It's identical to Toplevel::rect(). Test Plan: Compiles. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26971
-
Vlad Zahorodnii authored
Summary: m_xdgShellSurface represents an xdg-toplevel, not an xdg-surface. Test Plan: Compiles. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26975
-
Vlad Zahorodnii authored
Summary: We duplicate ping code in a few places. This change introduces a dedicated method for sending ping events to an xdg-toplevel. In long term, it can be used for sending "test" ping messages at random interval. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26974
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 28 Jan, 2020 6 commits
-
-
Vlad Zahorodnii authored
-
Vlad Zahorodnii authored
One step closer to the bright future where one can disable X11 support at build time.
-
Vlad Zahorodnii authored
Getter methods should not have "get" prefix.
-
Vlad Zahorodnii authored
Summary: If a client has been resized, it doesn't necessarily mean that the decoration theme will schedule full repaint of the window frame. In OpenGL and Xrender scene, we have a little hack that forces a full repaint of window borders. However, we don't have one in QPainter scene which causes all sorts of weird looking artifacts when resizing a server-side decorated client. We could add yet another hack in the QPainter scene, but a better approach to tackle this problem would be to make DecoratedClient schedule a full repaint of the decoration. It makes code in scene plugins more straightforward and prevents us from repeating the same mistake again. Test Plan: No longer able to see invisible decoration borders when using QPainter render backend. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26927
-
Vlad Zahorodnii authored
Summary: See D26937 Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26939
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 27 Jan, 2020 1 commit
-
-
Fabian Vogt authored
Summary: If the listed interpreter does not exist, kconf_update skips the update. The update script uses python3, so declare that properly. Test Plan: Saw the error by accident, it's gone now. Reviewers: #plasma, zzag Reviewed By: #plasma, zzag Subscribers: kwin, plasma-devel Tags: #kwin Differential Revision: https://phabricator.kde.org/D26942
-
- 25 Jan, 2020 2 commits
-
-
Vlad Zahorodnii authored
Summary: QProcess::error() has been deprecated since Qt 5.6. It is highly advised to use QProcess::errorOccurred() instead. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26922
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 23 Jan, 2020 3 commits
-
-
Vlad Zahorodnii authored
Summary: According to the xdg-shell spec, configure events carry the maximum window geometry size. If a client wants to enforce aspect ratio, it may attach a buffer with smaller size. We need to account for that when determining frame geometry in the commit handler. I'm targeting 5.18 branch. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26886
-
Vlad Zahorodnii authored
Summary: Currently, the input geometry for client-side decorated clients matches the frame geometry, which makes it impossible for a user to resize such clients by just dragging invisible area near window borders. BUG: 416346 Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: cblack, ngraham, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26716
-
Vlad Zahorodnii authored
Summary: The frame geometry stays still when only shape changes. BUG: 416531 Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26809
-
- 21 Jan, 2020 1 commit
-
-
David Edmundson authored
Summary: In the KCFG autogenerated code we check for HAVE_BREEZE_DECO without including the relevant file. This always fails, and so we save the default plugin name/library as org.kde.kwin.aurorae This doesn't match kwin's concept of the default and so we just fail to load it. BUG: 416525 Test Plan: Reproduced Saved a config Reviewers: #kwin, ngraham Reviewed By: ngraham Subscribers: ngraham, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26814
-
- 19 Jan, 2020 3 commits
-
-
Vlad Zahorodnii authored
-
Vlad Zahorodnii authored
Summary: The next release of Plasma depends on KF 5.66. Reviewers: #kwin, dfaure Reviewed By: dfaure Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26694
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 18 Jan, 2020 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 17 Jan, 2020 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 16 Jan, 2020 13 commits
-
-
Vlad Zahorodnii authored
Summary: When the user changes "Block compositing" rule, apply it immediately. BUG: 415903 Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26708
-
Jonathan Esk-Riddell authored
GIT_SILENT
-
Jonathan Esk-Riddell authored
-
Vlad Zahorodnii authored
Test Plan: Compiles. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26644
-
Roman Gilg authored
This reverts commit ad892ce3. See: https://mail.kde.org/pipermail/kwin/2020-January/002999.html
-
Roman Gilg authored
This reverts commit 285adc19. See: https://mail.kde.org/pipermail/kwin/2020-January/002999.html
-
Roman Gilg authored
This reverts commit b3a19f9e. See: https://mail.kde.org/pipermail/kwin/2020-January/002999.html
-
Roman Gilg authored
This reverts commit 8d137290. See: https://mail.kde.org/pipermail/kwin/2020-January/002999.html
-
Roman Gilg authored
This reverts commit a55dee3b. See: https://mail.kde.org/pipermail/kwin/2020-January/002999.html
-
Roman Gilg authored
This reverts commit 00bf75d0. See: https://mail.kde.org/pipermail/kwin/2020-January/002999.html
-
Roman Gilg authored
This reverts commit e7da4d65. See: https://mail.kde.org/pipermail/kwin/2020-January/002999.html
-
Roman Gilg authored
This reverts commit ba2c0324. See: https://mail.kde.org/pipermail/kwin/2020-January/002999.html
-
Roman Gilg authored
This reverts commit be01ba0a. See: https://mail.kde.org/pipermail/kwin/2020-January/002999.html
-