1. 25 Jan, 2017 1 commit
    • Martin Flöser's avatar
      Support modifier-only-shortcuts when capslock is on · 5a87fa3f
      Martin Flöser authored
      Summary:
      So far we didn't trigger modifier-only-shortcuts when capslock was
      enabled. In fact we even ensured that the shortcuts did not trigger.
      This seems not to be what our users expect. Meta should still trigger
      if capslock is on.
      
      This change modifies the logic to determine which modifier is currently
      pressed by using the modifiersRelevantForGlobalShortcuts. The difference
      to the "normal" modifiers is that this excludes capslock from modifiers
      and excludes consumed modifiers. The latter is not really relevant as
      modifier-only-shortcuts do not trigger if multiple keys are pressed,
      which is required to have a modifier consumed.
      
      BUG: 375355
      FIXED-IN: 5.8.6
      
      Test Plan: Only with adjusted autotest
      
      Reviewers: #kwin, #plasma
      
      Subscribers: plasma-devel, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D4241
      5a87fa3f
  2. 22 Jan, 2017 1 commit
  3. 06 Oct, 2016 2 commits
  4. 19 Aug, 2016 1 commit
    • Martin Flöser's avatar
      Ensure modifier locks and latches don't trigger the mod only shortcut · ec98f498
      Martin Flöser authored
      Summary:
      If caps lock is on the shift key should not trigger. Similar pressing
      caps lock should neither on activation press nor on deactivation press
      trigger the shortcut. Related to that are latched modifiers aka sticky
      modifiers: if the modifier is still on after releasing the key the
      shortcut should not trigger. We must assume the user wanted to use the
      modifier to activate the modifier, not to activate the shortcut.
      
      This change ensures that we don't track for modifier only shortcuts if
      a modifier is active before press or after release.
      
      The added test case demonstrates for caps lock, latched modifiers is
      currently still untested. (Needs a way to mock it).
      
      Test Plan: See test case for caps lock.
      
      Reviewers: #kwin, #plasma
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D2467
      ec98f498
  5. 18 Aug, 2016 1 commit
    • Martin Flöser's avatar
      Introduce env variable KWIN_XKB_DEFAULT_KEYMAP to force default layout creation · ea22b8f1
      Martin Flöser authored
      Summary:
      The Xkb class loads keyboard layouts from the users configuration. This
      makes tests fail locally if the user has a layout which behaves
      differently to the one the test expects. E.g. on a German layout the
      right alt key is different to the one of US layout.
      
      In order to have a more stable test base the env variable
      KWIN_XKB_DEFAULT_KEYMAP forces the loading of the default keymap, thus
      tests have a common layout set.
      
      Reviewers: #kwin, #plasma_on_wayland
      
      Subscribers: plasma-devel, kwin
      
      Tags: #plasma_on_wayland, #kwin
      
      Differential Revision: https://phabricator.kde.org/D2466
      ea22b8f1
  6. 16 Aug, 2016 2 commits
  7. 15 Aug, 2016 1 commit
  8. 13 Aug, 2016 3 commits