1. 19 Sep, 2019 4 commits
    • Vlad Zahorodnii's avatar
      Use nullptr everywhere · 62a7db70
      Vlad Zahorodnii authored
      Summary:
      Because KWin is a very old project, we use three kinds of null pointer
      literals: 0, NULL, and nullptr. Since C++11, it's recommended to use
      nullptr keyword.
      
      This change converts all usages of 0 and NULL literal to nullptr. Even
      though it breaks git history, we need to do it in order to have consistent
      code as well to ease code reviews (it's very tempting for some people to
      add unrelated changes to their patches, e.g. converting NULL to nullptr).
      
      Test Plan: Compiles.
      
      Reviewers: #kwin, davidedmundson, romangg
      
      Reviewed By: #kwin, davidedmundson, romangg
      
      Subscribers: romangg, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D23618
      62a7db70
    • Bhushan Shah's avatar
      [platforms/drm] introduce env var to select GPU · 6b610927
      Bhushan Shah authored
      Summary:
      In some environemnts it is possible that udev detection of primary GPU
      fails and it picks the first available card (normally card0). But it is
      not desired, and it would be required to use different card (card1).
      
      Introduce environment variable, which when used, will make it possible
      to use different card node then one selected by udev.
      
      You can use it like KWIN_DRM_DEVICE_NODE=/dev/dri/card1 kwin_wayland
      
      Test Plan: Tested on the device where card0 was not usable for kms, but card1
      
      Reviewers: #kwin
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D24051
      6b610927
    • Jonathan Riddell's avatar
      Update version number for 5.16.90 · 48691c40
      Jonathan Riddell authored
      GIT_SILENT
      48691c40
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 2806d5f6
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      2806d5f6
  2. 18 Sep, 2019 6 commits
  3. 17 Sep, 2019 3 commits
  4. 16 Sep, 2019 7 commits
  5. 15 Sep, 2019 2 commits
    • Björn Feber's avatar
      Make Desktop Effects KCM desktop file consistent · fba443c4
      Björn Feber authored
      Summary: {F7358009}
      
      Test Plan: Hover over the {nav Desktop Effects} KCM in the system settings sidebar.
      
      Reviewers: #kwin, #plasma, #vdg, zzag
      
      Reviewed By: #kwin, #plasma, zzag
      
      Subscribers: #vdg, #plasma, kwin, #kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D23978
      fba443c4
    • Carl Schwan's avatar
      Fix compile failure window variable doesn't exist · 0757a608
      Carl Schwan authored
      Summary:
      Error was:
      ```
      /home/carl/kdesrc/kde/workspace/kwin/plugins/platforms/x11/windowed/x11windowed_output.cpp: In member function ‘void KWin::X11WindowedOutput::initXInputForWindow()’:
      /home/carl/kdesrc/kde/workspace/kwin/plugins/platforms/x11/windowed/x11windowed_output.cpp:134:14: error: invalid use of non-static member function ‘xcb_window_t KWin::X11WindowedOutput::window() const’
        134 |     Q_UNUSED(window)
            |              ^~~~~~
      In file included from /home/carl/kdesrc/kde/workspace/kwin/plugins/platforms/x11/windowed/x11windowed_output.cpp:20:
      /home/carl/kdesrc/kde/workspace/kwin/plugins/platforms/x11/windowed/x11windowed_output.h:50:18: note: declared here
         50 |     xcb_window_t window() const {
            |
      ```
      
      Reviewers: #kwin, romangg
      
      Reviewed By: #kwin, romangg
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D23957
      0757a608
  6. 14 Sep, 2019 6 commits
  7. 13 Sep, 2019 2 commits
    • Vlad Zahorodnii's avatar
      [colorcorrection] Fix division by zero · ab3d7d52
      Vlad Zahorodnii authored
      Summary:
      m_currentTemp can be equal to targetTemp when resetSlowUpdateTimer is
      called. resetSlowUpdateTimer doesn't handle that case, which results
      in an FP exception being raised:
      
          ==20103==ERROR: AddressSanitizer: FPE on unknown address 0x7f40857d5ca6 (pc 0x7f40857d5ca6 bp 0x7ffccd95c330 sp 0x7ffccd95c220 T0)
              #0 0x7f40857d5ca5 in KWin::ColorCorrect::Manager::resetSlowUpdateTimer() /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/colorcorrection/manager.cpp:417
              #1 0x7f40857d521d in KWin::ColorCorrect::Manager::resetSlowUpdateStartTimer() /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/colorcorrection/manager.cpp:388
              #2 0x7f40857d42d5 in KWin::ColorCorrect::Manager::resetQuickAdjustTimer() /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/colorcorrection/manager.cpp:324
              #3 0x7f40857d3ac1 in KWin::ColorCorrect::Manager::resetAllTimers() /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/colorcorrection/manager.cpp:286
              #4 0x7f40857d0311 in KWin::ColorCorrect::Manager::hardReset() /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/colorcorrection/manager.cpp:152
              #5 0x7f40857d038d in KWin::ColorCorrect::Manager::reparseConfigAndReset() /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/colorcorrection/manager.cpp:159
              #6 0x420e75 in ColorCorrectNightColorTest::testConfigRead() /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/autotests/integration/colorcorrect_nightcolor_test.cpp:126
              #7 0x4326b4 in ColorCorrectNightColorTest::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/build/autotests/integration/testColorCorrectNightColor_waylandonly_autogen/include/colorcorrect_nightcolor_test.moc:98
              #8 0x7f407a80a94a in QMetaMethod::invoke(QObject*, Qt::ConnectionType, QGenericReturnArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) const (/usr/lib64/libQt5Core.so.5+0x29694a)
              #9 0x7f40840a8962  (/usr/lib64/libQt5Test.so.5+0x19962)
              #10 0x7f40840a9352  (/usr/lib64/libQt5Test.so.5+0x1a352)
              #11 0x7f40840a9910  (/usr/lib64/libQt5Test.so.5+0x1a910)
              #12 0x7f40840a9cda in QTest::qRun() (/usr/lib64/libQt5Test.so.5+0x1acda)
              #13 0x7f40840a9edb in QTest::qExec(QObject*, int, char**) (/usr/lib64/libQt5Test.so.5+0x1aedb)
              #14 0x432428 in main /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/autotests/integration/colorcorrect_nightcolor_test.cpp:338
              #15 0x7f407a095bca in __libc_start_main (/lib64/libc.so.6+0x26bca)
              #16 0x413ea9 in _start (/home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/build/bin/testColorCorrectNightColor_waylandonly+0x413ea9)
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D23914
      ab3d7d52
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 4b83556a
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      4b83556a
  8. 12 Sep, 2019 7 commits
  9. 11 Sep, 2019 3 commits