1. 24 Sep, 2019 6 commits
  2. 23 Sep, 2019 12 commits
    • David Edmundson's avatar
      [wayland] Avoid compare to unintialised value in keyboard repeat · 04845b60
      David Edmundson authored
      Summary:
      If we get a key event for which
      
      if (m_xkb->shouldKeyRepeat(key) &&
      waylandServer()->seat()->keyRepeatDelay() != 0) fails
      
      m_key will be unitialised and on release we have a compare against
      unitialised memory.
      
      Won't do any harm, it'll just stop a timer that isn't running, but
      valgrind complains.
      
      0 is the value QKeyEvent uses when nativeScanCode is unknown so a safe
      initial values.
      
      Reviewers: #kwin, zzag
      
      Reviewed By: #kwin, zzag
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D23748
      04845b60
    • David Edmundson's avatar
      Don't notify ksplash in our wayland session · a209ee78
      David Edmundson authored
      Summary:
      KSplash doesn't expect a kwin notification on wayland as kwin is started
      before ksplash.
      
      Reviewers: #kwin, zzag
      
      Reviewed By: #kwin, zzag
      
      Subscribers: broulik, zzag, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D23770
      a209ee78
    • Vlad Zahorodnii's avatar
      a4ec7978
    • Vlad Zahorodnii's avatar
      Rename ShellClient to XdgShellClient · 168ea988
      Vlad Zahorodnii authored
      Summary:
      Rename ShellClient to XdgShellClient in order to reflect that it
      represents only xdg-shell clients.
      
      Test Plan: Compiles, tests still pass.
      
      Reviewers: #kwin
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D23589
      168ea988
    • Vlad Zahorodnii's avatar
      [wayland] Drop xdg-shell v5 support · 665ec0a5
      Vlad Zahorodnii authored
      Summary:
      Drop xdg-shell v5 support since this protocol is obsolete and all popular
      wayland compositors already did that.
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D23573
      665ec0a5
    • Vlad Zahorodnii's avatar
      [tests] Drop wl-shell test client · 973f873d
      Vlad Zahorodnii authored
      Summary: Drop waylandclienttest in favor of xdg-shell test client from KWayland.
      
      Reviewers: #kwin
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D23565
      973f873d
    • Vlad Zahorodnii's avatar
      [effects/slidingpopups] Don't start animation if there is no slide edge · 5469558c
      Vlad Zahorodnii authored
      Summary:
      Given that slide in/out animation duration is not initialized when slide
      location is NoEdge, assert statement will be triggered in slideIn().
      
      Reviewers: #kwin
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D23564
      5469558c
    • Vlad Zahorodnii's avatar
      [platforms/wayland] Drop wl-shell support · 9dd7a188
      Vlad Zahorodnii authored
      Summary: wl-shell is deprecated and its support was dropped in kwin.
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: davidedmundson, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D23563
      9dd7a188
    • Vlad Zahorodnii's avatar
      [wayland] Drop wl-shell support · 7a5447bd
      Vlad Zahorodnii authored
      Summary: wl-shell is deprecated, and pretty much no one uses it.
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: davidedmundson, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D23562
      7a5447bd
    • Vlad Zahorodnii's avatar
      [autotests] Don't test wl-shell clients · d92d6e77
      Vlad Zahorodnii authored
      Summary:
      This change removes all traces of wl-shell in the test suite. That's a
      prerequisite for dropping wl-shell support in KWin.
      
      Given that wl-shell and xdg-shell are not interchangeable, some tests
      were removed and initialization sequence in some tests was adjusted.
      
      The most notable change is ensuring that each plasmashell window sets
      its role and initial position before committing the surface. Setting
      those properties before the first surface commit is important because
      our window placement code needs to know window type in order to
      avoid maximizing panels, popups, etc.
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D23561
      d92d6e77
    • Vlad Zahorodnii's avatar
      Port QPA away from Wayland · bebe8120
      Vlad Zahorodnii authored
      Summary:
      So far wayland was used by internal clients to submit raster buffers
      and position themselves on the screen. While we didn't have issues with
      submitting raster buffers, there were some problems with positioning
      task switchers. Mostly, because we had effectively two paths that may
      alter geometry.
      
      A better approach to deal with internal clients is to let our QPA use
      kwin core api directly. This way we can eliminate unnecessary roundtrips
      as well make geometry handling much easier and comprehensible.
      
      The last missing piece is shadows. Both Plasma::Dialog and Breeze widget
      style use platform-specific APIs to set and unset shadows. We need to
      add shadows API to KWindowSystem. Even though some internal clients lack
      drop-shadows at the moment, I don't consider it to be a blocker. We can
      add shadows back later on.
      
      CCBUG: 386304
      
      Reviewers: #kwin, davidedmundson, romangg
      
      Reviewed By: #kwin, romangg
      
      Subscribers: romangg, kwin
      
      Tags: #kwin
      
      Maniphest Tasks: T9600
      
      Differential Revision: https://phabricator.kde.org/D22810
      bebe8120
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · ca1f66b1
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      ca1f66b1
  3. 22 Sep, 2019 1 commit
  4. 20 Sep, 2019 3 commits
  5. 19 Sep, 2019 8 commits
    • Vlad Zahorodnii's avatar
      Don't initialize QFlags<T> with nullptr · b8a6fd7c
      Vlad Zahorodnii authored
      Summary: This looks very odd.
      
      Test Plan: Compiles.
      
      Reviewers: #kwin, romangg
      
      Reviewed By: #kwin, romangg
      
      Subscribers: apol, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D24086
      b8a6fd7c
    • Nate Graham's avatar
      Improve comprehensibility and consistency of window placement mode names · 2dae1535
      Nate Graham authored
      Summary:
      Right now a few of the window placement modes suffer one or more of the following problems:
      - Inconsistency between the text shown in the Window Behavior and Window Rules KCMs
      - Title does not indicate what it does
      - Awkward wording
      - Lack of unity in grammatical mood between the different modes
      
      This patch fixes these issues by improving the strings and standardizing on the descriptive mood:
      - Smart -> Minimal Overlapping
      - Maximizing -> Maximized
      - Cascade -> Cascaded
      - Zero-Cornered -> In Top-Left Corner
      
      Strings are also unified between the window behavior and window rules KCMs, and docbooks are adjusted accordingly.
      
      Test Plan:
      {F7279685, size=full}
      {F7279694, size=full}
      
      Reviewers: #kwin, #vdg, ndavis, filipf, zzag, romangg
      
      Reviewed By: #kwin, #vdg, ndavis, filipf, romangg
      
      Subscribers: gladhorn, alexeymin, IlyaBizyaev, broulik, hein, hpereiradacosta, GB_2, alexde, davidedmundson, romangg, cfeck, filipf, zzag, ndavis, kwin, kde-doc-english
      
      Tags: #kwin, #documentation
      
      Differential Revision: https://phabricator.kde.org/D23415
      2dae1535
    • Vlad Zahorodnii's avatar
      Merge branch 'Plasma/5.17' · d18fa521
      Vlad Zahorodnii authored
      d18fa521
    • Vlad Zahorodnii's avatar
      Use nullptr everywhere · 62a7db70
      Vlad Zahorodnii authored
      Summary:
      Because KWin is a very old project, we use three kinds of null pointer
      literals: 0, NULL, and nullptr. Since C++11, it's recommended to use
      nullptr keyword.
      
      This change converts all usages of 0 and NULL literal to nullptr. Even
      though it breaks git history, we need to do it in order to have consistent
      code as well to ease code reviews (it's very tempting for some people to
      add unrelated changes to their patches, e.g. converting NULL to nullptr).
      
      Test Plan: Compiles.
      
      Reviewers: #kwin, davidedmundson, romangg
      
      Reviewed By: #kwin, davidedmundson, romangg
      
      Subscribers: romangg, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D23618
      62a7db70
    • Jonathan Riddell's avatar
      Update version number for 5.17.80 · fdf98d6c
      Jonathan Riddell authored
      GIT_SILENT
      fdf98d6c
    • Bhushan Shah's avatar
      [platforms/drm] introduce env var to select GPU · 6b610927
      Bhushan Shah authored
      Summary:
      In some environemnts it is possible that udev detection of primary GPU
      fails and it picks the first available card (normally card0). But it is
      not desired, and it would be required to use different card (card1).
      
      Introduce environment variable, which when used, will make it possible
      to use different card node then one selected by udev.
      
      You can use it like KWIN_DRM_DEVICE_NODE=/dev/dri/card1 kwin_wayland
      
      Test Plan: Tested on the device where card0 was not usable for kms, but card1
      
      Reviewers: #kwin
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D24051
      6b610927
    • Jonathan Riddell's avatar
      Update version number for 5.16.90 · 48691c40
      Jonathan Riddell authored
      GIT_SILENT
      48691c40
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 2806d5f6
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      2806d5f6
  6. 18 Sep, 2019 6 commits
  7. 17 Sep, 2019 3 commits
  8. 16 Sep, 2019 1 commit