1. 22 Feb, 2020 4 commits
    • Nicolas Fella's avatar
      Revert "[kcm/effects] Clip ListView" · 7159684c
      Nicolas Fella authored
      Bad merge
      
      This reverts commit b7130442.
      7159684c
    • Nicolas Fella's avatar
      [kcm/effects] Clip ListView · b7130442
      Nicolas Fella authored
      Summary:
      Otherwise the content overflows the frame when scrolling.
      
      QQC2 scrollview docs say "ScrollView does not automatically clip its contents. If it is not used as a full-screen item, you should consider setting the clip property to true"
      
      Test Plan:
      Before:
      {F8121150}
      
      After:
      {F8121152}
      
      Reviewers: #kwin, #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27558
      b7130442
    • Nicolas Fella's avatar
      Revert "[kcm/effects] Clip ListView" · cdc5ea19
      Nicolas Fella authored
      Bad merge
      
      This reverts commit 5babf52d.
      cdc5ea19
    • Nicolas Fella's avatar
      [kcm/effects] Clip ListView · 5babf52d
      Nicolas Fella authored
      Summary:
      Otherwise the content overflows the frame when scrolling.
      
      QQC2 scrollview docs say "ScrollView does not automatically clip its contents. If it is not used as a full-screen item, you should consider setting the clip property to true"
      
      Test Plan:
      Before:
      {F8121150}
      
      After:
      {F8121152}
      
      Reviewers: #kwin, #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27558
      5babf52d
  2. 21 Feb, 2020 2 commits
  3. 19 Feb, 2020 1 commit
    • David Edmundson's avatar
      [plastik] Disable problematic text hints · 39798bff
      David Edmundson authored
      Summary:
      Use of "style: Text.Raised" combined with UTF-8 emoji characters
      currently crashes deep in font rendering code.
      
      A report has been submitted upstream:
      https://bugreports.qt.io/browse/QTBUG-82311
      
      Given this crash is surprisingly common, this patch removes the text
      shadow. I normally would be against removing features, but this was a
      subtle effect anyway and frankly just made things look blurry. I doubt
      it'll be missed.
      
      BUG: 417699
      BUG: 413179
      
      Test Plan:
      Made unit test for the crash in qmlscene
      Fixed the issue there
      
      Reviewers: #kwin, zzag
      
      Reviewed By: #kwin, zzag
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27488
      39798bff
  4. 18 Feb, 2020 2 commits
  5. 17 Feb, 2020 1 commit
  6. 16 Feb, 2020 1 commit
  7. 14 Feb, 2020 1 commit
  8. 13 Feb, 2020 1 commit
  9. 12 Feb, 2020 1 commit
    • David Edmundson's avatar
      Return early if close button accepts input event · 3dbfa6a3
      David Edmundson authored
      Summary:
      Otherwise we close the effect whenever the close is pressed which is a
      behavioural change.
      
      That in turn leads to bigger bugs
      
      BUG: 415155
      
      Test Plan:
      Ran effect
      Clicked on the "Whitespace" of the dash
      Clicked on the close
      
      Now matches desktopgrid code
      
      Reviewers: #kwin, zzag, ngraham
      
      Reviewed By: #kwin, zzag, ngraham
      
      Subscribers: ngraham, zzag, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27333
      3dbfa6a3
  10. 11 Feb, 2020 1 commit
  11. 09 Feb, 2020 1 commit
  12. 08 Feb, 2020 1 commit
    • Heiko Becker's avatar
      Require kdecoration >= 5.18.0 · 6d8f3732
      Heiko Becker authored
      Summary:
      To successfully build kwin needs 13e6459a3baeebe6a7b594efd995b88f6dd7524e
      in kdecoration. Otherwise it fails with: "previewclient.h:93:11: error:
      'QSize KDecoration2::Preview::PreviewClient::size() const' marked
      'override', but does not override QSize size() const override;"
      So this is not a new requirement but just an update to the build system
      to reflect the actual requirements.
      
      Test Plan: Builds fine with the newly required version
      
      Reviewers: #kwin
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27242
      6d8f3732
  13. 06 Feb, 2020 1 commit
  14. 05 Feb, 2020 1 commit
  15. 03 Feb, 2020 2 commits
    • Vlad Zahorodnii's avatar
      [x11] Fix visual artifacts during interactive resize · 56d5f3a4
      Vlad Zahorodnii authored
      Summary:
      When a window is being interactively resized, its contents may jump. The
      reason why that happens is because KWin renders partially resized client
      window. Composite extension spec says that a window will get a new pixmap
      each time it is resized or mapped. This applies to the frame window, but
      not to the client window itself. If the client window is resized,
      off-screen storage for the frame window won't be reallocated. Therefore,
      KWin may render partially resized client window if the client doesn't
      attempt to be in sync with our rendering loop. Currently, the only way
      to do that is to use extended frame counters, which are not supported by
      KWin.
      
      So, in order to fix visual artifacts during interactive resize, we need
      somehow forcefully re-allocate off-screen storage for the frame window.
      Unfortunately, Composite extension doesn't provide any request to do
      that, so the only option we have is to resize the frame window.
      
      BUG: 415839
      FIXED-IN: 5.18.0
      
      Reviewers: #kwin
      
      Subscribers: davidedmundson, ngraham, alexde, fredrik, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D26914
      56d5f3a4
    • Arjen Hiemstra's avatar
      ScreenEdge: Do not use localtime for measuring duration · 9b3d9e58
      Arjen Hiemstra authored
      Summary:
      QDateTime::fromMSecSinceEpoch uses Qt::LocalTime by default. This involves an
      expensive localtime conversion. So instead force things to use UTC, as there
      is no need for timezone information when tracking durations.
      
      This is especially noticeable on Bedrock Linux, which uses a Fuse mounted
      /etc, which is slower than a plain /etc and causes quite some slowdown there.
      See https://github.com/bedrocklinux/bedrocklinux-userland/issues/140 for
      details.
      
      Test Plan: The screenedge unit test still passes.
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: zzag, anthonyfieroni, davidedmundson, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27114
      9b3d9e58
  16. 31 Jan, 2020 1 commit
  17. 29 Jan, 2020 6 commits
  18. 28 Jan, 2020 6 commits
  19. 27 Jan, 2020 1 commit
  20. 25 Jan, 2020 2 commits
  21. 23 Jan, 2020 3 commits