1. 02 Oct, 2020 1 commit
  2. 07 Aug, 2020 2 commits
    • Vlad Zahorodnii's avatar
      Prettify license headers · 4ce853e8
      Vlad Zahorodnii authored
      4ce853e8
    • Vlad Zahorodnii's avatar
      Switch to SPDX license markers · 1fb9f6f1
      Vlad Zahorodnii authored
      The main advantage of SPDX license identifiers over the traditional
      license headers is that it's more difficult to overlook inappropriate
      licenses for kwin, for example GPL 3. We also don't have to copy a
      lot of boilerplate text.
      
      In order to create this change, I ran licensedigger -r -c from the
      toplevel source directory.
      1fb9f6f1
  3. 25 Jun, 2020 1 commit
    • Ismael Asensio's avatar
      [kcm/kwinrules] Fix types property for NET::AllTypesMask · 8b9472e0
      Ismael Asensio authored
      When the user selects all of the types or none of them, the "types"
      property must be set to a special value (`NET::AllTypesMask = -1`),
      different than the sum of all the flags together.
      
      This re-implements this behaviour as the old KCM, fixing some heuristics
      that prevented finding the rule corresponding to the current window.
      
      The enum name that handles this property has been changed to `NetTypes`
      to make it more explicit.
      
      BUG: 423214
      FIXED-IN: 5.19.3
      
      TEST PLAN:
      1. Open the `Application specific settings` on a window via menu
      2. Select every "Window Type" (or none of them)
      3. Give the rule a different name than the default and save
      4. Open it again and check that the same rule is found
      8b9472e0
  4. 31 May, 2020 1 commit
    • Ismael Asensio's avatar
      [kcm/kwinrules] Fix first item position on property list · 623ee101
      Ismael Asensio authored
      The first time the list in `Add properties` is shown, the position of the first
      delegate is miscalculated as (0, 0) and gets hidden behind the section header.
      It only repositions when the delegate is destroyed and re-created, for example, when
      setting and deleting a filter text. (https://bugs.kde.org/show_bug.cgi?id=422289)
      
      This works-around it by delaying the `overlayModel` filtering until the list is first
      shown, which makes the delegate position correctly.
      
      BUG: 421583
      FIXED-IN: 5.19
      623ee101
  5. 29 May, 2020 1 commit
  6. 15 May, 2020 2 commits
    • Ismael Asensio's avatar
      [kcm/kwinrules] Fix size properties not being stored · db7fb26e
      Ismael Asensio authored
      Summary:
      Use `QSize`/`QPoint` to handle and store coordinate values (size and position)
      
      Previously, the rules model stored the "coordinate" type properties as a
      `QString` with format `x, y`.
      
      This fails when setting the properties to the config schema, as it requires
      a proper `QPoint` or `QSize` value, specially the latter which can't be
      convert from such a string.
      
      BUG: 421055
      FIXED-IN: 5.19.0
      
      Test Plan:
      - Add a new rule and set its position and size properties
      - Hitting apply stores the right values in `~\.config\kwinrulesrc`
      - Close the kcm and reopen, the values are loaded
      - Property detection still works for size and position
      
      Please note that there is a pre-existing bug of some position/sizes not being
      applied to the windows in some cases, when using `Apply Initially`.
      Better try using the `Force` policy.
      
      Reviewers: ngraham, #kwin, #plasma, zzag
      
      Reviewed By: #kwin, #plasma, zzag
      
      Subscribers: zzag, ltoscano, yurchor, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D29764
      db7fb26e
    • Ismael Asensio's avatar
      [kcm/kwinrules] Fix placeholder message in RulesEditor · 97395712
      Ismael Asensio authored
      Summary:
      Fix the anchoring of the placeholder message after https://phabricator.kde.org/R108:9e5498238f88ece28f4f0d22da00879280cb7955
      It needs to center on the free space, not the whole ListView.
      
      Test Plan
      Before: {F8323417}
      After: {F8323416}
      
      Reviewers: ngraham, broulik, #vdg, #plasma
      
      Reviewed By: ngraham, #vdg
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D29783
      97395712
  7. 12 May, 2020 1 commit
  8. 06 May, 2020 1 commit
  9. 24 Apr, 2020 1 commit
  10. 22 Apr, 2020 1 commit
    • Ismael Asensio's avatar
      KWinRules KCM Redesign · a04b40da
      Ismael Asensio authored
      Summary:
      Replacement KCM to configure kwin rules, using a QML-based UI.
      
      After some work on the task T12729, it is almost feature-par with the previous module, and adapted to the recent move to KConfigXT.
      
      Test Plan:
      {F8208046}
      {F8208047}
      
      Reviewers: #plasma, #kwin, #vdg, ngraham, davidedmundson, zzag
      
      Reviewed By: #plasma, #kwin, #vdg, ngraham, davidedmundson, zzag
      
      Subscribers: ngraham, davidedmundson, hchain, broulik, zzag, kwin
      
      Tags: #kwin, #vdg
      
      Differential Revision: https://phabricator.kde.org/D28152
      a04b40da