GIT_SILENT
NO_CHANGELOG

Ismael Asensio authored May 20, 2022 and Alexander Lohnau committed May 21, 2022

After commit c1d0aa18, the namespace where the KCM is installed
changed to `plasma/kcms/systemsettings/`.

We need to point to this new plugin location when the KCM is
launched via Alt-F3 > "Window Specific Properties"

Also let's set the full plugin location from CMake instead of
harcoded in C++ so it is easier to keep it in sync.

BUG: 454066
FIXED-IN: 5.25.0

Aleix Pol Gonzalez authored May 20, 2022 and Aleix Pol Gonzalez committed May 20, 2022

While looking at xkb code I found what this + 8 meant, figured we better
include it in our code so it feels less magical.

Aleix Pol Gonzalez authored May 20, 2022 and Aleix Pol Gonzalez committed May 20, 2022

Be explicit about how we only request privileged tokens internally in
KWin.

The Blendchanges effect works by showing a snapshot of the current
screen for a few ms. Any other active full screen effect will look
broken, so it should take priority.

This is pre-empting an issue with a new Plasma feature that syncs
colours to wallpapers. Once we animate activity switches / have per
desktop wallpapers it'll glitch out.

David Edmundson authored May 19, 2022 and Vlad Zahorodnii committed May 19, 2022

Firstly we weren't waiting for a signal at all, we are relying on events
being processed externally which is wrong.

Secondly ScreenLocker::KSldApp::self()->lockState() is tri-state;
unlocked, acquiring, locked. This gets compressed to a boolean where
acquiring and locked are the same.

If we run the tests whilst we're still acquiring the lock screen we can
call unlocked before we've finished locking. The greeter might then be
shown afterwards triggering a re-lock. It's a confused state.

We want those to be shown when they are explicitly pinned, but
not in the normal app search/overview.

Fixes teams/plasma-mobile/issues#154 (comment 452861)

In present windows, you could hit the same screen edge that you use to
activate the effect in order to deactivate it.

Move the screen edge effect earlier in the effect chain so QML effects
can render their contents first, then draw screen edge glow.

Kai Uwe Broulik authored Apr 26, 2022 and Vlad Zahorodnii committed May 19, 2022

The XRender backend has been removed, leaving most of KWinXRenderUtils unused.

The few features that are still used, notable `XRenderPicture` and pict format
are moved into the x11/common directory.

Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>

Window View effect requires OpenGL compositing.

GIT_SILENT

Xaver Hugl authored May 18, 2022 and Vlad Zahorodnii committed May 19, 2022

For some reason with legacy the cursor gets an offset when changing the
image. In order to work around this, directly issue a cursor move with the
corrected position when changing the buffer

GIT_SILENT

Xaver Hugl authored May 17, 2022 and Vlad Zahorodnii committed May 19, 2022

As we don't provide any ability for the user to configure the gestures yet,
the gesture for the desktop grid should stay as it was in the last release.
This commit swaps the gestures for desktopgrid and overview to achieve that.

At the moment, the data offer initializes supported and preferred action
to "none". But if the target doesn't accept anything the source
provides, the compositor may still need to send action events with "none"

This change makes data offer and data source provide dnd actions wrapped
in std::optional in order to indicate if they have been set explicitly.

David Redondo authored May 17, 2022 and David Edmundson committed May 19, 2022

SeatInterface emits dragEnded when the drag is dropped. The target may want
to interact with the data source after the drop happened, for example only
fetching data after the drop and not during the drag.
(Note that the Wayland protocol has the same
Xvisits are now not deleted prematurely but only when they are really finished.
(Note that the Wayland protocol has the same distinction between dropped and
finished so it maps nicely).
For storing  previous visits the same code pattern as in the rest of the XWayland
DND code is used.
The SelectionSource is reset when the next Drag/Drop operation involving a X window
is started (see startDrag and doHandleXfixesNotify) or when the Wayland source is
about to be deleted.

BUG:450460
FIXED-in:5.25.0

Guenther Grau authored May 18, 2022 and Vlad Zahorodnii committed May 19, 2022

Arguments for clientMaximizedStateChanged were incorrect in window.cpp.
They are correct in xdgshellclient.cpp and window.h

BUG: 380836

This reverts commits 67181d5d and
d03e352d.

BUG: 454014

Vlad Zahorodnii authored May 18, 2022 and Xaver Hugl committed May 18, 2022

This popup cleanup code can be useful also on wayland.

If progress goes out of the [0, 1] range, effects misbehave

Aleix Pol Gonzalez authored May 16, 2022 and Nate Graham committed May 18, 2022

Allow internal uses of KWindowSystem to support activating other
clients.

BUG: 453748
BUG: 453785

BUG:451279
FIXED-IN:5.25.0

Otherwise the cursor won't be shown, as its buffer and layer got destroyed

BUG: 453823

Xaver Hugl authored May 18, 2022 and Vlad Zahorodnii committed May 18, 2022

The current mode may be nullptr

Gesture recognition code doesn't handle correctly cancelling a touch
sequence. testTouchPoint in one of its tests simulates pressing the
screen with three fingers and cancelling the touch sequence.

Emitting the Workspace::windowAdded() signal before actually adding the
window to the Workspace is counter-intuitive and it can a source of
potential bugs as relevant window lists in Workspace don't contain the
window yet.

The features that this KCM lets you trigger barely work on X11 and
really only work properly on Wayland.

Unfortunately we don't have the ability to have separate settings
between X11 and Wayland, and for this reason we removed a default left
touch edge in 3df79855 a year and a half
ago because it was too buggy on X11.

This commit takes the next step and hides the KCM entirely on X11, so
you can only use it on Wayland where it actually works properly.

One potential downside is be that any users who are actually using it
on X11 will lose the ability to use a GUI to configure these features
unless they go to the Wayland session to do it. However the number of
such users is likely small given how the feature does not really work on
X11.

However the upside is that Wayland users who can see the KCM can
actually use the features that it lets you configure because they work
properly there.

I believe this is a relic from the past when we used not to destroy
the ShellClient when the associated surface is unmapped.

As it turns out, it's needed to ensure that the Workspace emits the
stackingOrder changed signal when a new window is added. It's also
implicitly needed to make sure that Window::stackingOrder() is updated.

Use QWidget::screen instead of having own code to fetch the screen. It
works better this way before the window is initialised.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Currently we guess the supported and preferred dnd actions in data offer
for version >= 3. This can create problems because kwin may not send the
right action events when the supported dnd actions actually change.

Currently, the cursor size check ignores the cursor bitmap's size, so
the hardware cursor is used even though the bitmap size exceeds cursor
limits.