1. 30 Sep, 2019 2 commits
  2. 29 Sep, 2019 5 commits
  3. 27 Sep, 2019 2 commits
    • David Edmundson's avatar
      [libkwineffects] Introduce API to easily show a QtQuick scene in an effect · 40b0296d
      David Edmundson authored
      Summary:
      EffectQuickView/Scene is a convenient class to render a QtQuick
      scenegraph into an effect.
      
      Current methods (such as present windows) involve creating an underlying
      platform window which is expensive, causes a headache to filter out
      again in the rest of the code, and only works as an overlay.
      
      The new class exposes things more natively to an effect where we don't
      mess with real windows, we can perform the painting anywhere in the view
      and we don't have issues with hiding/closing.
      
      QtQuick has both software and hardware accelerated modes, and kwin also
      has 3 render backends. Every combination is supported.
      
      * When used in OpenGL mode for both, we render into an FBO export the
      texture ID then it's up to the effect to render that into a scene.
      
      * When using software QtQuick rendering we blit into an image, upload
      that into a KWinGLTexture which serves as an abstraction layer and
      render that into the scene.
      
      * When using GL for QtQuick and XRender/QPainter in kwin everything is
      rendered into the internal FBO, blit and exported as an image.
      
      * When using software rendering for both an image gets passed directly.
      
      Mouse and keyboard events can be forwarded, only if the effect
      intercepts them.
      
      The class is meant to be generic enough that we can remove all the
      QtQuick code from Aurorae.
      
      The intention is also to replace EffectFrameImpl using this backend and
      we can kill all of the EffectFrame code throughout the scenes.
      
      The close button in present windows will also be ported to this,
      simplifiying that code base.
      
      Classes that handle the rendering and handling QML are intentionally
      split so that in the future we can have a declarative effects API create
      overlays from within the same context. Similar to how one can
      instantiate windows from a typical QML scene.
      
      Notes:
      I don't like how I pass the kwin GL context from the backends into the
      effect, but I need something that works with the library separation. It
      also currently has wayland problem if I create a QOpenGLContext before
      the QPA is set up with a scene - but I don't have anything better?
      
      I know for the EffectFrame we need an API to push things through the
      effects stack to handle blur/invert etc. Will deal with that when we
      port the EffectFrame.
      
      Test Plan: Used in an effect
      
      Reviewers: #kwin, zzag
      
      Reviewed By: #kwin, zzag
      
      Subscribers: zzag, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D24215
      40b0296d
    • David Edmundson's avatar
  4. 26 Sep, 2019 14 commits
  5. 25 Sep, 2019 7 commits
    • Vlad Zahorodnii's avatar
      Rename Client to X11Client · ffcbe24e
      Vlad Zahorodnii authored
      Summary:
      Currently each managed X11 client is represented with an instance of
      Client class, however the name of that class is very generic and the
      only reason why it's called that way is because historically kwin
      was created as an x11 window manager, so "Client" was a sensible choice.
      
      With introduction of wayland support, things had changed and therefore
      Client needs to be renamed to X11Client in order to better reflect what
      that class stands for.
      
      Renaming of Client to X11Client was agreed upon during the last KWin
      sprint.
      
      Test Plan: Compiles, the test suite is still green.
      
      Reviewers: #kwin, romangg
      
      Reviewed By: #kwin, romangg
      
      Subscribers: romangg, davidedmundson, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D24184
      ffcbe24e
    • David Edmundson's avatar
      [kcmkwin/compositing] Hide animation speed slider on Plasma · a486b471
      David Edmundson authored
      Summary:
      Hide the animation speed slider on Plasma as this becomes duplicated
      with the global "animation speed" slider.
      
      Also port to the new format for the config option which stores the
      actual multiplier, not a magic number.
      
      Test Plan:
      Didn't appear normally
      Manually modified env; slider appeared
      Tested load/save of defaults and the two extremes
      
      Reviewers: zzag
      
      Reviewed By: zzag
      
      Subscribers: zzag, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D24075
      a486b471
    • David Edmundson's avatar
      Migrate kwin animation speed to kdeglobals · 78a66fcf
      David Edmundson authored
      Test Plan:
      Tested output piping test lines into the script with different settings
      Removed from my kdeglobals
      Invoked script. New value appeared
      
      (note that if you manually test multiple times locally you have to
      cleanup the $version info from
      both kdeglobals and kwinrc or the migration will be skipped)
      
      Reviewers: zzag
      
      Reviewed By: zzag
      
      Subscribers: zzag, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D24084
      78a66fcf
    • David Edmundson's avatar
      Load animation speed from new global animation speed controller · 910ba1eb
      David Edmundson authored
      Summary:
      It doesn't belong with advanced compositing settings as it's quite user
      friendly, and we also want to adjust other animation speeds. May as well
      do it together.
      
      In the current form all compositing is still completely reinitiliased
      like with the previous slider. Change notifications come in the form of
      KConfigWatcher rather than our own bespoke update interface.
      
      Test Plan:
      Moved new slider, minimised a window.
      It still behaved as expected.
      
      Reviewers: #kwin, zzag
      
      Reviewed By: #kwin, zzag
      
      Subscribers: zzag, broulik, anthonyfieroni, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D22887
      910ba1eb
    • David Edmundson's avatar
      KWin::GLTexture support external textures · d78fda30
      David Edmundson authored
      Summary:
      Currently KWin::GLTexture is a nice wrapper for creating a GL texture
      and performing various operations including rendering.
      
      In a pending patch I want to render the FBO from a QQuickScene directly,
      where we have an underlying texture already, but it makes sense to
      re-use this class for the rendering. A similar need is in haagch's kwin
      VR patchset.
      
      This patch adds a constructor to GLTexture that takes an externally
      managed texture and provides the relevant useful KWin features.
      
      Test Plan: Used in patch series
      
      Reviewers: #kwin, zzag
      
      Reviewed By: #kwin, zzag
      
      Subscribers: zzag, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D24206
      d78fda30
    • David Edmundson's avatar
      Avoid event processing infinite loop · 0c876cd9
      David Edmundson authored
      Summary:
      Kwin on X11 overrides QCoreApplication::notify to get low level system
      event.
      
      If something handled by the low level filtering ever calls postEvent we
      would end up in a loop. This was found when forwarding a key event into
      a QQuickWindow in a similar manner that mouse events are forwarded.
      
      Fortunately there's a flag to separate generated and core events
      
      Test Plan:
      No more infinite loop
      Kwin X11 still works fine
      
      Reviewers: #kwin, zzag
      
      Reviewed By: #kwin, zzag
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D24207
      0c876cd9
    • Bhushan Shah's avatar
      [platforms/drm] Consider DSI connector type to be internal display · ef540699
      Bhushan Shah authored
      Summary:
      Lot of mobile devices, as well as tablet devices use the DSI connector,
      for internal screens. This is more common in ARM devices, so consider
      them as internal display as well.
      
      Test Plan: checked on the device with DSI screen, it was considered internal
      
      Reviewers: #kwin, romangg
      
      Reviewed By: #kwin, romangg
      
      Subscribers: romangg, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D24209
      ef540699
  6. 24 Sep, 2019 8 commits
  7. 23 Sep, 2019 2 commits