1. 25 Oct, 2019 1 commit
    • Vlad Zahorodnii's avatar
      [scripting] Provide conversion functions for AbstractClient · a738ecce
      Vlad Zahorodnii authored
      Summary:
      If no conversion functions are provided for a QObject-subclass, then
      QScriptEngine will use QScriptEngine::newQObject() method without any
      special options to convert an instance of that QObject-subclass to a
      QScriptValue. However, it's very important that every client object is
      wrapped with PreferExistingWrapperObject option. We need that option
      because a script may set a property on a client object and that property
      must remain until it's deleted by the script.
      
      BUG: 413044
      FIXED-IN: 5.17.2
      
      Test Plan: New test.
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: davidedmundson, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D24944
      a738ecce
  2. 16 Jul, 2019 1 commit
    • Aleix Pol Gonzalez's avatar
      Install KPackages with kpackage_install_package · 6cd9b2ba
      Aleix Pol Gonzalez authored
      Summary:
      Removes a bunch of boilerplate CMake code and allows kpackage to do
      some smart things, e.g. drops our runtime dependency on the
      DesktopFileParser and we get to just use json directly.
      
      Test Plan: Ran kwin, now it doesn't use the desktop to json translation path, everything still works.
      
      Reviewers: #kwin, zzag
      
      Reviewed By: #kwin, zzag
      
      Subscribers: davidedmundson, zzag, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D22474
      6cd9b2ba
  3. 28 Jun, 2019 1 commit
    • Vlad Zahorodnii's avatar
      [scripts] Drop enforcedeco script · 06363b1c
      Vlad Zahorodnii authored
      Summary:
      GTK clients check whether _GTK_FRAME_EXTENTS is in _NET_SUPPORTED, so we
      don't need this script anymore.
      
      Also, because GTK clients don't set shadow extents, this script
      is doing nothing.
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: ngraham, jackg, broulik, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D21371
      06363b1c
  4. 07 Apr, 2015 1 commit
  5. 03 Jul, 2014 1 commit
    • Martin Flöser's avatar
      Add a script to enforce window decorations for GTK windows · f0e1e318
      Martin Flöser authored
      This is going to be a controversal change. It enforces KWin decorations
      on all client side decorated windows from GTK+. Unfortunately we are
      caught between a rock and a hard place. Keeping the status quo means
      having broken windows and a more or less broken window manager due to
      GTK+ including the shadow in the windows. This is no solution.
      Enforcing server side decorations visually breaks the windows. This is
      also no solution. So why do it?
      
      It's our task to provide the best possible user experience and KWin is
      a window manager which has always done great efforts to fix misbehaving
      windows. One can think of the focus stealing prevention, the window rules
      and lately the scripts. The best possible window management experience is
      our aim. This means we cannot leave the users with the broken windows
      from GTK.
      
      The issues we noticed were reported to GTK+ about 2 months ago and we are
      working on improving the situation. Unfortunately several issues are not
      yet addressed and others will only be addressed in the next GTK+ release.
      We are working on improving the NETWM spec (see [1]) to ensure that the
      client side decorated windows are not in a broken state. This means the
      enforcment is a temporary solution and will be re-evaluated with the next
      GTK release. I would prefer to not have to do such a change, if some of
      the bugs were fixed or GTK+ would not use client-side-decos on wms not
      yet supporting those all of this would be a no issue.
      
      For a complete list of the problems caused by GTK's decos see bug [2] and
      the linked bug reports from there.
      
      The change is done in a least inversive way in KWin. We just check for
      the property _GTK_FRAME_EXTENTS and create a Q_PROPERTY in Client for it.
      If we add support for the frame extents in future we would also need
      this. So it's not a change just for enforcing the decoration.
      
      The actual enforcing is done through a KWin script so users can still
      disable it.
      
      REVIEW: 119062
      
      [1] https://mail.gnome.org/archives/wm-spec-list/2014-June/msg00002.html
      [2] https://bugzilla.gnome.org/show_bug.cgi?id=729721
      f0e1e318
  6. 10 May, 2012 1 commit
    • Martin Flöser's avatar
      Add CMake variable to rename kwin binaries · f3443a6b
      Martin Flöser authored
      A CMake variable is used to specify the name of the binary.
      By default this is "kwin" but building for PA changes the
      name to "kwinactive". The variable adjusts all names, e.g.
      kwinnvidiahack becomes kwinactivenvidiahack.
      
      The remaining usage of kwinrc in core and libs is replaced
      by a cmakedefine for the configuration name and all data
      installations are moved to the defined name. Dynamic loading
      for scripts & co is adjusted for loading based on defined name.
      
      This change allows the side-by-side installation of both kwin
      for desktop and kwin for Plasma Desktop without the known
      issues like conflicts in config files or missing build options
      if kwin desktop is used for Plasma Active.
      
      Likewise the KCMs are not adjusted as they are not intended to
      be used for kwinactive.
      
      REVIEW: 104299
      BUG: 296084
      FIXED-IN: 4.9.0
      CCMAIL: active@kde.org
      f3443a6b
  7. 02 Mar, 2012 1 commit
  8. 29 Feb, 2012 1 commit
  9. 21 Feb, 2012 1 commit
    • Martin Flöser's avatar
      Adding a video wall script · 949eeedb
      Martin Flöser authored
      This script allows to have video fullscreen windows span all attached
      screens creating a video wall.
      
      This replaces the removed functionality that you could disable
      xinerama support inside KWin for fullscreen windows.
      
      REVIEW: 104014
      949eeedb