1. 25 Sep, 2013 1 commit
    • Martin Flöser's avatar
      Fix reading of window properties from effects · be3a0cf4
      Martin Flöser authored
      That's what you get for changing code you cannot properly test. The
      calculation was completely messed up. Now reads the correct byte size
      for the byte array. In addition the usages in the effects are improved
      to cast the data into the proper uint32_t values instead of the more
      generic long. After all if the format is 32, the length is 32 and not
      a long.
      be3a0cf4
  2. 08 Sep, 2013 1 commit
    • Thomas Lübking's avatar
      highlight effect: windowAdded false positive exits · 2a5861fa
      Thomas Lübking authored
      When a window is added while the effect is running
      it shall either be highlighted or hidden, but not exit
      the effect what happened, because the property notification
      is invoked to test whether the window has a highlight
      property (questionable since the effect is running, but
      valid - could be different X11 client) and that routine
      exits the effect if no property is found (assuming it was
      withdrawn)
      
      REVIEW: 112494
      2a5861fa
  3. 02 Sep, 2013 1 commit
  4. 07 Jan, 2013 1 commit
    • Martin Flöser's avatar
      Common way to announce support for specific effects through X11 · 565b4ed6
      Martin Flöser authored
      Instead of each effect, which needs to announce support, having custom
      code to create a property and set it on the root window, there is now a
      common API in EffectsHandler to take care of this.
      
      The methods takes care of creating the atom if it has not already done
      and set the property on the root window. Furthermore it allows multiple
      effects to announce the same property without getting in conflict with
      each other.
      
      As a further convenience the property is automatically removed when the
      effect is unloaded, so less things an effect author has to care about.
      
      REVIEW: 107815
      565b4ed6
  5. 19 Jul, 2012 1 commit
    • Martin Flöser's avatar
      Getter/setters for opacity, saturation and brightness in WindowPaintData · c7262e8b
      Martin Flöser authored
      The public member variables for opacity, saturation and brightness
      are removed in favor for getter and setters. The variables are
      moved into a private class. Those are now qreal instead of double.
      
      To make usage inside the effects easier a multiply method is added
      which multiplies the current value with passed in factor and returns
      the new value in a functional programming style.
      
      This commit is the top-most of a patch series to refactor
      ScreenPaintData and WindowPaintData. Other related commits are:
      * 0811772
      * ebdc7ec
      * 2c8dd8d
      * 7699726
      * 68e0201
      * 611cb09
      
      REVIEW: 105141
      BUG: 303314
      FIXED-IN: 4.10
      c7262e8b
  6. 12 Mar, 2012 1 commit
  7. 11 Feb, 2012 3 commits
    • Thomas Lübking's avatar
      fix tabbing · 85635dd4
      Thomas Lübking authored
      BUG: 290959
      BUG: 265160
      BUG: 229292
      BUG: 238279
      BUG: 290758
      BUG: 222831
      BUG: 278275
      BUG: 245747
      BUG: 230000
      
      BUG: 253697
      BUG: 230570
      BUG: 265977
      BUG: 225337
      BUG: 225339
      
      REVIEW: 103855
      85635dd4
    • Thomas Lübking's avatar
      Revert "fix tabbing" · bf88ec09
      Thomas Lübking authored
      pushed out of branch, not master - leading to absent revision, found hash collision??
      
      This reverts commit 94b2ad7b85801e37e2df4671cdc4f26b6d7e5506.
      bf88ec09
    • Thomas Lübking's avatar
      fix tabbing · d245035a
      Thomas Lübking authored
      BUG: 290959
      BUG: 265160
      BUG: 229292
      BUG: 238279
      BUG: 290758
      BUG: 222831
      BUG: 278275
      BUG: 245747
      BUG: 230000
      
      BUG: 253697
      BUG: 230570
      BUG: 265977
      BUG: 225337
      BUG: 225339
      
      REVIEW: 103855
      d245035a
  8. 18 Dec, 2011 1 commit
    • Thomas Lübking's avatar
      Highlight window: support minimized windows · ba529f20
      Thomas Lübking authored
      also
      - replace QHash::operator[]
      - replace double by float (-> ARM, and we don't need that precision)
      - weaken some value checks ("== 1.0f")
      - fix last paint of hiding windows (w->addRepaintFull() trap)
      
      REVIEW: 103404
      ba529f20
  9. 29 Aug, 2011 1 commit
    • Martin Flöser's avatar
      Only call active effects in the effect chain · fe4329a2
      Martin Flöser authored
      Each effect is able to declare itself as currently being active,
      that is transforming windows or painting or screen or doing anything
      during the current rendered frame.
      
      This change eliminates the hottest path inside KWin identified by
      callgrind.
      
      REVIEW: 102449
      fe4329a2
  10. 12 Mar, 2011 1 commit
  11. 27 Feb, 2011 2 commits
  12. 25 Feb, 2011 1 commit
    • Martin Flöser's avatar
      EffectsHandler emits windowAdded signal · ab6f2ba1
      Martin Flöser authored
      All previously existing windowAdded methods are renamed to slotWindowAdded.
      EffectsHandlerImpl is connected to Workspace's clientAdded signal, which is
      emitted a little bit earlier than the previous direct method call. This might
      change behavior.
      Another signal is added to Workspace to signal that an unmanaged is added.
      ab6f2ba1
  13. 14 Feb, 2011 2 commits
  14. 06 Feb, 2011 1 commit
  15. 05 Feb, 2011 1 commit
  16. 31 Jan, 2011 1 commit
  17. 17 Oct, 2010 1 commit
  18. 01 Feb, 2010 1 commit
  19. 23 Dec, 2009 1 commit
  20. 20 Dec, 2009 3 commits
  21. 13 Sep, 2009 1 commit
    • Martin Flöser's avatar
      Here comes the new TabBox. It is a complete rewrite using a MVC approach. Here some highlights: · 76f17e6d
      Martin Flöser authored
       * Models and Delegates for Clients and Desktops
       * Horizontal, vertical and tabular layout
       * Layout of one item can be configured by an XML definition
       * A desktop item can include a client list
       * An optional second list view showing only the selected item
       * A new KCM "kwintabbox"
       * An alternative TabBox with independent settings and keybindings
       * Optional Highlight Windows effect integration
       * List scrolls instead of removing items
       * Scroll wheel support
       * Cursor key support
       * Middle click on item closes window
      BUG: 195745
      BUG: 197187
      BUG: 201103
      FEATURE: 118184
      FEATURE: 156723
      FEATURE: 177441
      FEATURE: 182897
      FEATURE: 193882
      GUI:
      
      svn path=/trunk/KDE/kdebase/workspace/; revision=1022861
      76f17e6d
  22. 11 May, 2009 1 commit
  23. 05 May, 2009 1 commit
  24. 14 Feb, 2009 1 commit
  25. 09 Feb, 2009 1 commit
  26. 07 Feb, 2009 1 commit
    • Lucas Murray's avatar
      SVN_SILENT Started writing code that would display a thumbnail of a · fd233d14
      Lucas Murray authored
      window in the middle of the screen if it was offscreen when the
      highlight window effect was activated. After getting half way through it
      however I determined that it was a useless feature so instead of
      deleting the code that was already written I am just commenting it out.
      If anyone can find a purpose for this please let me know your ideas.
      
      svn path=/trunk/KDE/kdebase/workspace/; revision=922795
      fd233d14
  27. 05 Feb, 2009 1 commit
  28. 03 Feb, 2009 1 commit
  29. 31 Jan, 2009 1 commit