1. 17 Mar, 2020 2 commits
  2. 16 Mar, 2020 2 commits
    • Henri Chain's avatar
      Remove default button on kwinrules KCM · 518c85e9
      Henri Chain authored
      Summary:
      The "default" button was behaving the same as "reset" which was unnecessary and confusing.
      
      As the only settings are the list of rules, the only meaning "default" could have is to clear all the rules, which is probably not what the user would want. So I think the best course of action is to remove the button.
      
      Reviewers: zzag, meven, crossi, bport, ervin
      
      Reviewed By: zzag
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D28071
      518c85e9
    • Henri Chain's avatar
      Port kwinrules kcm to kconfigxt · 7c1c9d81
      Henri Chain authored
      Reviewers: meven, crossi, bport, ervin, #kwin
      
      Subscribers: iasensio, ognarb, zzag, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27682
      7c1c9d81
  3. 15 Mar, 2020 1 commit
  4. 14 Mar, 2020 2 commits
  5. 13 Mar, 2020 2 commits
  6. 11 Mar, 2020 1 commit
    • Bhushan Shah's avatar
      Fix the tablet mode manager · 7c5c7b5a
      Bhushan Shah authored
      Summary:
      Previously we connected the hasTabletModeSwitchChanged to the
      tabletModeAvailableChanged which meant that in startup once libinput
      signaled us that we have switch, we would toggle that we now have a
      tablet mode.
      
      But, we were connecting this to wrong signal, as a result tablet mode
      would become available, but actual tablet switch inputspy was never
      getting registered, so tablet mode events were silently ignored.
      
      Test Plan:
      tested on Dell Inspiron 7000 laptop where tablet mode switch
      is available
      
      Reviewers: zzag
      
      Reviewed By: zzag
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27975
      7c5c7b5a
  7. 10 Mar, 2020 1 commit
  8. 07 Mar, 2020 3 commits
  9. 05 Mar, 2020 1 commit
    • Vlad Zahorodnii's avatar
      Introduce AbstractClient::createDecoration() · 4ae6c99c
      Vlad Zahorodnii authored
      Summary:
      We have duplicated code in InternalClient and XdgShellClient to create
      decorations. In order to get rid of the code duplication, this change
      introduces a method that AbstractClient subclasses can call to create
      a window decoration.
      
      Test Plan: Tests pass.
      
      Reviewers: #kwin, apol
      
      Reviewed By: apol
      
      Subscribers: apol, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27822
      4ae6c99c
  10. 04 Mar, 2020 4 commits
  11. 03 Mar, 2020 1 commit
  12. 02 Mar, 2020 3 commits
  13. 01 Mar, 2020 1 commit
  14. 29 Feb, 2020 2 commits
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 5f8a7768
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      5f8a7768
    • Roman Gilg's avatar
      Remove orientation sensor · 2c66e1f6
      Roman Gilg authored
      Summary:
      This functionality will instead be implemented in KScreen such that manual and
      automatic output rotation can be used and configured through a single UI in
      unison together.
      
      Test Plan: Compiles.
      
      Reviewers: #kwin, davidedmundson, zzag
      
      Reviewed By: #kwin, zzag
      
      Subscribers: kwin, bshah, davidedmundson, zzag
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D26036
      2c66e1f6
  15. 28 Feb, 2020 14 commits
    • Ismael Asensio's avatar
      Port away from deprecated KIconLoader::IconSize · 7706e17d
      Ismael Asensio authored
      Summary: Use `QStyle::pixelMetrics` instead
      
      Test Plan:
      No compiler warning
      Icon still happily bounces on application launch
      
      Reviewers: #kwin, davidedmundson, broulik
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Maniphest Tasks: T11637
      
      Differential Revision: https://phabricator.kde.org/D27726
      7706e17d
    • Vlad Zahorodnii's avatar
      [autotests] Fix PointerInputTest::testCursorImage() · fcea0eb2
      Vlad Zahorodnii authored
      Summary:
          FAIL!  : KWin::PointerInputTest::testCursorImage() Compared QImages differ in device pixel ratio.
             Actual   (((p->cursorImage()))): 2
             Expected (blueScaled): 1
             Loc: [/home/vlad/Workspace/KDE/src/kde/workspace/kwin/autotests/integration/pointer_input.cpp(1058)]
      
      Test Plan: The test passes.
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: davidedmundson, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27725
      fcea0eb2
    • Vlad Zahorodnii's avatar
      Return early if we ignore resize increments and aspect ratio constraints · fb114dfb
      Vlad Zahorodnii authored
      Summary:
      If we know that we are going to disobey resize increment and aspect ratio
      geometry hints, then there is no point for trying to constrain the client
      size according to those hints. Just return early.
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27031
      fb114dfb
    • Vlad Zahorodnii's avatar
      Honor minimum and maximum size of InternalClient · b8f1c09c
      Vlad Zahorodnii authored
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D26831
      b8f1c09c
    • Vlad Zahorodnii's avatar
      [wayland] Honor xdg-toplevel size constraints · 2b120e07
      Vlad Zahorodnii authored
      Summary:
      This change ensures that we honor surface size constraints specified by
      xdg-toplevel clients.
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D26830
      2b120e07
    • Vlad Zahorodnii's avatar
      Document AbstractClient::minSize() and AbstractClient::maxSize() · c3abe87f
      Vlad Zahorodnii authored
      Summary:
      Clarify that AbstractClient::minSize() and AbstractClient::maxSize()
      specify the minimum and the maximum client size.
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D26829
      c3abe87f
    • Vlad Zahorodnii's avatar
      Refactor geometry constraints code · a75fb7f8
      Vlad Zahorodnii authored
      Summary:
      Currently, there are a couple of issues with sizeForClientSize(). First
      of all, we have a method called clientSizeToFrameSize() which does similar
      thing except applying geometry constraints and checking window rules. The
      other issue is that sizeForClientSize() is doing a bit too much, it checks
      window rules, it applies a bunch of geometry constrains. Sometimes it
      does not perform conversion between client sizes and frame sizes!
      
      This change attempts to address those issues by replacing sizeForClientSize
      with two similar methods and changing semantics of some methods of the
      X11Client class.
      
      The most significant difference between sizeForClientSize() and the new
      methods is that neither constrainClientSize() nor constrainFrameSize()
      check window rules. This is up to users of those methods. In many places,
      we don't have to check window rules because we check isResizable(),
      which returns false if the frame size is enforced by a window rule.
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: davidedmundson, romangg, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D26828
      a75fb7f8
    • Roman Gilg's avatar
      [libinput] Send touch events with respect to device rotation · 5b6e081a
      Roman Gilg authored
      Summary:
      Touch events coming from libinput devices must be transformed according to the
      current device rotation.
      
      Test Plan: Manually.
      
      Reviewers: #kwin
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D25921
      5b6e081a
    • Roman Gilg's avatar
      [platforms/drm] Fix cursor output rotation · 7c70b344
      Roman Gilg authored
      Summary:
      The calculation of cursor position and orientation on outputs rotations other
      than 0° and 180° was faulty.
      
      This patch fixes both.
      
      Test Plan: In live session cursor looks and moves as expected.
      
      Reviewers: #kwin
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D25909
      7c70b344
    • David Edmundson's avatar
      [platforms/drm] Rewrite rotation rendering to use MapTexture · 8ff01fa6
      David Edmundson authored
      Summary:
      The previous code uses a fixed version of GSLS which does not match our suported GL targets. We need both, using kwin's existing MapTexture framework we can achieve the same thing in a better way with less code.
      
      Test Plan:
      Had some slight issues with the rotation, but everything appeared the same
      as when I applied the patchset with the custom shader.
      
      Reviewers: #kwin, zzag
      
      Reviewed By: #kwin, zzag
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D26371
      8ff01fa6
    • Roman Gilg's avatar
      [platforms/drm] Introduce Gl post-process output rotations · 81806622
      Roman Gilg authored
      Summary:
      In case the hardware is not able to rotate the output for the configured
      rotation value do this rotation in a post-process step.
      
      For that rendering the current view into a separate framebuffer bound to a
      texture that then gets sampled to the default framebuffer in an additional
      rendering pass through a simple shader rotating it.
      
      This allows us to leave the Effects system and internal model-view-projection
      matrix untouched. The rotation in the post-processing step is isolated.
      
      BUG: 389665
      FIXED-IN: 5.18
      
      Test Plan: With KScreen all rotations work.
      
      Reviewers: #kwin
      
      Subscribers: davidedmundson, PureTryOut, z3ntu, zzag, univerz, kwin
      
      Tags: #kwin
      
      Maniphest Tasks: T6106
      
      Differential Revision: https://phabricator.kde.org/D25907
      81806622
    • Roman Gilg's avatar
      Cache output transformation first · 429fe058
      Roman Gilg authored
      Summary:
      First we need to set a transformation, then update the backend. In DRM the
      cursor gets updated and needs the new transformed size.
      
      Longterm we need a pending state if we want to apply configuration changes
      atomically or deny them.
      
      Test Plan: Compiles.
      
      Reviewers: #kwin, zzag
      
      Reviewed By: #kwin, zzag
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D25903
      429fe058
    • Roman Gilg's avatar
      Add modeSize getter · 15de237d
      Roman Gilg authored
      Summary:
      The getter pixelSize rotates the size of the mode. In contrast modeSize just
      directly returns the current mode size.
      
      Test Plan: Compiles
      
      Reviewers: #kwin, zzag
      
      Reviewed By: #kwin, zzag
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D25901
      15de237d
    • Roman Gilg's avatar
      Inform Screens about size change · f2467684
      Roman Gilg authored
      Summary:
      Changes to a Wayland output that could affect the overall geometry
      need to be communicated to the Screens class.
      
      Test Plan: Compiles, runtime tested with other patches for rotation.
      
      Reviewers: #kwin, zzag
      
      Reviewed By: #kwin, zzag
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D25900
      f2467684