1. 17 Mar, 2020 1 commit
    • Aleix Pol Gonzalez's avatar
      Fix compiler warnings · cca0e15b
      Aleix Pol Gonzalez authored
      Summary: No need to keep them around for no reason.
      
      Test Plan: Tested the plugins I thought could be affected. Have been using it for a couple of days without problems
      
      Reviewers: #kwin, zzag
      
      Reviewed By: #kwin, zzag
      
      Subscribers: zzag, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D28062
      cca0e15b
  2. 22 Feb, 2020 4 commits
    • Nicolas Fella's avatar
      Revert "[kcm/effects] Clip ListView" · 7159684c
      Nicolas Fella authored
      Bad merge
      
      This reverts commit b7130442.
      7159684c
    • Nicolas Fella's avatar
      [kcm/effects] Clip ListView · b7130442
      Nicolas Fella authored
      Summary:
      Otherwise the content overflows the frame when scrolling.
      
      QQC2 scrollview docs say "ScrollView does not automatically clip its contents. If it is not used as a full-screen item, you should consider setting the clip property to true"
      
      Test Plan:
      Before:
      {F8121150}
      
      After:
      {F8121152}
      
      Reviewers: #kwin, #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27558
      b7130442
    • Nicolas Fella's avatar
      Revert "[kcm/effects] Clip ListView" · cdc5ea19
      Nicolas Fella authored
      Bad merge
      
      This reverts commit 5babf52d.
      cdc5ea19
    • Nicolas Fella's avatar
      [kcm/effects] Clip ListView · 5babf52d
      Nicolas Fella authored
      Summary:
      Otherwise the content overflows the frame when scrolling.
      
      QQC2 scrollview docs say "ScrollView does not automatically clip its contents. If it is not used as a full-screen item, you should consider setting the clip property to true"
      
      Test Plan:
      Before:
      {F8121150}
      
      After:
      {F8121152}
      
      Reviewers: #kwin, #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D27558
      5babf52d
  3. 18 Feb, 2020 1 commit
  4. 10 Nov, 2019 1 commit
  5. 10 Jul, 2019 1 commit
  6. 31 Oct, 2018 1 commit
    • Nate Graham's avatar
      [KCMs] move GHNS buttons to the normal location · 9a59e3fb
      Nate Graham authored
      Summary:
      All other KCMs have their {nav Get New [things]...} buttons in the bottom-right corner. This patch adjusts KWin's KCMs to adopt the same convention there too.
      
      With this patch, all KCMs will have their GHNS buttons in the same location.
      
      Closes T9954
      
      Test Plan:
      {F6375278}
      
      {F6375277}
      
      {F6375276}
      
      {F6375275}
      
      Reviewers: #kwin, #vdg, zzag
      
      Reviewed By: #kwin, zzag
      
      Subscribers: Codezela, kwin, kde-doc-english
      
      Tags: #kwin, #documentation
      
      Maniphest Tasks: T9954
      
      Differential Revision: https://phabricator.kde.org/D16537
      9a59e3fb
  7. 30 Oct, 2018 1 commit
    • David Edmundson's avatar
      [kcmkwin/kwindesktop] Fix global shortcut's display name for kwin changing · ce32b031
      David Edmundson authored
      Summary:
      KGlobalAcceld stores actions grouped by ID and a single display name.
      When an action with a given id changes, the display names change for all
      actions in that
      group.
      
      The KCM sets the ID to "kwin" but does not explicitly set a display
      name. This means it is automatically deduced which will be kcmshell or
      systemsettings.
      
      The end result is all kwin shortcuts get renamed in system setting's
      global shortcuts UI until kwin is restarted.
      
      This patch explicitly sets the dispay name.
      
      BUG: 400248
      Fixed-in: 5.15.0
      
      Test Plan:
      Changed virtual desktops
      Checked global shortcut settings still listed kwin as kwin
      
      Reviewers: #kwin, graesslin
      
      Reviewed By: #kwin, graesslin
      
      Subscribers: graesslin, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D16418
      ce32b031
  8. 05 Jun, 2018 1 commit
  9. 20 Jan, 2017 1 commit
    • Marco Martin's avatar
      use proper packagestructures · 405518c4
      Marco Martin authored
      Summary:
      as the plasmapkg2 utility is dead, scripts and tabboxes couldn't
      be installed anymore, as plasmapkg2 was launched with an hardcoded
      package type (and had a bunch of custom code for it)
      and no packagestructure for the relevant package types existed.
      
      the port of scripts and tabboxes to kpackage in kwin is quite
      incomplete and somewhat strange (given the fact that was started by
      looking manually for the file as it couldn't link to libplasma)
      
      this makes things a bit better as now scripts and tabboxes have an actual
      package structure, making it installable by kpackagetool5.
      in the future, the port should be completed and replace all the manual lookup
      of files with package::filePath as it should work now given that valid
      structures exist
      
      BUG:374766
      
      Test Plan:
      tabbox plugins and kwin scripts can be installed from knewstuff
      again and can be successfully loaded
      
      Reviewers: #plasma, graesslin, subdiff
      
      Reviewed By: #plasma, graesslin
      
      Subscribers: graesslin, plasma-devel, kwin, #kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D4202
      405518c4
  10. 26 Dec, 2016 1 commit
  11. 05 Nov, 2015 1 commit
    • Nick Shaforostoff's avatar
      optimize string operations · 3a8d7d86
      Nick Shaforostoff authored
      -use qstringliteral only when necessary (i.e. not in concat or comparison)
      -use qbytearray instead of qstring when dealing with latin1 input and output (glplatform)
      -use qstringref to extract numbers from strings (glplatform)
      -define qt_use_qstringbuilder to optimize all string concatenations
      -anidata: use ctor init lists, add windowType member initialization
      
      REVIEW: 125933
      3a8d7d86
  12. 06 Mar, 2015 2 commits
    • Sebastian Kügler's avatar
      Fix loading of effect config plugins · 25fc115a
      Sebastian Kügler authored
      X-KDE-ParentComponents is a list, so we have to check if this list
      contains the plugin, not do a string comparison. It seems the
      queryparser has become a bit stricter in this case. This query should be
      fixed anyway, however, and it fixes a fairly important bug in the effect
      system.
      
      REVIEW:122821
      25fc115a
    • Sebastian Kügler's avatar
      Fix loading of effect config plugins · 69fccf9c
      Sebastian Kügler authored
      X-KDE-ParentComponents is a list, so we have to check if this list
      contains the plugin, not do a string comparison. It seems the
      queryparser has become a bit stricter in this case. This query should be
      fixed anyway, however, and it fixes a fairly important bug in the effect
      system.
      
      REVIEW:122821
      69fccf9c
  13. 24 Nov, 2014 1 commit
    • Martin Flöser's avatar
      [kcmkwin/tabbox] Find all layouts in lnf package · 26cf3195
      Martin Flöser authored
      First try to locate all look-and-feel packages and check whether
      they provide a WindowSwitcher. If they do they are inserted in
      the list with the Package name being the user visible name.
      So the good old sidebar is now called "Breeze".
      
      REVIEW: 120914
      26cf3195
  14. 22 May, 2014 2 commits
  15. 28 Apr, 2014 3 commits
  16. 18 Mar, 2014 2 commits
  17. 15 Jan, 2014 1 commit
  18. 08 Jan, 2014 1 commit
  19. 12 Dec, 2013 1 commit
    • Martin Flöser's avatar
      [kcm-kwintabbox] Adjust Preview to the new Switcher API · 058a5da2
      Martin Flöser authored
      Needs to implement a dummy switcher item. As the root item of the
      switchers are no longer QQuickItem derived it cannot use a QQuickView.
      Instead a component gets created and the switcher is just shown on the
      primary screen. It's a more appropriate preview now which is not
      put into a dialog window.
      
      To make it more realistic (and to be able to dismiss it) the preview
      grabs keyboard and mouse and closes itself if escape, return, enter or
      space is pressed.
      
      As well clicking outside the preview window closes the preview.
      058a5da2
  20. 05 Dec, 2013 1 commit
  21. 01 Oct, 2013 1 commit
  22. 30 Sep, 2013 4 commits
  23. 13 Aug, 2013 1 commit
  24. 08 Aug, 2013 1 commit
  25. 24 Apr, 2013 1 commit
    • Martin Flöser's avatar
      Remove show outline from TabBox · badc7a2b
      Martin Flöser authored
      It's an option doing pretty much the same as the highlight of selected
      window option. But it is known to conflict especially with some Plasma
      themes.
      
      BUG: 310935
      FIXED-IN: 4.11
      REVIEW: 110140
      badc7a2b
  26. 12 Mar, 2013 1 commit
  27. 24 Oct, 2012 1 commit
    • Martin Flöser's avatar
      Enable GHNS for Window Switcher · 8176c91b
      Martin Flöser authored
      Thanks to the new category on kde-look.org we can now show the GHNS
      button inside the KCM.
      
      BUG: 297636
      FIXED-IN: 4.9.3
      REVIEW: 106991
      8176c91b
  28. 10 Aug, 2012 1 commit
    • Martin Flöser's avatar
      Remove outdated options from TabBoxConfig · 4782325c
      Martin Flöser authored
      Since the QML port the LayoutMode had been hardcoded to vertical
      layout making it a completely useless code-path.
      
      MinWidth/Height are nowadays completely controlled by the QML
      theme. They were not read anywhere except in the kcm, but there
      not even bound to a ui element.
      
      The selectedItemLayoutName is also not used anymore with the
      new themes.
      4782325c
  29. 01 Jun, 2012 1 commit