1. 20 Jan, 2021 1 commit
  2. 08 Nov, 2020 1 commit
  3. 01 Oct, 2020 1 commit
  4. 07 Aug, 2020 2 commits
    • Vlad Zahorodnii's avatar
      Prettify license headers · 4ce853e8
      Vlad Zahorodnii authored
      4ce853e8
    • Vlad Zahorodnii's avatar
      Switch to SPDX license markers · 1fb9f6f1
      Vlad Zahorodnii authored
      The main advantage of SPDX license identifiers over the traditional
      license headers is that it's more difficult to overlook inappropriate
      licenses for kwin, for example GPL 3. We also don't have to copy a
      lot of boilerplate text.
      
      In order to create this change, I ran licensedigger -r -c from the
      toplevel source directory.
      1fb9f6f1
  5. 07 Apr, 2020 1 commit
    • David Edmundson's avatar
      [kcmkwin] Make dialog non blocking · bee3afdd
      David Edmundson authored
      Summary:
      It's invoked from QML.
      
      Nested event loops invoked directly from QML is asking for crashes.
      
      BUG: 419118
      
      Test Plan:
      Opened KCM
      Opened dialog for some settings
      Window was still modal as before
      Settings were saved
      (though they didn't seem to be applied..maybe another bug?)
      
      Reviewers: #kwin, apol
      
      Reviewed By: apol
      
      Subscribers: zzag, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D28293
      bee3afdd
  6. 30 Mar, 2020 2 commits
    • Vlad Zahorodnii's avatar
      [kcmkwin] Remove redundant lambda · ebf6e691
      Vlad Zahorodnii authored
      Summary:
      We don't need a lambda because QDialog::accepted can be connected
      directly to KCModule::save.
      
      Test Plan: Compiles.
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D28443
      ebf6e691
    • David Edmundson's avatar
      [kcmkwin] Make dialog non blocking · 0a656815
      David Edmundson authored
      Summary:
      It's invoked from QML.
      
      Nested event loops invoked directly from QML is asking for crashes.
      
      BUG: 419118
      
      Test Plan:
      Opened KCM
      Opened dialog for some settings
      Window was still modal as before
      Settings were saved
      (though they didn't seem to be applied..maybe another bug?)
      
      Reviewers: #kwin, apol
      
      Reviewed By: apol
      
      Subscribers: zzag, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D28293
      0a656815
  7. 25 Feb, 2020 1 commit
    • Nate Graham's avatar
      Remove the "Candy" category and fold its contents into "Appearance" · 04aff77f
      Nate Graham authored
      Summary:
      The "Candy" category suffers from some problems:
      - It does not need to exist; everything in it is purely appearance-related and could live in the existing "Appearance" category
      - The name is inappropriate; "Eye Candy" would be better, but changing it to this has proven controversial in the past
      
      Let's just remove the category and move everything in it into the "Appearance" category.
      
      Test Plan:
      Apply and compile
      Open Desktop Effects KCM
      See that the "Candy" category is no more and the "Appearance" category has more stuff in it
      
      Reviewers: #kwin, #vdg, zzag, abetts
      
      Reviewed By: #kwin, #vdg, zzag, abetts
      
      Subscribers: abetts, zzag, kwin, kde-doc-english, GB_2
      
      Tags: #kwin, #documentation
      
      Differential Revision: https://phabricator.kde.org/D27658
      04aff77f
  8. 14 Jan, 2020 1 commit
  9. 30 Dec, 2019 1 commit
  10. 20 Dec, 2019 1 commit
  11. 29 Sep, 2019 1 commit
  12. 09 Jul, 2019 1 commit
  13. 10 Apr, 2019 1 commit
  14. 18 Mar, 2019 8 commits
  15. 12 Feb, 2019 1 commit
  16. 08 Jan, 2019 1 commit
    • Vlad Zahorodnii's avatar
      [kcmkwin] Move effects model into a shared library · c3fd6413
      Vlad Zahorodnii authored
      Summary:
      The main motivation for moving it into a shared library is to share the
      model between Desktop Effects and Virtual Desktops KCM.
      
      The extracted model is quite the same as the one in Desktop Effects KCM,
      except some minor changes, e.g. rename loadEffect and syncConfig to more
      convenient names, add comments, some whitespace changes, fix coding
      style in some parts, etc.
      
      Test Plan: effectModelTest passes, Desktop Effects KCM works.
      
      Reviewers: #kwin, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: hein, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D17765
      c3fd6413
  17. 15 Nov, 2018 1 commit
  18. 28 Sep, 2018 1 commit
    • Vlad Zahorodnii's avatar
      [effects] Make scripted effects GHNS-able · 78ce54f8
      Vlad Zahorodnii authored
      Summary:
      Currently, if one wants to install a scripted effect from the KDE Store,
      the effect won't show up in the Desktop Effects KCM. The reason for that
      is kpackagetool5 doesn't know where to install effects (they have to be
      installed under ${DATA_DIR}/kwin/effects).
      
      Another problem is that even if the scripted effect is installed in the
      right directory (e.g. ~/.local/share/kwin/effects), it won't be listed in
      the Desktop Effects KCM because it doesn't have a desktop file in
      kservices5 dir. Please notice that the effect will be "visible" for KWin, i.e.
      you can enable it by editing kwinrc.
      
      This diff addresses those 2 problems by:
      * Adding a PackageStructure plugin for effects (so they are installed
        under kwin/effects/);
      * Using KPackage::PackageLoader to get list of scripted effect in the
        Desktop Effects KCM.
      
      Test Plan:
      * Installed an effect from the KDE Store, it appeared in the Desktop Effects
        KCM;
      * Removed it.
      
      Reviewers: #kwin, mart, davidedmundson
      
      Reviewed By: #kwin, davidedmundson
      
      Subscribers: ngraham, davidedmundson, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D15372
      78ce54f8
  19. 02 Aug, 2018 1 commit
    • Vlad Zahorodnii's avatar
      [kcmkwin/compositing] Move show desktop effects to their own category · 119d0d8f
      Vlad Zahorodnii authored
      Summary:
      We have two exclusive categories in the Appearance category:
      minimize-animations and show-desktop. But it's hard to draw a line
      between them, i.e. one can't say whether given effect belongs to the
      minimize-animations category or to the show-desktop category.
      
      This change moves show desktop effects to their own category so we have only
      one exclusive category in the Appearance category.
      
      Before:
      {F6160592, layout=center, size=full}
      
      After:
      {F6161173, layout=center, size=full}
      
      Reviewers: #kwin, #plasma, #vdg, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: davidedmundson, graesslin, ngraham, kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D14458
      119d0d8f
  20. 02 Jul, 2018 1 commit
  21. 05 Mar, 2018 1 commit
    • Fabian Vogt's avatar
      Convert EffectView to a QQuickWidget · 68a2ec5d
      Fabian Vogt authored
      Summary:
      The Qt Wayland support for subsurfaces is broken in many ways, producing
      graphical glitches and crashes:
      https://bugreports.qt.io/browse/QTBUG-54888 for instance.
      
      Using a QQuickWidget instead of a QQuickView avoids those issues, with
      the additional benefit of a nicer API.
      
      Test Plan:
      Opened the KCM with kcmshell and systemsettings, no subsurfaces used
      anymore.
      
      Reviewers: #plasma, graesslin, davidedmundson
      
      Reviewed By: #plasma, graesslin, davidedmundson
      
      Subscribers: kwin, plasma-devel, #kwin
      
      Tags: #kwin
      
      Differential Revision: https://phabricator.kde.org/D11066
      68a2ec5d
  22. 21 Oct, 2015 1 commit
    • Martin Flöser's avatar
      [kcmeffects] Do not use root context properties · 76cd1fdc
      Martin Flöser authored
      Apparently it's not allowed to set root context properties multiple
      times. If one goes to systemsettings, opens effects kcm, closes it
      and opens it again it crashes due to setting a context property with
      same name again.
      
      This change eliminates the need for the context property by modifying
      the property of the QML objects directly.
      
      BUG: 354164
      BUG: 351763
      FIXED-IN: 5.4.3
      REVIEW: 125737
      76cd1fdc
  23. 18 Sep, 2015 1 commit
    • Rob Ert's avatar
      [kcmkwin/effects] Support binary effect plugins · 8686ca7c
      Rob Ert authored
      Locates plugins through KPluginMetaData. To improve code
      readability the load method is split into dedicate mehtods for
      * binary plugins
      * builtin effects
      * scripted effects
      
      REVIEW: 125232
      BUG: 352680
      FIXED-IN: 5.4.2
      8686ca7c
  24. 21 Jun, 2014 1 commit
    • Martin Flöser's avatar
      [kcmkwin/compositing] Better check for enabled state of Effects · 99b5426a
      Martin Flöser authored
      Introduces partially checked checkboxes for Effects. If an Effect
      has an enabled by default function and doesn't have an explicit
      value in the config file the checkbox is set to partially. If there
      is a value in the config, this will be used.
      
      Clicking on Default will return to the partially checked state.
      
      So far only the built-in effects support the partially checked state
      and also the mutual exclusive groups do not support the partial checked
      (main reason: RadioButton doesn't support it)
      
      BUG: 336045
      REVIEW: 118658
      99b5426a
  25. 12 Jun, 2014 2 commits
  26. 11 Jun, 2014 2 commits
  27. 06 Jun, 2014 1 commit
  28. 26 May, 2014 1 commit
  29. 15 May, 2014 1 commit