1. 16 Dec, 2020 1 commit
  2. 15 Dec, 2020 4 commits
    • Xaver Hugl's avatar
      Fix login modeset · 2da1b321
      Xaver Hugl authored
      2da1b321
    • Vlad Zahorodnii's avatar
      Remove COPYING-CMAKE-SCRIPTS · c7fb0160
      Vlad Zahorodnii authored
      All find modules contain license information, which renders
      COPYING-CMAKE-SCRIPTS redundant.
      
      The reason why we have this file in the first place is purely
      historical. Back in the kde-workspace repo days, not all find
      modules contained the license under which they're distributed.
      c7fb0160
    • David Edmundson's avatar
      Introduce helper to restart kwin on crash exit · 86c60665
      David Edmundson authored
      Right now when kwin exits, the user is taken directly back to the login
      screen. The login session exits, so all processes then are killed by the
      session.
      
      This patchset introduces a mechanism to safely restart kwin. The socket
      (typically wayland-0) remains alive and persistent across restarts. This
      means if any process reconnects through it's own mechanism or a crash
      restart handler the socket appears to work, and blocks until the new
      kwin restarts.
      
      This makes it secure and race free.
      
      If the screen was locked at the time kwin went down, this is also
      secure. Kwin now checks the status from logind at the time of launch, so
      will immediately restore a locked state before any other rendering.
      86c60665
    • David Edmundson's avatar
      Move m_display construction to the constructor · bac9d554
      David Edmundson authored
      We will always create one, this resolves potential to call a getter on a null object.
      Requires some code shuffling.
      bac9d554
  3. 14 Dec, 2020 3 commits
  4. 13 Dec, 2020 3 commits
    • Vlad Zahorodnii's avatar
      Introduce ColorManager component · 64ad9a61
      Vlad Zahorodnii authored
      This change introduces a new component - ColorManager that is
      responsible for color management stuff.
      
      At the moment, it's very naive. It is useful only for updating gamma
      ramps. But in the future, it will be extended with more CMS-related
      features.
      
      The ColorManager depends on lcms2 library. This is an optional
      dependency. If lcms2 is not installed, the color manager won't be built.
      
      This also fixes the issue where colord and nightcolor overwrite each
      other's gamma ramps. With this change, the ColorManager will resolve the
      conflict between two.
      64ad9a61
    • Vlad Zahorodnii's avatar
      Drop redundant find_package(Qt5Multimedia) · b06fb6b0
      Vlad Zahorodnii authored
      We need the multimedia component only to play preview videos in a KCM.
      
      The find_package(Qt5Multimedia) is not needed because we already check
      if Qt5Multimedia QML module is present using ecm_find_qmlmodule().
      
      The main motivation behind this change is to work around constant build
      failures caused by buggy config file of the Qt5::Multimedia component.
      b06fb6b0
    • Andrey Butirsky's avatar
      Revert "refactor: localize checkLayoutChange() check" · eebae29b
      Andrey Butirsky authored
      This reverts commit c459faba
      
      Fixes kwin_x11 crash on typing regression,
      see original MR for details
      eebae29b
  5. 11 Dec, 2020 6 commits
  6. 10 Dec, 2020 4 commits
    • Vlad Zahorodnii's avatar
      Remove fixqopengl.h · 48728f3b
      Vlad Zahorodnii authored
      Qt stopped defining GLdouble type on uncontrolled ES2 platforms since
      version 5.4.
      48728f3b
    • Vlad Zahorodnii's avatar
      Prevent EGL headers from including Xlib headers · 6b2e6cfd
      Vlad Zahorodnii authored
      One of the annoying things about EGL headers is that they include
      platform headers by default, e.g. on X11, it's Xlib.h, etc.
      
      The problem with Xlib.h is that it uses the define compiler directive to
      declare constants and those constants have very generic names, e.g.
      'None', which typically conflict with enums, etc.
      
      In order to work around bad things coming from Xlib.h, we include
      fixx11.h file that contains some workarounds to redefine some Xlib's
      types.
      
      There's a flag or rather two flags (EGL_NO_PLATFORM_SPECIFIC_TYPES and
      EGL_NO_X11) that are cross-vendor and they can be used to prevent EGL
      headers from including platform specific headers, such as Xlib.h [1]
      
      The benefit of setting those two flags is that you can simply include
      EGL/egl.h or epoxy/egl.h and the world won't explode due to Xlib.h
      
      MESA_EGL_NO_X11_HEADERS is set to support older versions of Mesa.
      
      [1] https://github.com/KhronosGroup/EGL-Registry/pull/111
      6b2e6cfd
    • Vlad Zahorodnii's avatar
    • Vlad Zahorodnii's avatar
      Provide expected presentation time to effects · 9f2cb0ae
      Vlad Zahorodnii authored
      Effects are given the interval between two consecutive frames. The main
      flaw of this approach is that if the Compositor transitions from the idle
      state to "active" state, i.e. when there is something to repaint,
      effects may see a very large interval between the last painted frame and
      the current. In order to address this issue, the Scene invalidates the
      timer that is used to measure time between consecutive frames before the
      Compositor is about to become idle.
      
      While this works perfectly fine with Xinerama-style rendering, with per
      screen rendering, determining whether the compositor is about to idle is
      rather a tedious task mostly because a single output can't be used for
      the test.
      
      Furthermore, since the Compositor schedules pointless repaints just to
      ensure that it's idle, it might take several attempts to figure out
      whether the scene timer must be invalidated if you use (true) per screen
      rendering.
      
      Ideally, all effects should use a timeline helper that is aware of the
      underlying render loop and its timings. However, this option is off the
      table because it will involve a lot of work to implement it.
      
      Alternative and much simpler option is to pass the expected presentation
      time to effects rather than time between consecutive frames. This means
      that effects are responsible for determining how much animation timelines
      have to be advanced. Typically, an effect would have to store the
      presentation timestamp provided in either prePaint{Screen,Window} and
      use it in the subsequent prePaint{Screen,Window} call to estimate the
      amount of time passed between the next and the last frames.
      
      Unfortunately, this is an API incompatible change. However, it shouldn't
      take a lot of work to port third-party binary effects, which don't use the
      AnimationEffect class, to the new API. On the bright side, we no longer
      need to be concerned about the Compositor getting idle.
      
      We do still try to determine whether the Compositor is about to idle,
      primarily, because the OpenGL render backend swaps buffers on present,
      but that will change with the ongoing compositing timing rework.
      9f2cb0ae
  7. 09 Dec, 2020 9 commits
  8. 08 Dec, 2020 5 commits
  9. 07 Dec, 2020 3 commits
  10. 05 Dec, 2020 1 commit
  11. 04 Dec, 2020 1 commit