Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KWin KWin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 44
    • Issues 44
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 115
    • Merge requests 115
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • KWinKWin
  • Merge requests
  • !1828

backends/drm: improve dmabuf feedback

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Xaver Hugl requested to merge work/better-feedback into master Dec 30, 2021
  • Overview 4
  • Commits 2
  • Pipelines 4
  • Changes 8

Commit 1: limit modifiers to those supported by egl. While the format+modifiers supported by drm are usually also supported by egl, there's not really a guarantee for that - and if a client were to use one of those format+modifier pairs, buffer import could fail. That's not necessarily a big deal but it's more efficient to prevent it from happening

Commit 2: Instead of only allowing the current format, send the default tranches modified to only contain formats and modifiers suitable for scanout. In order to not fail when we can't do direct scanout with a given format (because that may require a modeset, which we don't allow), keep a blacklist of attempted formats and modifiers for the current client.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/better-feedback