Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit 110fa039 authored by David Edmundson's avatar David Edmundson

Use consistent size icon in OSD

Summary:
The OSD's icon is based on the implicitSize of the IconItem.

For most icons this will be a hardcoded value from
KIconLoader::global()->currentSize

However, since bc33f0470d4d6bcbf30475f85b36705e8a99528b in
plasma-framework we sometimes return that value, sometimes will return the
source size of the underlying image depending on internal paths of how
the icon is loaded and whether it was in the plasma theme or not.

This patch overrides the implicitWidth given to the layout to be the
standard icon size.

BUG: 400083

Test Plan:
Loaded the force kill window OSD.
Icon still looked the same size on breeze.

I didn't reproduce the issue in the bug

Reviewers: #kwin, graesslin

Reviewed By: #kwin, graesslin

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16432
parent a60edb50
......@@ -35,8 +35,8 @@ PlasmaCore.Dialog {
mainItem: RowLayout {
PlasmaCore.IconItem {
Layout.minimumWidth: 64
Layout.minimumHeight: 64
implicitWidth: PlasmaCore.Units.iconSizes["medium"]
implicitHeight: implicitWidth
source: osd.iconName
visible: osd.iconName != ""
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment