Commit 456c65fc authored by Vlad Zahorodnii's avatar Vlad Zahorodnii

Verify that there is no scene windows when Scene is about to be destroyed

Summary:
When ~Scene is called, it's not guaranteed that backend is still valid
or that there is current opengl context. So, generally speaking,
deleting scene windows in ~Scene is a bad idea.

It's okay not to delete scene windows in ~Scene because current
implementation of Compositor::finish ensures that they don't last longer
than the scene.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D19540
parent 297557bd
......@@ -100,7 +100,7 @@ Scene::Scene(QObject *parent)
Scene::~Scene()
{
qDeleteAll(m_windows);
Q_ASSERT(m_windows.isEmpty());
}
// returns mask and possibly modified region
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment