Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit 6c714032 authored by David Edmundson's avatar David Edmundson

[autotests] Hopefully stabilise TestShellClient

Summary:
Apparently this test is flaky, based on the output I recieved we had
processed the un-fullscreen but not the un-maximise.

It seems possible the wayland thread could process when there's only one
request in the queue.

Test Plan:
Couldn't reproduce the original issue, it's a blind patch but the
current tests still pass.

Reviewers: #kwin

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16955
parent 01b75b39
......@@ -730,7 +730,10 @@ void TestShellClient::testMaximizedToFullscreen()
QVERIFY(fullscreenChangedSpy.wait());
if (decoMode == ServerSideDecoration::Mode::Server) {
QVERIFY(sizeChangeRequestedSpy.wait());
// don't check count, XDG might legitimately get two updates
// XDG will legitimately get two updates. They might be batched
if (xdgShellSurface && sizeChangeRequestedSpy.count() == 1) {
QVERIFY(sizeChangeRequestedSpy.wait());
}
// fails as we don't correctly call setMaximize(false)
// but realistically the only toolkits that support the deco also use XDGShell
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment