Members of the KDE Community are recommended to subscribe to the kde-community mailing list at to allow them to participate in important discussions and receive other important announcements

Commit 91e69e3f authored by Vlad Zahorodnii's avatar Vlad Zahorodnii

[libkwineffects] Use more std::transform in implementation part

Summary: These two should have been in D13821 but I missed them somehow.

Test Plan:
* Ran `qdbus org.kde.KWin /Effects loadedEffects`

* Ran the following Python script

import dbus

bus = dbus.SessionBus()

effects_object = bus.get_object('org.kde.KWin', '/Effects')
effects_iface = dbus.Interface(

names = (

supported_statuses = effects_iface.areEffectsSupported(names)

for name, supported in zip(names, supported_statuses):
    print("%s: %s" % (name, supported))

Got the following output:

slide: 1
pizza: 0
cube: 1

Reviewers: #kwin, mart

Reviewed By: #kwin, mart

Subscribers: kwin

Tags: #kwin

Differential Revision:
parent 81d851f6
......@@ -1310,9 +1310,10 @@ void EffectsHandlerImpl::toggleEffect(const QString& name)
QStringList EffectsHandlerImpl::loadedEffects() const
QStringList listModules;
for (QVector< EffectPair >::const_iterator it = loaded_effects.constBegin(); it != loaded_effects.constEnd(); ++it) {
listModules << (*it).first;
std::transform(loaded_effects.constBegin(), loaded_effects.constEnd(),
[](const EffectPair &pair) { return pair.first; });
return listModules;
......@@ -1389,12 +1390,15 @@ bool EffectsHandlerImpl::isEffectSupported(const QString &name)
QList< bool > EffectsHandlerImpl::areEffectsSupported(const QStringList &names)
QList<bool> EffectsHandlerImpl::areEffectsSupported(const QStringList &names)
QList< bool > retList;
for (const QString &name : names) {
retList << isEffectSupported(name);
QList<bool> retList;
std::transform(names.constBegin(), names.constEnd(),
[this](const QString &name) {
return isEffectSupported(name);
return retList;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment