Commit d16f63b6 authored by Sebastian Kügler's avatar Sebastian Kügler

inform outputconfiguration clients that a change has been applied

Summary:
After changing the output configuration, the client expects that it is informed
whether or not a new configuration has been applied (or failed). This was ommitted
so far, meaning that clients wouldn't know what happened in kwin.

Since we don't track if a setting failed yet, send the applied() signal regardless.

CCBUG:384733

Test Plan: Verified that the signal arrived in libkscreen after changing scale of an output

Reviewers: graesslin, davidedmundson

Reviewed By: davidedmundson

Subscribers: kwin, #kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D7910
parent 41e55956
......@@ -23,12 +23,14 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#include "cursor.h"
#include "effects.h"
#include "input.h"
#include <KCoreAddons>
#include "overlaywindow.h"
#include "outline.h"
#include "pointer_input.h"
#include "scene.h"
#include "screenedge.h"
#include "wayland_server.h"
#include <KWayland/Server/outputconfiguration_interface.h>
namespace KWin
{
......@@ -115,6 +117,11 @@ void Platform::configurationChangeRequested(KWayland::Server::OutputConfiguratio
{
Q_UNUSED(config)
qCWarning(KWIN_CORE) << "This backend does not support configuration changes.";
// KCoreAddons needs kwayland's 2b3f9509ac1 to not crash
if (KCoreAddons::version() >= QT_VERSION_CHECK(5, 39, 0)) {
config->setFailed();
}
}
void Platform::setSoftWareCursor(bool set)
......
......@@ -40,6 +40,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#include <KWayland/Server/outputconfiguration_interface.h>
// KF5
#include <KConfigGroup>
#include <KCoreAddons>
#include <KLocalizedString>
#include <KSharedConfig>
// Qt
......@@ -535,6 +536,10 @@ void DrmBackend::configurationChangeRequested(KWayland::Server::OutputConfigurat
drmoutput->setChanges(changeset);
}
emit screens()->changed();
// KCoreAddons needs kwayland's 2b3f9509ac1 to not crash
if (KCoreAddons::version() >= QT_VERSION_CHECK(5, 39, 0)) {
config->setApplied();
}
}
DrmOutput *DrmBackend::findOutput(quint32 connector)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment