Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit e38ecfcb authored by Vlad Zahorodnii's avatar Vlad Zahorodnii

[effects/slide] Completely delete forced roles

Summary:
The slide effect doesn't completely remove forced blur and background
contrast roles. According to `EffectWindow::setData` implementation,

```lang=cpp
void EffectWindowImpl::setData(int role, const QVariant &data)
{
    if (!data.isNull())
        dataMap[ role ] = data;
    else
        dataMap.remove(role);
    emit effects->windowDataChanged(this, role);
}
```

in order to delete previously set data, we should pass a null variant.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D13470
parent 1a1845b7
......@@ -456,12 +456,12 @@ void SlideEffect::start(int old, int current, EffectWindow* movingWindow)
void SlideEffect::stop()
{
for (EffectWindow* w : m_forcedRoles.blur) {
w->setData(WindowForceBlurRole, QVariant(false));
w->setData(WindowForceBlurRole, QVariant());
}
m_forcedRoles.blur.clear();
for (EffectWindow* w : m_forcedRoles.backgroundContrast) {
w->setData(WindowForceBackgroundContrastRole, QVariant(false));
w->setData(WindowForceBackgroundContrastRole, QVariant());
}
m_forcedRoles.backgroundContrast.clear();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment