Members of the KDE Community are recommended to subscribe to the kde-community mailing list at to allow them to participate in important discussions and receive other important announcements

Commit f4663072 authored by Vlad Zahorodnii's avatar Vlad Zahorodnii

[libkwineffects] Use correct type for the desktops property

Type of the x11DesktopIds property was changed from QList<int> to
QVector<int> in KWin core, but not in libkwineffects. That resulted in
having effects like slide not working because Qt can't implicitly
convert QVector<int> to QList<int>.

Test Plan: Slide effect works again.

Reviewers: #kwin, graesslin

Reviewed By: #kwin, graesslin

Subscribers: kwin

Tags: #kwin

Differential Revision:
parent 7b08886e
......@@ -857,11 +857,7 @@ WINDOW_HELPER(QString, windowRole, "windowRole")
WINDOW_HELPER(QStringList, activities, "activities")
WINDOW_HELPER(bool, skipsCloseAnimation, "skipsCloseAnimation")
WINDOW_HELPER(KWayland::Server::SurfaceInterface *, surface, "surface")
QList<int> EffectWindow::desktops() const
return parent()->property("x11DesktopIds").value<QList<int> >();
WINDOW_HELPER(QVector<int>, desktops, "x11DesktopIds")
QString EffectWindow::windowClass() const
......@@ -988,7 +984,7 @@ bool EffectWindow::isOnCurrentDesktop() const
bool EffectWindow::isOnDesktop(int d) const
const QList<int> ds = desktops();
const QVector<int> ds = desktops();
return ds.isEmpty() || ds.contains(d);
......@@ -2091,7 +2091,7 @@ public:
* a length of 1, on Wayland can be any subset.
* If the list is empty it means the window is on all desktops
QList<int> desktops() const;
QVector<int> desktops() const;
int x() const;
int y() const;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment