Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14350

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14369

Summary:
The descriptor blocks with strings come every 18 bytes,
5 are the header, e.g. for the model:
[0x00 0x00 0x00 0xFC 0x00] followed by the data (13 bytes).

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14410

Summary:
With the movement to support running unittests pre-installation and KDE CI
having adapted to that for some build setups, this currently breaks tests
which rely on subject-under-test D-Bus services being auto-started from
D-Bus service files, given the D-Bus daemon does not see the uninstalled
ones.

One solution might be to catch that situation and do the start of the D-Bus
service ourselves, but I failed to get this done quickly. So as intermediate
solution, to at least have the in-process tests no longer being covered by
the out-of-process ones failing, this patch will just skip the
out-of-process tests if the D-Bus service could not be started.
That follows the current behaviour of e.g. the KGlobalShortcutTest from
KF5's kglobalaccel.

Test Plan:
TestInProcess no longer fails if the org.kde.KScreen D-Bus service cannot be
autostarted.

Reviewers: dfaure, sebas, gladhorn

Reviewed By: gladhorn

Subscribers: gladhorn, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13871

Reviewers: #plasma, romangg

Reviewed By: #plasma, romangg

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14370

Reviewers: davidedmundson

Reviewed By: davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14381

Summary: In KWayland, the refresh rate is mHz, so to show it to the user, divide by 1000.

Reviewers: davidedmundson

Reviewed By: davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14374

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14352

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14351

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14349

Summary: Unlike qDebug there is no automatic space added in QTextStream/stderr.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14167

Summary:
These changes don't matter in the big picture but hopefully make the code easier to read.
Save a few bits by using the right types.

Reviewers: #plasma

Subscribers: zzag, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14081

This string is only used for debug messages, so it actually doesn't matter much.

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14078

Summary:
Compile without casting to/from ascii to avoid typical mistakes due to
implicit conversions. Fix a bunch of dubious places.

Test Plan: Things compile, tests run.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: zzag, anthonyfieroni, broulik, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14060

Summary:
all other cases remove the key they were looking for, this seems to
be a copy and paste error.

Test Plan: tests are not affected.

Reviewers: broulik, davidedmundson

Reviewed By: broulik, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14048

Summary: This is cleaner since it will track the life-time.

Reviewers: broulik

Reviewed By: broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14058

Summary: XRandR::outputEdid is used in only one place, let it return a byte array directly.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: zzag, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14044

GIT_SILENT

While unlikely to be problematic here, silence warning and rather be
safe.

This is just clutter, the constructor is called anyway.

Summary:
Configuration change requests by clients while the Wayland server is
processing a change lead to a failing assert in blockSignals().

Instead in such a situation remember the latest configuration change request
and apply it after the current change has been processed.

Test Plan:
Auto test exposing the problem. Also manually with my output color correction
code.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12517

Cmp. docs of KDECMakeSettings

GIT_SILENT