GitLab

GIT_SILENT

GIT_SILENT

GIT_SILENT

We agreed to use C++17 in Plasma. Document this decision here

Otherwise those includes may resolve to the installed headers which may lead to unpleasant results

GIT_SILENT

GIT_SILENT

A clang-format file is auto-generated on every build in the source directory
since some recent change in ECM. The file is for local use only and not meant
to go into the remote repository.

Final Conventional Commits v1.0.0 specification has been released some
time ago. Let's us it.

This reverts commit 75797e16.

Needs to follow the commit message guideline. Also because it happened before
needs a review.

CCMAIL: montel@kde.org

Summary:
I forgot to copy over the tablet-mode-available and -engaged data from one
config to the next one. Because of that the data was not available to the
daemon.

Also serialize the tablet mode properties in the Serializer. The Serializer
is not used on Wayland afaik but if at one point for example the RandR backend
gains auto rotation support we need to have it in the Serializer.

BUG: 418739

Test Plan: Manually with hard-coded tablet mode availability in KWin.

Reviewers: #plasma, bshah

Reviewed By: #plasma, bshah

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28106

Summary:
DSI connector type is widely used in mobile and tablet devices. Consider
them embedded so auto-rotation feature is available.

Test Plan: tested on pinephone and pinetab which have a DSI displays

Reviewers: romangg, davidedmundson

Reviewed By: davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27806

Summary:
Related kwin_wayland patches have been landed for rotation, so enable
the relevant features.

Depends on: D26036

Test Plan: tested on Dell Inspiron 13 7xxx series laptop with mentioned kwin change applied

Reviewers: romangg, davidedmundson

Reviewed By: romangg

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27723

Summary:
Fixes a null pointer dereference in GetConfigOperation when BackendManager
fails to load a valid backend.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27625

Summary:
During login creating the connection to Wayland server may take longer
than 1 second (KWin busy, high CPU and IO load, ...) causing
WaylandConfig to time out and leave the backend in an inconsistent
state.

This patch increases the timeout to 3 seconds and sets the overall
backend status to invalid if connecting to Wayland server times out.
This will abort the pending KScreen operation and prevent it from
interacting with the broken backend. The next KScreen operation
will try to set up the backend again, hopefully successfully this time.

BUG: 416566
FIXED-IN: 5.18.2

Reviewers: #plasma, romangg

Reviewed By: #plasma, romangg

Subscribers: romangg, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27618

Summary:
Fixes the simpleWrite test.

Test Plan: simpleWrite test passes

Reviewers: #plasma, romangg

Reviewed By: #plasma, romangg

Subscribers: romangg, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27537

The commit message in wrong as the type must be `test` since this is a fix to
an autotest. And the scope `autotest` does not exist.

See https://cgit.kde.org/libkscreen.git/tree/CONTRIBUTING.md

The commit may be reapplied with correct header. See also
https://phabricator.kde.org/D27537#615130 for a suggestion.

This reverts commit 2fcd0939.

Summary:
The test still fails on removeOutput test, but that's fixed by
D27536.

Test Plan: simpleWrite test passes

Reviewers: #plasma, romangg

Reviewed By: #plasma, romangg

Subscribers: romangg, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27537

Summary:
BUG: 413892
FIXED-IN: 5.18.2

Reviewers: #plasma, davidedmundson, meven

Reviewed By: #plasma, davidedmundson, meven

Subscribers: meven, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27536

GIT_SILENT

Summary:
Without this patch the blue from the "primary" output 'leaks' into the
prompt of some shells (e.g. busybox ash).

Test Plan: Run "kscreen-doctor -o" in ash and observe that the prompt isn't blue anymore afterwards.

Reviewers: davidedmundson

Reviewed By: davidedmundson

Subscribers: romangg, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27383

GIT_SILENT

Summary:
On init of the tablet mode the d-bus connection to KWin for receiving tablet
mode information is blocking for some reason for over one second. This leads
to the single shot timer timing out before the Wayland interfaces can be
received.

For now move the blocking call before the timer is started such that we do
not fail anymore.

Note that the d-bus call is only blocking unusual long on session startup.
Later d-bus calls return without prolonged delay.

Test Plan: Starts without seg fault on output management object in applyConfig.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26658

GIT_SILENT

GIT_SILENT

When an output gets enabled we directly want to set the logical size. But at
this point because of the order of calls in XRandRConfig the crtc is not yet
set on the output.

To fix this in a quick way just provide the free crtc as an argument. Long-term
change the order of calls.

Summary:
This adds feature flags if a backend supports auto rotations. While this is not
directly a function of a backend on X11 auto rotation is not tested fully yet
and there are problems with touch input. This way a client can query if auto
rotation is fully functional on a backend.

For the KWayland backend auto rotation and tablet mode information querying is
already wired up but for now deactivated until all KWin patches have been
landed.

Test Plan:
Compiles and tests with an XPS 2-in-1, which sadly does not send events about
the tablet state.

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26281

Summary:
Just overriding the logical size of an output that replicates another one is
simpler than trying to send a relation between both objects to the display
server and in case of X11 it is not possible.

Wires up support for that in the X11 backend.

Test Plan: Compiles. Wayland replication tested.

Reviewers: #kwin

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26309

Summary:
This adds a document providing information on how to contribute to libkscreen
and additionally a minimal readme file pointing to it.

The contributing guide is the analogous to a newly added one in KScreen.

It includes clarifications about the used coding style and introduces a Commit
Message Guideline based on the KDE Commit Policy and the Conventional Commits
specification.

Reviewers: #plasma

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25064

Summary:
This allows devs to run: "make clang-format" and format all files easily
using the preset KDE clang format style

This patch adds support so devs can easily test the intended formatting
now, it doesn't change the code yet.

Doing an initial run to commit everything will happen later.

Test Plan:
Ran script
git diff was full of amazingly cleaned code

See D25134

Summary: It it initialized 4 lines prior. Once should be enough.

Test Plan: addOutput/removeOutput isn't duplicated any more

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24718

GIT_SILENT