Skip to content
GitLab
Menu
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Plasma
libksysguard
Commits
8cd7d7f6
Commit
8cd7d7f6
authored
Apr 14, 2021
by
David Redondo
🏎
Browse files
Do not leak the created QQuickItems
The items returned by beginCreate() are owned by us.
parent
5e548060
Changes
1
Hide whitespace changes
Inline
Side-by-side
faces/SensorFaceController.cpp
View file @
8cd7d7f6
...
...
@@ -311,6 +311,7 @@ SensorFace *SensorFaceControllerPrivate::createGui(const QString &qmlPath)
context
->
setParent
(
gui
);
gui
->
setController
(
q
);
gui
->
setParent
(
q
);
component
->
completeCreate
();
...
...
@@ -338,6 +339,7 @@ QQuickItem *SensorFaceControllerPrivate::createConfigUi(const QString &file, con
QQuickItem
*
gui
=
qobject_cast
<
QQuickItem
*>
(
guiObject
);
Q_ASSERT
(
gui
);
context
->
setParent
(
gui
);
gui
->
setParent
(
q
);
component
->
deleteLater
();
...
...
David Redondo
🏎
@davidre
mentioned in commit
c5a71b1b
·
Apr 14, 2021
mentioned in commit
c5a71b1b
mentioned in commit c5a71b1b9641e31b73b9f82f58ca98a4d7181a4f
Toggle commit list
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment