Commit fea15a87 authored by Arjen Hiemstra's avatar Arjen Hiemstra
Browse files

Prevent inadvertently writing config when destroying SensorFaceController

In certain cases, we may end up with a dirty config which we do not want
to store. So explicitly cleanup the config objects before destruction to
prevent them from being written.

BUG:428970


(cherry picked from commit bf2d0ece)
parent 7801ce60
......@@ -386,6 +386,16 @@ SensorFaceController::SensorFaceController(KConfigGroup &config, QQmlEngine *eng
SensorFaceController::~SensorFaceController()
{
if (!d->shouldSync) {
// If we should not sync automatically, clear all changes before we
// destroy the config objects, otherwise they will be written during
// destruction.
d->appearanceGroup.markAsClean();
d->colorsGroup.markAsClean();
if (d->faceConfigLoader->isSaveNeeded()) {
d->faceConfigLoader->load();
}
}
}
QString SensorFaceController::title() const
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment