1. 08 Mar, 2021 2 commits
  2. 05 Mar, 2021 2 commits
  3. 04 Mar, 2021 3 commits
    • David Redondo's avatar
      Refactor so that the methods of AbstractProcesses return the actual error · 0ed84fe6
      David Redondo authored
      Checking if the return value is false and then acessing the last error is
      not very elegant. Instead we can directly return the actual error. This does
      not yet extend to public API in Processes but the same can be easily done there
      in the future.
      0ed84fe6
    • David Edmundson's avatar
      Move CGroup pid fetching callback to the controller · 18937f39
      David Edmundson authored
      The CGroup class started out as a dumb data store, that did some
      fetching of relevant data.
      
      It then gained a more complex async operation. The lifepsan of the
      CGgroup object is managed by the model, so could get deleted whilst the
      runnable was running. QRunnables and non-qobjects leds to a lot of
      potential problems. There was a complex mutex and a wait condition, yet
      it still misses a case only solvable with yet more mutexes.
      
      By moving the callback handling logic to the controller, we can guard
      everything in a safer more Qt manner without any overhead and with
      simpler code.
      
      There is a behavioural change if you call pids whilst things are
      loading, but given a signal is emitted when pids load that's fine.
      
      This class is exported, but the header was never installed.
      Whilst technically it is an ABI break it pragmantically will have no
      impact whatsoever.
      
      BUG: 430615
      18937f39
    • Nicolas Fella's avatar
  4. 03 Mar, 2021 1 commit
  5. 01 Mar, 2021 9 commits
  6. 26 Feb, 2021 2 commits
  7. 23 Feb, 2021 2 commits
    • Arjen Hiemstra's avatar
      Set min/max for Y axis range spinboxes to minimum/maximum possible value · 504dcbd2
      Arjen Hiemstra authored
      Some sensors have a range of gigabytes or terabytes, like memory and
      disk. Since the base unit for these is bytes, we end up needing a very
      large value in the range, which currently is not possible due to the
      spinbox limiting the value. Internally, spinbox seems to use an int so
      we can only store a value that fits within the range of an int, so we
      use that as min/max value.
      
      Longer term we want to have some ability to choose an actual "maximum"
      sensor but that's going to need more work.
      
      BUG: 433007
      BUG: 424527
      504dcbd2
    • David Redondo's avatar
      Guard against null configloader in destructor · 34eb6ce9
      David Redondo authored
      We do not necessarily have a config loader (invalid id or when the face does
      not have any config options).
      BUG:433431
      FIXED-IN:5.21.1
      34eb6ce9
  8. 18 Feb, 2021 1 commit
  9. 11 Feb, 2021 2 commits
  10. 09 Feb, 2021 1 commit
  11. 04 Feb, 2021 3 commits
  12. 02 Feb, 2021 2 commits
    • David Redondo's avatar
      Do the sensor setters in two stages · f0600a7e
      David Redondo authored
      When saveConfig() in ConfigSensors.qml is called we started resolving sensors,
      when during this time loadConfig() was called we returned the old sensors, which
      when then triggeded another saveConfig() call by  plasma-systemmonitor leading us to
      effectively reset ourselves.
      The setters are now in two stages, during resolving time we set the properties
      to the unresolved value, so we are in sync with what the qml part did. Also we not
      do another resolve when something tries to set the current unresolved ids.
      BUG:432254
      f0600a7e
    • Laurent Montel's avatar
      Use autorcc directly · 59a0b9e3
      Laurent Montel authored
      59a0b9e3
  13. 30 Jan, 2021 1 commit
  14. 28 Jan, 2021 1 commit
  15. 25 Jan, 2021 5 commits
  16. 22 Jan, 2021 1 commit
  17. 21 Jan, 2021 2 commits